apainintheneck
70451ea7b1
Add cop to stop bin in service block
...
The preferred method is opt_bin because that works
with the API and is more portable (works between versions).
Also removed the last example from the docs of `bin/"name"`
from the service block section
2023-04-04 20:00:30 -07:00
Douglas Eichelberger
ba2d18db36
brew style --fix
2023-04-04 18:14:54 -07:00
Douglas Eichelberger
c0092c2fd2
Move and re-namespace HeadVersion
2023-04-04 18:14:54 -07:00
Douglas Eichelberger
a237a1ff9f
Update call sites
2023-04-04 18:14:54 -07:00
Douglas Eichelberger
29f93fb6f2
Add tests
2023-04-04 18:14:54 -07:00
Douglas Eichelberger
0ca4f7eebb
Add Version#compare
2023-04-04 18:14:54 -07:00
Carlo Cabrera
0c56540831
Fix --dependents
breakage
...
Without this, we sometimes mistakenly assign runners to dependents jobs
when we don't have to.
2023-04-05 04:25:28 +08:00
Carlo Cabrera
868f9395b6
Extract code to GitHubRunnerMatrix
class
...
The `GitHubRunnerMatrix` takes a list of testing formulae, deleted
formulae, and the available runners and constructs the matrix of active
runners for any given test job.
2023-04-05 03:52:26 +08:00
Yukai Chou
b1b94187af
tap: tighten formula_file?(file)
...
Cask is never a formula.
2023-04-05 03:41:11 +08:00
Mike McQuaid
97d7a5c9b4
Merge pull request #15137 from Homebrew/dependabot/bundler/Library/Homebrew/parser-3.2.2.0
...
build(deps): bump parser from 3.2.1.1 to 3.2.2.0 in /Library/Homebrew
2023-04-04 18:46:11 +01:00
Carlo Cabrera
49e8d088ae
Move TestRunnerFormula
class into a separate file
2023-04-05 01:18:11 +08:00
Carlo Cabrera
409ec34236
Update completions.
...
Generated with `brew generate-man-completions`
2023-04-05 01:11:14 +08:00
Carlo Cabrera
26726adc21
determine-test-runners: refactor
...
This supports extraction into separate modules/files.
2023-04-05 01:09:56 +08:00
Issy Long
8adaada399
Merge pull request #15149 from issyl0/more-noisy-on-unknown-cask-methods
2023-04-04 17:54:30 +01:00
JBYoshi
dcc4ae76e8
Also keep app directories with "brew reinstall".
2023-04-04 11:36:27 -05:00
Issy Long
53a17b921f
Make --display-failures-only
help hidden as it's deprecated
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-04-04 17:17:19 +01:00
Issy Long
7cfa544aec
cask/utils: Make more noise when encountering undefined methods
...
- https://github.com/Homebrew/homebrew-cask/actions/runs/4608585102/jobs/8144571098
introduced syntax errors for the `mattermost` cask (`autoupdates`
instead of `auto_updates`), but CI didn't fail so we didn't notice
until it shipped to users and broke `brew update`.
2023-04-04 17:08:54 +01:00
Carlo Cabrera
5194e5c65e
Check for --eval-all
before using HOMEBREW_EVAL_ALL
2023-04-05 00:03:58 +08:00
Mike McQuaid
41e7ee7b51
Merge pull request #15125 from issyl0/rubocops-cask-verified-url-with-path-ending-slash
...
rubocops/cask: Ensure that "verified" URLs with paths end with "/"
2023-04-04 16:30:09 +01:00
JBYoshi
5c9fa845a8
Add unit test for upgrading.
2023-04-04 10:22:45 -05:00
Issy Long
7bb20a3b83
Skip if the URL stanza has only two path components
...
https://github.com/Homebrew/homebrew-cask-fonts/pull/7336#discussion_r1156325651
2023-04-04 16:11:44 +01:00
Carlo Cabrera
a4ebb96fe6
Remove MacOS
definition from generic OS
...
We don't want to define `MacOS` in the generic OS, so let's make sure we
refer to it as `OS::Mac` in the places we need it.
This reverts commit 575cb0263cb1428c63b9428bbd913ffde83bd317.
2023-04-04 23:10:51 +08:00
Ruoyu Zhong
5c9e073cd5
commands: fix completion descriptions for shell commands too
...
This was missed in #15146 .
Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2023-04-04 23:04:13 +08:00
Ruoyu Zhong
4305443c9c
commands: explain change in command description splitting
...
A comment here would help the reader to understand the need for this
splitting logic, which is not so straightforward.
Addresses review comment in
https://github.com/Homebrew/brew/pull/15146#discussion_r1157361656 .
Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2023-04-04 22:50:40 +08:00
Mike McQuaid
0048a86673
Merge pull request #15135 from Homebrew/dependabot/bundler/Library/Homebrew/addressable-2.8.2
...
build(deps): bump addressable from 2.8.1 to 2.8.2 in /Library/Homebrew
2023-04-04 15:37:46 +01:00
Carlo Cabrera
575cb0263c
determine-test-runners: fix generic OS test failures
...
Without this, testing on the generic OS results in errors like
Error: uninitialized constant Homebrew::MacOS
2023-04-04 22:34:17 +08:00
Carlo Cabrera
845506ba02
Merge pull request #15146 from ZhongRuoyu/completions-short-desc
2023-04-04 20:29:16 +08:00
Ruoyu Zhong
68b63427c6
commands: fix completion descriptions
...
Currently, zsh and fish shell completions show incomplete descriptions
for certain commands. For example:
docs -- Open Homebrew's online documentation (https://docs
rbenv-sync -- Create symlinks for Homebrew's installed Ruby versions in ~/
This is because `Commands.command_description` produces incomplete
short descriptions for the commands having a dot (from a URL or a path)
in the first sentence; the dot is misinterpreted as a full stop:
brew(main):001:0> Commands.command_description("docs", short: true)
=> "Open Homebrew's online documentation (https://docs "
brew(main):002:0> Commands.command_description("rbenv-sync", short: true)
=> "Create symlinks for Homebrew's installed Ruby versions in ~/"
We can improve the sentence splitting logic by only splitting at dots
either at the end or followed by a whitespace. Now With this change:
brew(main):001:0> Commands.command_description("docs", short: true)
=> "Open Homebrew's online documentation (https://docs.brew.sh ) in a browser"
brew(main):002:0> Commands.command_description("rbenv-sync", short: true)
=> "Create symlinks for Homebrew's installed Ruby versions in ~/.rbenv/versions"
Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2023-04-04 18:39:13 +08:00
BrewTestBot
9217c90bbb
Update RBI files for addressable.
...
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml ) workflow.
2023-04-04 09:32:44 +00:00
BrewTestBot
1c425c1e6f
brew vendor-gems: commit updates.
2023-04-04 09:25:57 +00:00
BrewTestBot
16e17d63be
Update RBI files for parser.
...
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml ) workflow.
2023-04-04 09:21:14 +00:00
dependabot[bot]
19c122955c
build(deps): bump addressable from 2.8.1 to 2.8.2 in /Library/Homebrew
...
Bumps [addressable](https://github.com/sporkmonger/addressable ) from 2.8.1 to 2.8.2.
- [Release notes](https://github.com/sporkmonger/addressable/releases )
- [Changelog](https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sporkmonger/addressable/compare/addressable-2.8.1...addressable-2.8.2 )
---
updated-dependencies:
- dependency-name: addressable
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-04-04 09:19:15 +00:00
BrewTestBot
91226a3131
brew vendor-gems: commit updates.
2023-04-04 09:15:32 +00:00
dependabot[bot]
0640dbbe09
build(deps): bump parser from 3.2.1.1 to 3.2.2.0 in /Library/Homebrew
...
Bumps [parser](https://github.com/whitequark/parser ) from 3.2.1.1 to 3.2.2.0.
- [Release notes](https://github.com/whitequark/parser/releases )
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/whitequark/parser/compare/v3.2.1.1...v3.2.2.0 )
---
updated-dependencies:
- dependency-name: parser
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-04-04 09:11:40 +00:00
Mike McQuaid
7dbe1b4877
Merge pull request #15142 from Homebrew/revert-15112-prof-group
...
Revert "Split prof gems into their own group"
2023-04-04 10:07:02 +01:00
David Baumgold
e28abea77b
actions/cache@v3 for GitHub Actions
2023-04-04 10:34:56 +02:00
Carlo Cabrera
fdbb7f37c2
Update completions.
...
Generated with `brew generate-man-completions`
2023-04-04 16:21:05 +08:00
Carlo Cabrera
506f6c81a7
Support --dependents
flag on macOS
2023-04-04 16:20:37 +08:00
Mike McQuaid
573b99bd7f
Revert "Include prof gem group in sorbet workflow"
2023-04-04 09:03:39 +01:00
Mike McQuaid
7b336ed8cd
Revert "Split prof gems into their own group"
2023-04-04 08:49:27 +01:00
Mike McQuaid
ae8fc16031
Merge pull request #15134 from dduugg/sorbet-workflow
...
Include prof gem group in sorbet workflow
2023-04-04 08:41:08 +01:00
Markus Reiter
2222ac628e
Merge pull request #15129 from reitermarkus/livecheck-screensavers
...
Include screen savers in `:extract_plist` strategy.
2023-04-04 09:39:52 +02:00
Mike McQuaid
81477257ca
Merge pull request #15139 from dduugg/t-unsafe-cleanup
...
Remove useless T.unsafe wrappers
2023-04-04 08:37:36 +01:00
Carlo Cabrera
15061cec70
Update completions.
...
Generated with `brew generate-man-completions`
2023-04-04 14:54:49 +08:00
Carlo Cabrera
c125079d0f
determine-test-runners: allow usage on macOS without --dependents
2023-04-04 13:54:35 +08:00
Carlo Cabrera
3d03d243a4
determine-test-runners: test failure modes (again)
2023-04-04 13:25:44 +08:00
Carlo Cabrera
e191dbfb9e
Improve style
2023-04-04 13:20:03 +08:00
Carlo Cabrera
7ff2382d74
determine-test-runners: fix parallel tests
...
Since these tests run in parallel, we want to minimise our reliance on
environment variables. Also, we need to make sure that different
examples write to different paths.
2023-04-04 12:16:54 +08:00
Markus Reiter
e57143542a
Consider dictionary
stanzas in livechecks.
2023-04-04 05:06:58 +02:00
JBYoshi
3f8998a4fc
Reset extended attributes of the base directories.
2023-04-03 20:21:37 -05:00