4116 Commits

Author SHA1 Message Date
Rylan Polster
d5d7b6c3db
style: remove RSpec/MultipleDescribes violations
Co-authored-by: Nanda H Krishna <nanda.harishankar@gmail.com>
2021-02-01 20:30:51 -05:00
Rylan Polster
af40e072b0
style: remove RSpec/NamedSubject violations 2021-02-01 20:30:51 -05:00
Rylan Polster
3e00b3ea28
style: remove RSpec/ExampleLength violations 2021-02-01 20:30:51 -05:00
EricFromCanada
f39fb5d6b2 cask/config: new method for cask.config.explicit as string 2021-02-01 10:44:19 -05:00
Mike McQuaid
cdf8ff9052
Merge pull request #10266 from gromgit/prefix_non_installed
cmd/--prefix: add --installed flag
2021-02-01 09:05:28 +00:00
Mike McQuaid
b8d55e5a77
Merge pull request #10397 from MikeMcQuaid/deprecations-disables
Homebrew 3.0.0 deprecations/disables
2021-02-01 08:37:22 +00:00
Adrian Ho
28a8409b6e cmd/--prefix: add --installed flag
This changes the output for uninstalled formulae from Cellar prefix to empty string, so:
```sh
$ brew --prefix abcde python@3.9 tcl-tk
/usr/local/Cellar/abcde/2.9.3_1
/usr/local/opt/python@3.9
/usr/local/Cellar/tcl-tk/8.6.10
$ brew --prefix --installed abcde python@3.9 tcl-tk

/usr/local/opt/python@3.9

$
```
2021-01-31 16:09:43 +08:00
Mike McQuaid
e65e310fd0
Fix brew style 2021-01-29 20:56:59 +00:00
Mike McQuaid
d6957a3acb
Homebrew 3.0.0 deprecations/disables 2021-01-29 19:50:24 +00:00
Seeker
1ce8bd00fb named_args: print error if formula and cask found but one is unreadable 2021-01-28 15:21:23 -08:00
Seeker
89930157b5 named_args: raise rescued error if both formula/cask are unreadable 2021-01-28 15:21:23 -08:00
Michka Popoff
38ae6e0c0d style: re-enable sha256 checks for bottle blocks
Follow up PR to #10450
2021-01-28 20:35:31 +01:00
Mike McQuaid
4afebd2872
Fixup brew bottle (and tests) for #10447. 2021-01-28 13:19:41 +00:00
Michka Popoff
838cf2fc58
bottle_spec: run generate_sha256_line test on mac too 2021-01-28 13:19:40 +00:00
Mike McQuaid
902993afe4
dev-cmd/bottle_spec: add another integration test on macOS. 2021-01-28 13:19:40 +00:00
Michka Popoff
de2e309d50
cellars: write tag specific cellars
With #10186 now merged, the tag specific cellar information is being read by brew.
This PR (once merged) will start adding the cellar information for each tag instead
of having a single cellar line on the top of the bottle block.

Each new CI build in homebrew-core will slowly start migrating the cellar lines to
the right place. If keep-old is used, the old "all tag" cellar line is removed and
added to each tag.
2021-01-28 13:19:40 +00:00
Mike McQuaid
fc1c142ebd
software_spec: reverse tag/digest for new bottles.
This new format was agreed in #10377
2021-01-28 13:15:41 +00:00
Mike McQuaid
623e2d95af
Revert "cleanup_spec: inline path creation."
This reverts commit 3724c739f880945ec76a16ef8b9209c6440f0035.
2021-01-28 08:13:08 +00:00
Rylan Polster
5b2f8a5a73
Merge pull request #10431 from Rylan12/fish-completions
Generate fish completions automatically
2021-01-27 17:46:34 -05:00
Mike McQuaid
a83848d24f
Merge pull request #10439 from MikeMcQuaid/fix_retry
spec_helper: fix and improve retry logic.
2021-01-27 19:37:10 +00:00
Mike McQuaid
03c861b7d7
Merge pull request #10428 from SeekingMeaning/cask-reverse-migration
cask/audit: disallow new cask to have token in tap_migrations.json
2021-01-27 15:07:13 +00:00
Mike McQuaid
3724c739f8
cleanup_spec: inline path creation.
Let's see if this makes the test more reliable.
2021-01-27 15:06:06 +00:00
Mike McQuaid
da94957b01
tests: verbose tests with --verbose or --debug.
The `VERBOSE_TESTS` variable was from cask and never gets set (and
is unset by `bin/brew`). Replace it with `HOMEBREW_VERBOSE_TESTS` and
set it by `--verbose` or `--debug`.

While we're here, remove an unneeded `VERBOSE` delete (as it's already
done by `bin/brew`).
2021-01-27 15:04:13 +00:00
Mike McQuaid
f38707e92a
spec_helper: fix and improve retry logic.
- always retry each test at least once (confusingly this means a retry
  count of 2 rather than 1)
- always wait at least 1 second between retries
- set a default retry metadata for integration tests rather than
  overriding any specified values
- use `example.run` rather than `example.run_with_retry` for integration
  tests because, confusingly, this avoids having the retry count be
  half what it should be (because the attempts increases by one for
  each `run_with_retry` call)
- use 4 retries for integration tests with 2**attempts*retry_wait
  (retry wait now being 2) to actually have more retries than before
  this commit (but with exponential backoff)

This should generally improve test flakiness in CI but particularly
improve the cleanup test flake we've seen recently.
2021-01-27 12:43:30 +00:00
Mike McQuaid
10a5434ef1
Merge pull request #10429 from MikeMcQuaid/yamllint
Autoformat YAML files
2021-01-27 12:15:27 +00:00
Seeker
bd7a660328
Merge pull request #10422 from SeekingMeaning/named-args-unreadable-tests
named_args_spec: add tests for unreadable formulae/casks
2021-01-26 22:45:28 -08:00
EricFromCanada
6fc116318e fixes for grammar and wording 2021-01-26 16:19:47 -05:00
EricFromCanada
99ad3350ee use single quotes around stanza and parameter names 2021-01-26 16:19:47 -05:00
EricFromCanada
2ed324ebc0 use backticks around suggested input, flags, and binaries 2021-01-26 16:19:47 -05:00
EricFromCanada
cd3cb6928b indent suggested commands on subsequent line
and combine sequential puts calls
2021-01-26 15:36:44 -05:00
EricFromCanada
a427de5bee capitalization fixes
"curl" is the binary, while "cURL" is the umbrella project.
2021-01-26 15:36:44 -05:00
Seeker
c1d2aaf13a cask/audit: disallow new cask to have token in tap_migrations.json 2021-01-26 08:33:14 -08:00
Rylan Polster
541a981d37
completions: generate fish completions 2021-01-26 10:47:56 -05:00
Nanda H Krishna
5f5930255e
Merge pull request #10417 from nandahkrishna/bump-tests
dev-cmd/bump: increase test coverage
2021-01-26 18:58:43 +05:30
Mike McQuaid
92d107d666
Autoformat YAML files
Extracted the `.rubocop_todo.yml` change from #10397 so thought I'd do
this to all committed (non-vendor) YAML files.
2021-01-26 10:16:32 +00:00
Seeker
6e0bf05fb5 named_args_spec: add tests for unreadable formulae/casks 2021-01-25 18:46:33 -08:00
Rylan Polster
0c5edf4004
Cleanup description handling 2021-01-25 13:46:51 -05:00
Rylan Polster
6cf5d1aa17
completions: add tests 2021-01-25 13:46:51 -05:00
Seeker
a308c6da73
Merge pull request #10376 from SeekingMeaning/livecheck-multi-version
livecheck: split cask versions into sub-versions
2021-01-25 10:08:27 -08:00
Seeker
0a0f435a88
Merge pull request #10378 from SeekingMeaning/version-regexes
version: add new `Version::Parser` class
2021-01-25 09:24:42 -08:00
nandahkrishna
9c914106ed
dev-cmd/bump: increase test coverage 2021-01-25 17:12:43 +05:30
Mike McQuaid
95c6e92d9b
Merge pull request #10278 from zkokaja/add-cask-json-values
Add installed and outdated to cask json output
2021-01-25 10:04:25 +00:00
Mike McQuaid
97d56d122e
Merge pull request #10285 from nandahkrishna/refactor-utils-bump
Refactor `brew bump`
2021-01-25 09:59:48 +00:00
Mike McQuaid
d0e1c3dc5f
Merge pull request #10400 from issyl0/improve-brew-extract-args
dev-cmd/extract: Improve the usage instructions
2021-01-25 09:55:01 +00:00
Seeker
8d24fb1367 Output string instead of array for installed cask version 2021-01-24 18:27:23 -08:00
nandahkrishna
e2ddf9894a
Refactor brew bump 2021-01-24 19:10:46 +05:30
Rylan Polster
7a0471f4c9
cask/cmd: fix tests 2021-01-23 17:50:41 -05:00
Rylan Polster
2c83ea7339
Merge pull request #10370 from Rylan12/brew-release
Add brew release command
2021-01-23 15:35:53 -05:00
Rylan Polster
01e894e9c6
parser: create NumberOfNamedArgumentsError
And commit `brew man` changes
2021-01-23 15:26:21 -05:00
Rylan Polster
b7b624c9bf
parser: clarify errors for invalid number of args 2021-01-23 15:06:44 -05:00