4116 Commits

Author SHA1 Message Date
Michael Cho
a0261c4b39 cask uninstall script: allow tilde expansion to '$HOME' 2021-03-28 09:52:49 -07:00
Markus Reiter
a57813321b Fix BundleVersion comparison when one part is nil. 2021-03-28 04:15:59 +02:00
Kenneth Chew
9d6bfa5965
pathname: do not install empty metafiles 2021-03-27 13:34:50 -04:00
Rylan Polster
9a355b07c3
Merge pull request #10896 from Rylan12/cask-audit-display-changes
audit: limit non-failure cask output
2021-03-23 01:33:28 -04:00
Rylan Polster
665578438b
test/cask/cmd/audit: fix tests again 2021-03-23 01:16:21 -04:00
Rylan Polster
2d3aca706d
Merge pull request #10895 from Rylan12/fix-tap-custom-remote-handling
utils/github: handle non-standard tap remotes
2021-03-22 22:28:20 -04:00
Rylan Polster
0f9ca9dbbd
test/cask/cmd/audit: fix style 2021-03-22 22:26:22 -04:00
Rylan Polster
83ebc5ef7e
cask/audit: fix tests 2021-03-22 22:20:03 -04:00
Bo Anderson
ca33b3d425
Merge pull request #10887 from Bo98/dep-expand-caching
Implement caching for dependency expansion
2021-03-22 14:13:44 +00:00
Bo Anderson
25373a18cc
Merge pull request #10880 from Bo98/cli-stronger-types
Stricter handling of CLI args
2021-03-22 14:13:01 +00:00
nandahkrishna
15102a3234
livecheck/strategy/electron_builder: address changes from review
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
2021-03-22 12:52:43 +05:30
Tom Hu
ff7c05a285
Merge branch 'master' into codecov-action 2021-03-21 14:58:03 -04:00
Rylan Polster
4e61f61a20
utils/github: handle non-standard tap remotes 2021-03-21 12:35:45 -04:00
Bo Anderson
e49a338896
Implement caching for dependency expansion 2021-03-20 16:56:00 +00:00
nandahkrishna
f422b6cdc4
livecheck/strategy: add ElectronBuilder strategy 2021-03-20 15:23:09 +05:30
Bo Anderson
1b61d5a563
Merge pull request #10873 from Bo98/shell_commands_cop
Promote shell commands audit to global cop
2021-03-18 20:34:15 +00:00
Bo Anderson
8e98ce69f3
Stricter handling of CLI args 2021-03-18 16:41:57 +00:00
Bo Anderson
20ff68a425
Fix brew style. 2021-03-17 20:45:44 +00:00
Bo Anderson
9063945b3e
Promote shell commands audit to global cop 2021-03-17 20:45:41 +00:00
Bo Anderson
98b83064ec
Merge pull request #10871 from Bo98/cask_slash_audit
test/cask/audit_spec: add test for slashes in versions
2021-03-17 16:41:47 +00:00
Bo Anderson
a8522c6db6
test/cask/audit_spec: add test for slashes in versions 2021-03-17 14:25:50 +00:00
Nanda H Krishna
53f34af1c5
Merge pull request #10845 from nandahkrishna/fix-completions-zsh
completions: fix zsh autocompletion issues
2021-03-17 10:55:19 +05:30
Markus Reiter
1a4874dc62 Simplify package uninstallation. 2021-03-16 03:00:14 +01:00
Bo Anderson
acfe9d24d9
Merge pull request #10815 from Bo98/fi-more-perf
formula_installer: further reduce dependency calculations
2021-03-15 18:20:03 +00:00
Bo Anderson
fa8b80747a
test/formula_installer_spec: add tests for cyclic deps 2021-03-15 17:51:09 +00:00
nandahkrishna
0e97793f91
test/completions: modify tests for zsh completions 2021-03-14 01:39:14 +05:30
Cassidy Marble
267040e5df
bugfix: Add args and options to lazy url block 2021-03-12 10:26:59 -07:00
nandahkrishna
e64f2d1fd4
test/exceptions_spec: add test for TapFormulaOrCaskUnavailableError 2021-03-12 01:28:20 +05:30
Adrian Ho
548316ecc8 --prefix: shortlist only formulae 2021-03-11 17:32:35 +08:00
Mike McQuaid
61427d6682
Merge pull request #10770 from SeekingMeaning/unless_logical_operators
rubocops: use `Style/UnlessLogicalOperators`
2021-03-05 11:45:42 +00:00
Mike McQuaid
9964a4b0a9
Merge pull request #10777 from nandahkrishna/patches-rubocop-autocorrect
rubocops/patches: autocorrect some offenses
2021-03-05 11:45:14 +00:00
Bo Anderson
e1da637f9a
test/hardware/cpu_spec: add missing families 2021-03-04 23:50:35 +00:00
Mike McQuaid
e9419dbce7
test/cmd: test Bash logic. 2021-03-04 12:59:43 +00:00
Mike McQuaid
dc1fdc9f8d
Speedup brew --version.
Port `brew --version` to Bash to speed it up.

While we're here:
- remove (now) unused `Tap` Git methods
- use `--quiet` instead of `-q` to be more verbose

Benchmarks:
```
$ hyperfine --min-runs=3 --warmup=2 "git checkout origin/master; brew --version" "git checkout speedup_brew_version; brew --version"
Benchmark #1: git checkout origin/master; brew --version
  Time (mean ± σ):      2.083 s ±  0.004 s    [User: 396.8 ms, System: 597.2 ms]
  Range (min … max):    2.080 s …  2.088 s    3 runs

Benchmark #2: git checkout speedup_brew_version; brew --version
  Time (mean ± σ):     847.9 ms ±  35.2 ms    [User: 100.0 ms, System: 247.9 ms]
  Range (min … max):   824.1 ms … 888.3 ms    3 runs

Summary
  'git checkout speedup_brew_version; brew --version' ran
    2.46 ± 0.10 times faster than 'git checkout origin/master; brew --version'
```
2021-03-04 12:59:42 +00:00
nandahkrishna
d68452f232
rubocops/patches: autocorrect some offenses 2021-03-04 12:36:18 +05:30
Seeker
7e7274aaeb rubocops: use Style/UnlessLogicalOperators
Replaces `Style/UnlessMultipleConditions`
2021-03-03 01:39:11 -08:00
Bo Anderson
a5b12a33c2
utils/gems: use Gem API rather than ENV to set paths 2021-02-27 16:23:28 +00:00
Bo Anderson
6cd1e5e384
Avoid passing around a massive $LOAD_PATH.
Portable Ruby crashes if the $LOAD_PATH gets too big.
2021-02-26 18:23:48 +00:00
hyuraku
178ae750b9 utils/github: set default args to search_code 2021-02-26 21:31:30 +09:00
Mike McQuaid
545c568f52
Merge pull request #10693 from MikeMcQuaid/speedup_brew_prefix
Speedup `brew --prefix <formula>`
2021-02-26 10:47:51 +00:00
Bo Anderson
06381deef4
Merge pull request #10686 from Bo98/safe_fork-status
utils/fork: handle termsig in safe_fork
2021-02-26 04:25:54 +00:00
Mike McQuaid
ca47b47f77
Speedup brew --prefix <formula>
This case is _really_ slow even although it's something we encourage
people to run often and build systems often do. The `brew --prefix`
case is really fast because it's just in Bash so: let's pull the
`brew --prefix <formula>` case into Bash too.

This doesn't handle any edge-cases like `--installed` and the formula
detection is pretty simple.

Also, to make this behaviour consistent, never output `Cellar` paths
from the (Ruby) `brew --prefix`; we never want people relying on the
Cellar paths anyway, only output them if the formula wasn't installed
(where, arguably, using a Cellar path is even worse) and the speedup is
worth this deviation in behaviour.
2021-02-25 17:07:28 +00:00
Bo Anderson
f079373d8c
utils/fork: handle termsig in safe_fork 2021-02-25 13:42:44 +00:00
Shaun Jackman
bd75cfc4e0
Merge pull request #10677 from sjackman/sj/pr-upload
pr-upload: Upload bottles to Archive.org
2021-02-23 19:06:44 -08:00
Kenneth Chew
edead95768
utils/spdx: correctly detect non-deprecated licenses with plus 2021-02-23 16:28:24 -05:00
Shaun Jackman
0f2c47dbe3
Add test/archive_spec.rb 2021-02-22 18:07:39 -08:00
Issy Long
e143dfdad6
Merge pull request #10658 from issyl0/rubocop-enable-rspec-context-wording
rubocop: Enable RSpec/ContextWording cop & fix offenses
2021-02-23 00:14:02 +00:00
Issy Long
7a0effdf6f
Merge pull request #10659 from issyl0/fix-mismatched-test-descriptions
test/rubocops: Fix mismatched test descriptions
2021-02-23 00:13:58 +00:00
Issy Long
8dfaad9ac2
Merge pull request #10665 from issyl0/rubocop-enable-rspec-repeated-example-group-description
rubocop: Enable RSpec/RepeatedExampleGroupDescription cop & fix offenses
2021-02-23 00:13:54 +00:00
Issy Long
ead84825a6
test: Fix all RSpec/RepeatedExampleGroupDescription offenses 2021-02-21 14:06:24 +00:00