1417 Commits

Author SHA1 Message Date
Carlos Álvaro
aebf4c9100
Safe access to tap attributes
Prevent calling name tap attribute when the tap is nil

Co-Authored-By: Rylan Polster <rslpolster@gmail.com>
2021-02-08 13:20:41 +01:00
Carlos Álvaro
84d80cf0bf
Add tap to cask json output 2021-02-08 13:20:40 +01:00
Carlos Álvaro
4f5f3824c6
Add full_token to cask json output 2021-02-08 13:20:40 +01:00
nandahkrishna
d0200e8737
cask/config: fix explicit_s 2021-02-03 13:37:53 +05:30
Mike McQuaid
851bf9aab9
Merge pull request #10465 from vitorgalvao/no-desc-fonts
cask audit: do not require description for fonts
2021-02-02 16:35:26 +00:00
Vítor Galvão
e3d515105b cask audit: do not require description for fonts 2021-02-02 14:06:11 +00:00
EricFromCanada
f39fb5d6b2 cask/config: new method for cask.config.explicit as string 2021-02-01 10:44:19 -05:00
Mike McQuaid
861da37f55
Merge pull request #10456 from SeekingMeaning/cask-audit-format-url
cask/audit: underline URLs in audit errors
2021-02-01 09:05:53 +00:00
Mike McQuaid
b8d55e5a77
Merge pull request #10397 from MikeMcQuaid/deprecations-disables
Homebrew 3.0.0 deprecations/disables
2021-02-01 08:37:22 +00:00
Mike McQuaid
d6957a3acb
Homebrew 3.0.0 deprecations/disables 2021-01-29 19:50:24 +00:00
Seeker
571a13b99e cask/audit: underline URLs in audit errors 2021-01-28 16:17:40 -08:00
Seeker
00e5e1f9fc cask/audit: error if verified does not match, regardless of url 2021-01-28 15:27:00 -08:00
Mike McQuaid
03c861b7d7
Merge pull request #10428 from SeekingMeaning/cask-reverse-migration
cask/audit: disallow new cask to have token in tap_migrations.json
2021-01-27 15:07:13 +00:00
EricFromCanada
6fc116318e fixes for grammar and wording 2021-01-26 16:19:47 -05:00
EricFromCanada
99ad3350ee use single quotes around stanza and parameter names 2021-01-26 16:19:47 -05:00
EricFromCanada
2ed324ebc0 use backticks around suggested input, flags, and binaries 2021-01-26 16:19:47 -05:00
EricFromCanada
cd3cb6928b indent suggested commands on subsequent line
and combine sequential puts calls
2021-01-26 15:36:44 -05:00
EricFromCanada
a427de5bee capitalization fixes
"curl" is the binary, while "cURL" is the umbrella project.
2021-01-26 15:36:44 -05:00
EricFromCanada
c0a753edd3 pluralize "artifacts" 2021-01-26 15:36:43 -05:00
EricFromCanada
d0ad829e43 use arrow character for UI prompts 2021-01-26 15:36:43 -05:00
EricFromCanada
571179ff0e pass second argument to ohai when applicable 2021-01-26 15:36:43 -05:00
EricFromCanada
a6643b4adf fix odebug calls 2021-01-26 12:02:30 -05:00
Seeker
c1d2aaf13a cask/audit: disallow new cask to have token in tap_migrations.json 2021-01-26 08:33:14 -08:00
Seeker
acdb05dbcf
Merge pull request #10407 from SeekingMeaning/version-public-api
version: mark methods as public
2021-01-25 18:50:08 -08:00
Mike McQuaid
95c6e92d9b
Merge pull request #10278 from zkokaja/add-cask-json-values
Add installed and outdated to cask json output
2021-01-25 10:04:25 +00:00
Seeker
8d24fb1367 Output string instead of array for installed cask version 2021-01-24 18:27:23 -08:00
Seeker
7171b3a41d version: mark methods as public 2021-01-24 11:58:22 -08:00
Seeker
50cd836427
Merge pull request #10351 from SeekingMeaning/sig-braces
rubocop: require braces for Sorbet `sig`
2021-01-19 03:50:20 -08:00
Seeker
fbafaff4fe rubocop: require braces for Sorbet sig 2021-01-18 16:52:45 -08:00
Vítor Galvão
1ca68556e7 Cask: audit: Do not require appcast on GitHub releases 2021-01-17 00:48:33 +00:00
Markus Reiter
759fc12089
Merge pull request #10304 from reitermarkus/cask-config-keys
Ignore invalid keys when reading existing `Cask::Config`.
2021-01-13 11:31:57 +01:00
Markus Reiter
9922ad382f Ignore invalid keys when reading existing Cask::Config. 2021-01-13 08:30:50 +01:00
Markus Reiter
92b58666ef Improve audit for livecheck in casks. 2021-01-13 08:12:11 +01:00
Seeker
f476bcafcb upgrade: show formula caveats after casks have been updated 2021-01-11 11:43:11 -08:00
Zaid Kokaja
9cf3d5a32d Add installed and outdated to cask json output 2021-01-09 22:46:27 -05:00
Seeker
b9854bd4cf rubocops: add unless_multiple_conditions 2021-01-08 10:33:54 -08:00
Mike McQuaid
50ffa38213
Merge pull request #10247 from iMichka/sha256
checksum: simplify, use only sha256
2021-01-08 09:43:23 +00:00
Michka Popoff
5e91802470 checksum: simplify, use only sha256
We use only one sha type right now.

Needed for https://github.com/Homebrew/brew/pull/10186
2021-01-07 20:46:13 +01:00
Mike McQuaid
d8a5e467e8
audit: quieten down and make casks audit consistent with formulae.
The current casks audit is very noisy in the no-op case (i.e. no errors)
https://github.com/Homebrew/brew/pull/10234/checks?check_run_id=1655630568#step:15:7

This means when there are errors and you're querying all casks it's
pretty hard to quickly identify the problems.

This commit silences the `passing`, `warning` and header/summary output
when you're querying all casks (rather than a specific cask or tap).

This is more consistent with `brew audit` for formulae which is silent
unless there are audit failures.
2021-01-07 13:31:14 +00:00
Seeker
924d42e4cb cask: add DSL methods to RBI file 2021-01-05 09:11:31 -08:00
Markus Reiter
a01deaaf52 Handle running apps in application.<bundle_id>.<number>.<number> format. 2020-12-26 14:02:49 +01:00
Mike McQuaid
4135c0abca
Merge pull request #10083 from xu-cheng/cask-conflict-check-tap
cask/installer: do not install tap during conflict checking
2020-12-24 12:44:23 +00:00
Rylan Polster
cb8e9a695f
Merge pull request #10087 from Rylan12/migrate-shared-audit-exceptions
audit: migrate shared audits to taps
2020-12-23 16:36:42 -05:00
Cheng XU
72a346e6c8
cask/installer: do not install tap during conflict checking
If the tap of the conflicted cask is not installed, we should just skip it.
This matches the behavior of formula installation.

Without this, running `brew install dropbox` would result to install
the `homebrew/cask-versions` tap.

Fixes #9125.
2020-12-22 15:32:11 -08:00
Rylan Polster
ec4fe89a94 audit: migrate shared audits to taps 2020-12-21 14:45:02 -05:00
Markus Reiter
8b17017108 Improve error message for missing PKG source. 2020-12-21 15:54:32 +01:00
Markus Reiter
82c1e6fb0e Fix basename for extracting cask downloads. 2020-12-21 15:43:25 +01:00
Markus Reiter
8fa5a8e832
Don't suggest adding appcast if livecheck exists. 2020-12-19 19:34:24 -05:00
Mike McQuaid
74fb058c7e
More deprecations
More deprecations, disabling and removal for Homebrew 2.7.0.
2020-12-18 14:17:37 +00:00
Mike McQuaid
010ae37420
Merge pull request #9403 from MikeMcQuaid/deprecate-cask-requirements
Deprecate cask requirements.
2020-12-18 12:15:35 +00:00