28781 Commits

Author SHA1 Message Date
Mike McQuaid
b4aac9d4a0
Merge pull request #14950 from issyl0/sorbet-autogenerate-envconfig-rbi
sorbet: Autogenerate the RBI file for `Homebrew::EnvConfig`
2023-03-13 10:22:16 +00:00
Mike McQuaid
296c5088aa
Merge pull request #14935 from hyuraku/move-cask/cmd/uninstall
Move cask/cmd/uninstall
2023-03-13 10:19:41 +00:00
Markus Reiter
b8cb1d1a95
Simplify condition. 2023-03-13 02:40:03 +01:00
Markus Reiter
90665b074e
Simplify condition. 2023-03-13 02:38:03 +01:00
Issy Long
703b9b4f4d
Update Library/Homebrew/sorbet/custom_generators/env_config.rb 2023-03-13 00:11:12 +00:00
Markus Reiter
3b45ecdc70
Move to_s. 2023-03-13 00:59:08 +01:00
Markus Reiter
66d2ab220a
Fix code style. 2023-03-13 00:57:21 +01:00
Issy Long
c6ff9b59c0
sorbet: Delete unused nilable? method; regenerate RBIs; fix errors 2023-03-12 22:44:31 +00:00
Mike McQuaid
e6d541612a
Merge pull request #14928 from dduugg/unglobal-i18n
Remove i18n use
2023-03-12 21:11:22 +00:00
Issy Long
169ae0e155
Apply suggestions from code review
Co-authored-by: Markus Reiter <me@reitermark.us>
2023-03-12 17:32:21 +00:00
Markus Reiter
fcca056f4c
Check CUSTOM_IMPLEMENTATIONS for all variables. 2023-03-12 05:24:40 +01:00
hyuraku
da6f48dbd0
Merge branch 'master' into move-cask/cmd/uninstall 2023-03-12 11:49:06 +09:00
Douglas Eichelberger
731a02ee73 rm .brew_irb_history 2023-03-11 17:27:53 -08:00
Douglas Eichelberger
05d8d51a81 Remove i18n direct dependency 2023-03-11 17:27:53 -08:00
Douglas Eichelberger
826aca7217 Add tests 2023-03-11 17:27:53 -08:00
Douglas Eichelberger
8a57c37c33 Fix extend/array_spec 2023-03-11 17:27:53 -08:00
Douglas Eichelberger
13b6825c2d Fix invalid locale error 2023-03-11 17:27:53 -08:00
Douglas Eichelberger
999594dc07 Remove oxford comma from to_sentence default 2023-03-11 17:27:53 -08:00
Douglas Eichelberger
1943132cf6 Move i18n out of global 2023-03-11 17:27:53 -08:00
Issy Long
8e13a6e1f4
Merge pull request #14944 from issyl0/more-rubocop-naming-method-parameter-name
rubocop: Further trim `Naming/MethodParameterName` allowlist
2023-03-11 22:59:39 +00:00
hyuraku
08560e04ae remove cask/cmd/fetch_spec 2023-03-11 22:13:00 +09:00
hyuraku
413e8ac81e remove cask/cmd/fetch 2023-03-11 22:12:33 +09:00
hyuraku
e321edabbc remove options and comments 2023-03-11 21:15:24 +09:00
Mike McQuaid
921ad96b53
Merge pull request #14945 from issyl0/rubocop-rm-unnecessary-comment 2023-03-11 08:03:47 +00:00
Issy Long
8862c33b62
sorbet: Autogenerate the RBI file for Homebrew::EnvConfig
- I'm not as happy with this as I was with my work on `utils/tty.rb`,
  it feels a lot hackier and prone to breaking - especially the
  `T.nilable` "detection".
- However, it generates an RBI file that passes `brew typecheck`, so we
  can clean up some `hidden-definitions` entries, getting further
  towards fully typed.
2023-03-11 02:13:30 +00:00
Issy Long
b00203fa3c
rubocop: Remove comment about RSpec from Style/BlockDelimiters config
- We got rid of the RSpec-related excludes in PR 14920. I should have
  got rid of this comment too.
2023-03-11 00:41:58 +00:00
Issy Long
5f553f7c5a
rubocop: TODO for the Naming/MethodParameterName "pr" allowlist entry 2023-03-11 00:32:10 +00:00
Issy Long
0c86425d6a
rubocop: Drop "o" from Naming/MethodParameterName allowlist
- I couldn't figure out what this would stand for, so I asked on Slack
  if anyone had better ideas otherwise I'd go with "ostrich" or
  "octopus". Rylan suggested "option", which is very sensible.
2023-03-11 00:17:29 +00:00
Issy Long
60d93310af
rubocop: Drop "a" and "b" from Naming/MethodParameterName allowlist 2023-03-11 00:17:28 +00:00
Issy Long
e9d994622e
rubocop: Drop "f" from Naming/MethodParameterName allowlist
- This either stands for "file" but more often than not "formula".
2023-03-11 00:17:27 +00:00
Mike McQuaid
5631310653
Auto-update from the API less often
Instead of doing so literally whenever we query for a formula, Instead
do so only when we're in an auto-updateable command.

This better fits the existing behaviour while still updating when it's
most important to do so.
2023-03-10 17:53:15 +00:00
Mike McQuaid
0c1031f2fd
Merge pull request #14937 from dduugg/enable-typing
Enable typing in a few more files
2023-03-10 09:01:41 +00:00
Mike McQuaid
fad4414d7c
Merge pull request #14940 from apainintheneck/fix-irb-test
Cleanup irb history file in tests
2023-03-10 08:59:32 +00:00
Douglas Eichelberger
9446db7720 Typecheck some utils 2023-03-09 21:46:35 -08:00
Douglas Eichelberger
76671ef555 Typecheck ENV extensions 2023-03-09 20:51:01 -08:00
Douglas Eichelberger
0b04b99e68 brew typecheck --suggest-typed --update 2023-03-09 20:32:46 -08:00
Douglas Eichelberger
de90ddf07c Fix DescriptionCacheStore searching 2023-03-09 19:10:38 -08:00
apainintheneck
2baaafba92 Cleanup irb history file in tests
This was caused by the irb spec. Note that
$HOME is set during the test setup so will
always be correct.
2023-03-09 17:07:08 -08:00
Issy Long
188466d28e
rubocop: Drop "e" from Naming/MethodParameterName allowlist 2023-03-09 21:58:57 +00:00
Issy Long
f1ab720000
rubocop: Drop "c1" and "c2" from Naming/MethodParameterName allowlist 2023-03-09 21:54:37 +00:00
Douglas Eichelberger
02fd0422aa Enable typing in a few more files 2023-03-09 13:42:06 -08:00
hyuraku
8c1ce514b2 fix style 2023-03-09 22:34:46 +09:00
hyuraku
cd0686d75b move cask/cmd/uninstall_spec to cask/uninstall_spec 2023-03-09 22:33:45 +09:00
hyuraku
db328b59f2 move cask/cmd/uninstall to cask/uninstall 2023-03-09 22:33:29 +09:00
hyuraku
38a62b3a51 repair style 2023-03-09 20:55:33 +09:00
hyuraku
869c8effb5 remocve Cask::Upgrade::OPTIONS 2023-03-09 20:41:26 +09:00
hyuraku
2f870fa670 move cask/cmd/upgrade_spec to cask/upgrade 2023-03-09 20:41:22 +09:00
hyuraku
19f83ef67f move cask/cmd/upgrade to cask/upgrade 2023-03-09 20:40:20 +09:00
Dawid Dziurla
8824fc2c27
Merge pull request #14932 from Homebrew/skopeo-retry-backoff
github_packages: additional retry of skopeo copy with backoff
2023-03-09 10:47:22 +01:00
Mike McQuaid
4db1cbbfe0
Merge pull request #14930 from g0t4/cat_mention_brew_info_github
include `--cask` or `--formula` in `brew info --github` suggestion
2023-03-09 09:00:22 +00:00