28781 Commits

Author SHA1 Message Date
Carlo Cabrera
e7f15ae0ee
Merge pull request #14974 from ywwry66/install_info_from_path 2023-03-20 04:31:46 +08:00
Issy Long
f10b88ca85
caveats: Add a new line if there isn't one from previous conditions 2023-03-19 18:38:09 +00:00
Carlo Cabrera
e5b9e97b92
Use git merge-base to determine original_commit 2023-03-20 00:55:20 +08:00
Carlo Cabrera
c669f1d625
pr-pull: add --no-cherry-pick flag
Needed for Homebrew/homebrew-core#125556. Without this, `pr-pull`
attempts to cherry-pick commits from the PR branch onto the PR branch,
and then gets upset that nothing happened.

See https://github.com/Homebrew/homebrew-core/actions/runs/4461335852/jobs/7835095294#step:10:40
2023-03-19 23:44:44 +08:00
hyuraku
4271d41e51 remove new specs 2023-03-19 22:31:00 +09:00
hyuraku
dfee012f77 change cask spec to formula one 2023-03-19 19:14:46 +09:00
apainintheneck
d42e9b40d5 formulary: add test for loading service blocks from API 2023-03-19 00:09:16 -07:00
apainintheneck
501730df5d Add service serialization specs 2023-03-19 00:09:16 -07:00
apainintheneck
db8d488db4 service: add info to API json and load from api
As a part of serializing the hash, certain path
placeholders are used for the HOMEBREW_PREFIX and $HOME
directories. Beyond that certain elements need to be
turned back into strings like cron and sockets and symbols
need to be preserved as well.

The run command accepts either an arg or kwargs so it
has to be treated specially here.
2023-03-19 00:09:10 -07:00
Mike McQuaid
26914e2469
Merge pull request #15006 from dduugg/brew-types
Enable typing in Library/Homebrew/brew.rb
2023-03-19 00:33:42 -04:00
apainintheneck
3aae28aa0d cask: remove old prefix placeholder
This was just a temporary workaround while we
waited for the API to regenerate the JSON content.
2023-03-18 16:42:44 -07:00
Douglas Eichelberger
aea54a9ceb Generate RBI for StackProf 2023-03-18 16:29:12 -07:00
Douglas Eichelberger
6415ae6739 Add stackprof to Gemfile 2023-03-18 16:23:08 -07:00
Douglas Eichelberger
4f2ff3819b Clean up rbi files 2023-03-18 16:03:25 -07:00
Douglas Eichelberger
abfe29040b Enable types in Library/Homebrew/cask 2023-03-18 16:03:10 -07:00
Ruiyang Wu
4ac228cc41 Use install-info from texinfo if not available in /usr/bin
`install-info` is not shipped with macOS Ventura and some Linux
distros. This commit uses `install-info` from `texinfo` formula if it
is not available in `/usr/bin`.

See: https://github.com/Homebrew/discussions/discussions/4306
2023-03-18 18:24:03 -04:00
Douglas Eichelberger
2969cdb5c1 Enable types in brew.rb 2023-03-18 13:55:19 -07:00
Douglas Eichelberger
6dc20d253a Add stackprof@0.2.23.rbi 2023-03-18 13:46:13 -07:00
Nanda H Krishna
30845593cc
utils/github/actions: remove Error class 2023-03-18 16:38:08 -04:00
Nanda H Krishna
27bb6ff1dd
Merge pull request #15002 from nandahkrishna/actions-multiline-envfile
utils/github/actions: add `format_multiline_string` method
2023-03-18 15:31:12 -04:00
Issy Long
13fe1bb4b4
formula_auditor: Better keg_only reason message
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
2023-03-18 15:27:35 +00:00
Issy Long
865e99c611
test/cask: Rename 'expected_json_ventura' since it's >= Ventura
- Let's actually show in the fixtures JSON filename what's changed
  between the two.
2023-03-18 15:16:23 +00:00
Nanda H Krishna
b792a5fd20
utils/github/actions: add format_multiline_string method 2023-03-18 10:49:16 -04:00
Issy Long
bda88ce96e
formula_auditor: Having HOMEBREW_PREFIX in keg_only reasons is bad
- Fixes issue 14996.
- The API JSON is generated with a `/usr/local` Homebrew prefix, but
  frequently now users have `/opt/homebrew` as their prefix. Since
  formulae `keg_only` reasons are generated by the API, this can lead
  to the confusing messaging that follows:

```
socket_vmnet is keg-only, which means it was not symlinked into /opt/homebrew,
because /usr/local/bin is often writable by a non-admin user.
```

- With this change, that formula as it is now will fail `brew audit`,
  prompting to remove the prefix reference.

```
❯ HOMEBREW_NO_INSTALL_FROM_API=1 brew audit --strict socket_vmnet
socket_vmnet:
  * `keg_only` reason should not include `HOMEBREW_PREFIX` as it provides confusing output.
Error: 1 problem in 1 formula detected
```
2023-03-18 14:46:13 +00:00
Issy Long
6b4b923b44
test/cask: Fix "System Settings" caveats for (non-)Ventura OSes
- "System Preferences" was updated to be "System Settings" in macOS
  Ventura. This naming was updated in our caveats generator in PR 14997.
- This test was failing for me locally (on Ventura) because it was
  hardcoded to expect `System Preferences => Security & Privacy`, but
  getting `System Settings => Privacy & Security`.
- This is not the most important thing in the world, we can probably
  live with the failing test, but I thought I'd try to fix it anyway.
2023-03-18 13:19:20 +00:00
Issy Long
7bb57612b7
caveats: Remove extra blank line between keg_only and other caveats
- This was pointed out by Carlo in
  https://github.com/Homebrew/brew/issues/14925#issuecomment-1473303922,
  it annoyed me the moment I saw it too, and it was a very quick fix.
- The caveats items are joined by "\n" before being displayed, so the
  extra `\n` here when generating the `keg_only_text` meant that there
  were two blank lines which looked weird. This `keg_only_text` method
  is only used here so it doesn't affect anywhere else we show the
  `keg_only` message, if there are any other places.
2023-03-18 12:21:10 +00:00
Mike McQuaid
b3684e55a7
Merge pull request #14997 from ZhongRuoyu/ventura-system-settings
Update path to system settings on Ventura
2023-03-17 15:45:05 -04:00
Mike McQuaid
647d86f3e4
Merge pull request #14998 from stevenlele/locale
Fix locale parsing
2023-03-17 15:36:22 -04:00
Mike McQuaid
b8743d337b
Merge pull request #14991 from issyl0/cask-url-audit-pass-referrer
cask/audit: Pass a URL's `referer` through to cURL
2023-03-17 15:33:38 -04:00
stevenlele
c9e44a0395 Update test 2023-03-17 20:35:17 +08:00
stevenlele
ca22b67dd2 Fix locale parsing 2023-03-17 20:15:42 +08:00
Ruoyu Zhong
a0ba487a30
Fix brew tests since CI is running on Monterey
Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2023-03-17 19:53:15 +08:00
Ruoyu Zhong
e9ce4a5a4e
Update path to system settings on Ventura
"System Preferences" has been renamed to "System Settings" on Ventura.
Privacy and security settings have moved, too. This commit makes sure
these changes are reflected. (Some adjustments were already made in
#14092.)

Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2023-03-17 19:24:07 +08:00
Issy Long
0701ea42fa
cask/audit: Pass a URL's referer through to cURL
- Some casks have URL arguments like "referer" (spelled wrong, that's
  intentional in the HTTP spec).
- The audit for one such cask, `iThoughtsX`, was failing because the
  "referer" wasn't getting passed through to cURL so the access would
  404.

----

Before:

```
❯ brew audit --cask --online --appcast --signing 'ithoughtsx'
[...]
audit for ithoughtsx: failed
 - The binary URL https://cdn.toketaware.com?download=iThoughtsX.zip is not reachable (HTTP status code 404)
 - Version '9.2.0' differs from '9.3.0' retrieved by livecheck.
 - Version '9.2.0' differs from '9.3.0' retrieved by livecheck.
Error: 2 problems in 1 cask detected
```

After:

```
❯ brew audit --cask --online --appcast --signing 'ithoughtsx'
[...]
audit for ithoughtsx: failed
 - Version '9.2.0' differs from '9.3.0' retrieved by livecheck.
 - Version '9.2.0' differs from '9.3.0' retrieved by livecheck.
Error: 1 problem in 1 cask detected
```
2023-03-16 23:28:50 +00:00
Mike McQuaid
650f516c5b
Merge pull request #14992 from dduugg/enable-typing
Fix GitHub.last_commit and enable more typing
2023-03-16 17:12:48 -04:00
BrewTestBot
f2eb7d58b8
Update RBI files for rack.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-03-16 19:13:12 +00:00
BrewTestBot
2681bebd4a
brew vendor-gems: commit updates. 2023-03-16 19:07:04 +00:00
dependabot[bot]
4b6d76faf8
build(deps): bump rack from 3.0.6.1 to 3.0.7 in /Library/Homebrew
Bumps [rack](https://github.com/rack/rack) from 3.0.6.1 to 3.0.7.
- [Release notes](https://github.com/rack/rack/releases)
- [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md)
- [Commits](https://github.com/rack/rack/compare/v3.0.6.1...v3.0.7)

---
updated-dependencies:
- dependency-name: rack
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-03-16 19:02:48 +00:00
Mike McQuaid
d0c5202106
Merge pull request #14984 from alebcay/utils-gzip-not-private
utils/gzip: don't mark API as private
2023-03-16 10:23:08 -04:00
Caleb Xu
8d51f806c5
utils/gzip: don't mark API as private 2023-03-16 00:00:54 -04:00
Douglas Eichelberger
b8aa619f2f brew style --fix 2023-03-15 18:21:41 -07:00
Issy Long
1e64a658d4
Revert "Update GitHubPackages for new Tab implementation" 2023-03-15 23:12:37 +00:00
Douglas Eichelberger
96ae878808
Merge pull request #14983 from dduugg/gh-packages-compat
Update GitHubPackages for new Tab implementation
2023-03-15 15:15:27 -07:00
Mike McQuaid
ff33d34ae1
Merge pull request #14975 from issyl0/count-issues-handle-hidden-stats
dev-cmd/contributions: Don't fall over if a user's profile is private
2023-03-15 17:52:04 -04:00
Issy Long
a9e31274fc
dev-cmd/contributions: Output why we default to 0 reviews on a validation error 2023-03-15 21:31:41 +00:00
Douglas Eichelberger
827fc87cde Enable more typing 2023-03-15 14:29:15 -07:00
BrewTestBot
089f79eddb
sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
2023-03-15 21:28:48 +00:00
Mike McQuaid
6fd54eba5f
Merge pull request #14985 from dduugg/no-compat
Remove compatibility layer
2023-03-15 13:48:00 -04:00
Mike McQuaid
62edc3258a
cmd/postgresql-upgrade-database: import from homebrew/core.
This is useful for non-contributor users but won't be installed if they
don't have homebrew/core tapped (the default).

Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2023-03-15 13:16:40 -04:00
Mike McQuaid
b61bf2591b
cmd/{rb,nod}env-sync: add new commands.
Add these commands to ease use of Homebrew's bottles with `rbenv` and
`nodenv`.

I've had a lot of people request this over the years and it's worked
well for me for a long time.

I could see people extending these to support other languages or version
managers so perhaps we want a more generic name.

Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2023-03-15 13:13:09 -04:00