1222 Commits

Author SHA1 Message Date
Baffour Adu Boampong
9e88b44bd7 Merge fixes 2020-07-26 22:39:46 +00:00
Issy Long
fdbb2ac16a
Merge pull request #7985 from vidusheeamoli/utils-inreplace-to-true
sorbet: set utils/inreplace.rb to true
2020-07-26 10:37:30 +01:00
vidusheeamoli
fd382d2ecd srb: set utils/inreplace.rb to true and refactor
- Sorbet gives preference to class methods over methods defined in
  included modules, hence Sorbet was unavailable to resolve the
definition of the gsub! method.
- The gsub! method in StringInreplaceExtension conflicts with the definition in String.
- This PR refactors the call to the gsub! method so that a custom object
  is exposed instead of a string.
2020-07-26 12:43:31 +05:30
Markus Reiter
b50eea6849
Merge pull request #8068 from reitermarkus/cli-parser
Refactor usages of global `Homebrew.args`.
2020-07-25 21:01:39 +02:00
Markus Reiter
6c050492ee Pass args to Analytics instead of using global args. 2020-07-25 03:57:43 +02:00
Dustin Rodrigues
c4d11374c8 curl: alert on permanent redirect 2020-07-24 10:50:13 -04:00
Dustin Rodrigues
ef540d0365 curl: ensure final_url is populated with the final URL requested 2020-07-22 17:41:55 -04:00
Dawid Dziurla
b4efb2c258
notability: fix variable names 2020-07-22 14:21:06 +02:00
Sean Molenaar
dab18076fa
audit: error on archived repos 2020-07-22 11:57:50 +02:00
Baffour Adu Boampong
9ec93f78d6
Merge branch 'master' into mlh-outdated-packages 2020-07-21 17:49:24 +00:00
Dawid Dziurla
d579725f7c
Merge pull request #7954 from dawidd6/workflow-dispatch-event
utils/github: add workflow_dispatch_event method
2020-07-16 19:08:12 +02:00
vidusheeamoli
9799f32506 sorbet: set utils/user.rb to true 2020-07-11 01:04:22 +05:30
Dawid Dziurla
de4f25c13d
utils/github: add workflow_dispatch_event method 2020-07-09 12:50:09 +02:00
Issy Long
2c3b2f68cd
Revert #7933 ("sorbet: set utils/git.rb to true")
- My refactoring of #7933 went wrong in that the tests passed for `brew
  extract` and my manual testing, but both forgot about third-party taps
  exist, so that functionality broke as follows (courtesy of Misty).

  Before:

  ```
  # Git.last_revision_commit_of_files("/usr/local/Homebrew", ["LICENSE.txt", "README.md"])
  => ["ac0665d", ["README.md"]]
  ```

  After:

  ```
  # Git.last_revision_commit_of_files("/usr/local/Homebrew", ["LICENSE.txt", "README.md"])
  => [nil, []]
  ```

- While we think about how to do splats in Sorbet, revert this so
  that users are able to `brew extract` from third party taps again.

- A TODO for later in a separate PR is to write a test for `brew
  extract` that tests the behaviour of third-party taps.

---

- Reverted this manually because the GitHub UI couldn't do it.
- Arguably I didn't need to remove the RBI file, but it's easier to have
  everything gone for now and then revert this revert in future once we
  have a strategy for dealing with splats in Sorbet than have
  inconsistency.
2020-07-09 08:18:38 +01:00
vidusheeamoli
76a2e69990 sorbet: set utils/git.rb to true
(cherry picked from commit 44a04adb1de430066af73a65766eb644c0f5bd41)
2020-07-08 22:34:26 +05:30
Baffour Adu Boampong
53643870a3 refactor github module duplicate 2020-07-07 21:14:30 +00:00
Baffour Adu Boampong
af117fab25 Merge branch 'mlh-outdated-packages' of github.com:MLH-Fellowship/brew into mlh-outdated-packages 2020-07-07 20:44:03 +00:00
Baffour Adu Boampong
7633991621 Remove exception handling in formula version vheck 2020-07-07 13:43:31 +00:00
Mike McQuaid
15a2abd9df
style: re-enable shellcheck.
Ensure that `shellcheck` is run by `brew style` again and fix the
various failures.
2020-07-07 11:53:55 +01:00
Baffour Adu Boampong
b253100bcd Remove args parameter from github module, check duplicate pr method 2020-07-07 01:19:07 +00:00
Elizabeth Tackett
0402f0c95e Merge branch 'mlh-outdated-packages' of github.com:MLH-Fellowship/brew into mlh-outdated-packages 2020-07-06 09:12:53 -05:00
Elizabeth Tackett
af37b76689 syntactical updates 2020-07-06 09:08:41 -05:00
Baffour Adu Boampong
154f597d7a Merge remote-tracking branch 'origin' into mlh-outdated-packages 2020-07-06 13:53:21 +00:00
Baffour Adu Boampong
5194d74c21 Remove versions module 2020-07-06 12:45:28 +00:00
Baffour Adu Boampong
a176c5c00f Change verbose message in repology response parser to debug meesage 2020-07-06 04:07:06 +00:00
Baffour Adu Boampong
d7149d1f76 Fix merge conflicts 2020-07-06 03:32:18 +00:00
Jonathan Chang
b909fdd30f github: refactor GraphQL APIs 2020-07-05 15:31:29 +10:00
Baffour Adu Boampong
15da87704c Add error handling to formula current version finding function 2020-07-03 01:51:38 +00:00
Elizabeth Tackett
aa4134a830 updated/feedback fixes 2020-07-02 13:34:47 -05:00
Bo Anderson
997ba42a4b utils/curl: support disabling partial downloads in curl_download 2020-07-02 18:58:32 +01:00
Baffour Adu Boampong
ea2f4087fe Add livecheck version and duplicate pr check 2020-07-02 17:06:39 +00:00
Elizabeth Tackett
0c8f977665 update the way popen_read responses are parsed 2020-07-01 11:44:56 -05:00
Elizabeth Tackett
e8f78878cb replace capture2e with Utils.popen 2020-07-01 10:58:13 -05:00
Elizabeth Tackett
98f0d63c95 remove unnecessary /scripts; feedback fixes 2020-07-01 09:55:31 -05:00
Jonathan Chang
d16e699ed7 github: need read-only email scope to see emails 2020-07-01 22:25:53 +10:00
Jonathan Chang
b57290b23f
Merge pull request #7844 from jonchang/signoff-approving-reviews
pr-pull: add commit message trailers for pull requests with approved reviews
2020-07-01 19:18:27 +10:00
Baffour Adu Boampong
3265650279 Update Repology parser and bump command 2020-07-01 02:50:21 +00:00
Baffour Adu Boampong
59a4d1dd68 fixed Merge conflicts 2020-06-30 17:06:21 +00:00
Elizabeth Tackett
63eb5214e4 remove unnecessary method argument 2020-06-30 11:30:47 -05:00
Elizabeth Tackett
64ebecf0c1 replace HTTP with curl 2020-06-30 11:23:34 -05:00
Elizabeth Tackett
81864cf231 guard against infinite loop when querying repology 2020-06-30 10:48:04 -05:00
Elizabeth Tackett
a398307612 brew style fixes 2020-06-30 10:36:00 -05:00
lionellloh
57e7e7d60e small fix: res -> response 2020-06-30 23:23:19 +08:00
Elizabeth Tackett
3cae15945b style fixes 2020-06-30 10:23:18 -05:00
Elizabeth Tackett
344391d1a9 replace puts invocations with ohai 2020-06-30 10:11:56 -05:00
Elizabeth Tackett
2cfb1c39ff Merge branch 'mlh-outdated-packages' of github.com:MLH-Fellowship/brew into mlh-outdated-packages 2020-06-30 09:59:56 -05:00
Elizabeth Tackett
3fb675626e parse application source code into modules. replace HTTP query for brew version info 2020-06-30 09:57:51 -05:00
Elizabeth Tackett
d557ca80bc fix brew style violations 2020-06-30 09:57:51 -05:00
Elizabeth Tackett
bc5cdc2aac typo 2020-06-30 09:57:51 -05:00
Elizabeth Tackett
13d4f24727 focus util module on repology API call 2020-06-30 09:57:51 -05:00