brew style fixes

This commit is contained in:
Elizabeth Tackett 2020-06-30 10:36:00 -05:00
parent 3cae15945b
commit a398307612
3 changed files with 16 additions and 15 deletions

View File

@ -9,7 +9,7 @@ module Livecheck
"brew",
"livecheck",
formula_name,
"--quiet"
"--quiet",
]
response = Open3.capture2e(*command_args)
@ -17,12 +17,12 @@ module Livecheck
end
def parse_livecheck_response(response)
output = response.first.gsub(" ", "").split(/:|==>|\n/)
output = response.first.delete(" ").split(/:|==>|\n/)
# eg: ["burp", "2.2.18", "2.2.18"]
package_name, brew_version, latest_version = output
{"name" => package_name, "current_brew_version" => brew_version,
"livecheck_latest_version" => latest_version}
{ "name" => package_name, "current_brew_version" => brew_version,
"livecheck_latest_version" => latest_version }
end
end

View File

@ -28,7 +28,7 @@ module RepologyParser
last_package_index = outdated_packages.size - 1
response_size = outdated_packages.size
while response_size > 1 do
while response_size > 1
page_no += 1
ohai "\n- Paginating repology api page: #{page_no}"
@ -45,27 +45,28 @@ module RepologyParser
outdated_packages
end
def validate__repology_packages(outdated_repology_packages, brew_formulas)
def validate__repology_packages(outdated_repology_packages)
ohai "\n- Verify Outdated Repology Packages as Homebrew Formulae"
packages = {}
outdated_repology_packages.each do |name, repositories|
outdated_repology_packages.each do |_name, repositories|
# identify homebrew repo
repology_homebrew_repo = repositories.select do
|repo| repo["repo"] == "homebrew"
end.first
repology_homebrew_repo = repositories.find do |repo|
repo["repo"] == "homebrew"
end
next if repology_homebrew_repo.empty?
latest_version = nil
#identify latest version amongst repology repos
# identify latest version amongst repology repos
repositories.each do |repo|
latest_version = repo["version"] if repo["status"] == "newest"
end
packages[repology_homebrew_repo['srcname']] = {
'repology_latest_version' => latest_version,
packages[repology_homebrew_repo["srcname"]] = {
"repology_latest_version" => latest_version,
}
end
# hash of hashes {'openclonk' => {repology_latest_version => 7.0}, ..}

View File

@ -22,8 +22,8 @@ module Versions
parse_formula_bump_response(response)
end
def parse_formula_bump_response(response)
response, status = formula_bump_response
def parse_formula_bump_response(formula_bump_response)
response, _status = formula_bump_response
response
end