2034 Commits

Author SHA1 Message Date
Markus Reiter
c7267b123d Merge pull request #1502 from reitermarkus/load-metadata-cask-file
Load cask file in `.metadata` directory directly.
2016-11-21 10:43:15 +01:00
Markus Reiter
cc7541cbc4 Merge pull request #1535 from umireon/cask-pkg-choice
Cask: Add the choices option to pkg stanza
2016-11-21 10:25:30 +01:00
Kaito Udagawa
df635c8259 cask: compact the code 2016-11-21 04:13:29 +09:00
Kaito Udagawa
0c22cc45e6 cask: Call Tempfile#close(true) with the choices file to ensure it deleted 2016-11-20 14:23:55 +09:00
Kaito Udagawa
2807202103 cask: use Tempfile and some style fixes 2016-11-19 14:52:38 +09:00
Markus Reiter
1834457272 Remove kernel extensions specified in uninstall :kext. 2016-11-19 01:53:26 +01:00
Markus Reiter
bd9755fd78 Load cask file in .metadata directory directly. 2016-11-18 23:02:58 +01:00
Kaito Udagawa
f4a3bc100b cask: add the choices option to pkg stanza
installer command accepts -applyChoiceChangesXML option to change
customize options on the GUI installer from the commandline.
(`man installer` for more detailed information)

The introduced option `choice` enables the choice changes to be supplied
via pkg stanza without tricks in preflight code.
2016-11-19 04:41:21 +09:00
Markus Reiter
4db1317f38 Move all remaining fixtures to test/support/fixtures. 2016-11-16 23:52:38 +01:00
Josh Hagins
c20d50fc7a hbc/cmd/style: bump rubocop-cask to 0.10.6 2016-11-15 11:57:10 -05:00
Markus Reiter
3a01fbadcd Merge pull request #1362 from reitermarkus/rubocop
Update RuboCop to 0.45.0.
2016-11-14 16:50:24 +01:00
Markus Reiter
ff96f7ec26 Fix detection of self-extracting .exe files. 2016-11-14 15:30:48 +01:00
Markus Reiter
c648518f35 Rename single line block parameters to acc/elem. 2016-11-13 23:36:04 +01:00
Markus Reiter
e9391481a8 Update RuboCop to 0.45.0. 2016-11-13 23:18:08 +01:00
Markus Reiter
84b2276fd8 Use guard clauses. 2016-11-13 23:00:47 +01:00
Kaito Udagawa
1a4eb14b16 cask-tests: fix cask-tests always fail on the test failure
`brew cask-tests` collected the test results in an improper way so that it reports a false success in certain situations.
Specially, the session under BrewTestBot always reports success regardless of the test status.
With this update, the exit code of `brew cask-tests` is 1 when the test fails, and then CI preperly works.
2016-11-12 11:48:12 +09:00
Markus Reiter
8241bbb15b Merge pull request #1475 from reitermarkus/fix-locations
Fix `Hbc::Locations` in tests.
2016-11-11 13:43:38 +01:00
Markus Reiter
8fea516dcd Merge pull request #1481 from reitermarkus/sudo-askpass
Support `SUDO_ASKPASS` environment variable in `brew cask`.
2016-11-11 10:56:05 +01:00
Markus Reiter
0b8a8cce28 Support SUDO_ASKPASS environment variable. 2016-11-11 00:30:05 +01:00
Mike McQuaid
c2815fbb9a Merge pull request #1381 from adzenith/patch-1
`brew doctor` recommends using cask to upgrade XQuartz
2016-11-10 21:05:21 +00:00
Markus Reiter
a0f9963391 Disallow running brew cask as root. 2016-11-10 15:01:29 +01:00
Markus Reiter
8dd8273d5e Remove unnecessary Hbc::Locations aliases. 2016-11-10 14:48:53 +01:00
Markus Reiter
0f673cc27f Ensure Hbc.caskroom in tests does not use legacy_caskroom. 2016-11-10 14:48:14 +01:00
Nikolaus Wittenstein
969ac3a9c6 brew doctor recommends using cask to upgrade XQuartz
Also changes exceptions.rb to use Formatter.url
2016-11-09 22:21:21 -05:00
Kaito Udagawa
ad1fa738ef cask-test: fix reinstall a non installed Cask
Trying to uninstall a non installed Cask made this test fail.
This commit remove that and thus this test passes.
Note that every Cask is uninstalled after each test case.
2016-11-10 08:04:11 +09:00
Dorian
702d07917e Update the CaskAlreadyInstalledError with new reinstall command
e.g. this changes:

```
To re-install google-chrome, run:
  brew cask uninstall --force google-chrome && brew cask install google-chrome
```

To:

```
To re-install google-chrome, run:
  brew cask reinstall google-chrome
```
2016-11-09 15:08:12 +01:00
Mandar Gokhale
0e15ffff62 Correct a few typos
...and update man pages where applicable
2016-11-03 12:09:44 +00:00
Markus Reiter
f863d61374 Move vendor/bundle up one level to HOMEBREW_LIBRARY_PATH. 2016-10-29 18:28:07 +02:00
Josh Hagins
2605521ca9 Merge pull request #1361 from jawshooah/cask/refactor-auditor
hbc/auditor: refactor and fix bug
2016-10-29 11:40:39 -04:00
buo
6a406763f3 Open incomplete download in append mode
Open the incomplete download in append mode instead of write mode.
Opening in write mode truncates the existing file, so curl keeps
restarting downloads instead of resuming the incomplete downloads.
2016-10-25 16:46:59 +09:00
Markus Reiter
e6bce5ec27 Merge pull request #1342 from reitermarkus/fixtures
Move cask's fixtures to `test/fixtures`.
2016-10-24 22:09:45 +02:00
Josh Hagins
3f3fa4d0f7 Merge pull request #1334 from jawshooah/cask/fix-tap-regex
hbc/qualified_token: simplify token parsing
2016-10-24 10:38:02 -04:00
Markus Reiter
31ec04704a Move cask fixtures to test/fixtures/cask. 2016-10-24 15:52:41 +02:00
Josh Hagins
b2870c2480 hbc/qualified_token: use regex captures instead of String#split 2016-10-24 09:50:33 -04:00
Josh Hagins
4ed51d8240 hbc/auditor: refactor and fix bug
Use instance methods to DRY things up, and fix a bug discovered in
caskroom/homebrew-cask#26067 where Casks with language blocks would
always fail audit.
2016-10-24 04:27:21 -04:00
Josh Hagins
b481ed73a0 Merge pull request #1252 from niw/fix_cask_command_changes_entire_directory_ownership
FIX: cask changes /usr/local ownership recursively
2016-10-24 01:21:08 -04:00
Josh Hagins
606a762344 Merge pull request #1248 from Git-Jiro/add_reinstall_cmd_to_cask
add cask reinstall command
2016-10-24 01:11:48 -04:00
Josh Hagins
44f1354d63 hbc/qualified_token: simplify token parsing
- Stop supporting archaic "user-repo/token" syntax
- Move regex for parsing tapped Cask token to tap_constants
2016-10-23 21:48:11 -04:00
Josh Hagins
512a0c950e Merge pull request #1355 from reitermarkus/fix-depends-on-test
Fix locally failing `depends_on` test.
2016-10-23 21:42:48 -04:00
Josh Hagins
5d1412aba1 Merge pull request #1357 from reitermarkus/refactor-accessibility-test
Refactor accessibility test.
2016-10-23 21:41:35 -04:00
Josh Hagins
fcaa042736 Merge pull request #1358 from reitermarkus/refactor-audit-test
Refactor Audit test.
2016-10-23 21:40:54 -04:00
Josh Hagins
b59eade6c5 Merge pull request #1359 from reitermarkus/refactor-dsl-test
Refactor DSL test.
2016-10-23 21:40:06 -04:00
Josh Hagins
49155cce4d Merge pull request #1360 from reitermarkus/refactor-installer-test
Refactor Installer test.
2016-10-23 21:38:39 -04:00
Markus Reiter
4a9b48e9a6 Refactor Installer test. 2016-10-24 00:13:48 +02:00
Markus Reiter
7395c049dd Refactor Audit test. 2016-10-23 23:52:42 +02:00
Markus Reiter
bbc601c3fd Refactor DSL test. 2016-10-23 23:52:14 +02:00
Markus Reiter
b8ec62bf25 Refactor accessibility test. 2016-10-23 23:45:10 +02:00
Markus Reiter
1bcaad6f3f Update Gemfile dependencies. 2016-10-23 23:22:39 +02:00
Markus Reiter
c7a535de22 Refactor Hbc::UrlChecker test. 2016-10-23 22:58:01 +02:00
Markus Reiter
7cae29d3d7 Fix locally failing depends_on test. 2016-10-23 21:22:38 +02:00