Christian Moritz
466fe9841a
language/node: npm pack ignore prepublish scripts
...
This tells npm pack to don't run prepublish scripts at all.
I think this is the best default because:
* most modules don't have a prepublish script at all and aren't affected
by this change
* most prepublish scripts are calling devDeps, which would fail in our
case, because (dev)Deps aren't installed at npm pack time until #2820
gets resolved
* we favor npm registry tarball for formula downloads, which are already
prepublished, so we would in the best case needlessly run prepublish
a second time and in the worst case it would fail (because a clean
step is required before running prepublish a second time in a row)
* This change does the right thing for >99% of all the packages and
would only affect packages with prepublish scripts downloaded from a
non-npm registry tarball (like github tarballs) and with a prepublish
script wich does no't require any devDep (unlike for cross platform)
2017-06-29 20:29:25 +02:00
Christian Moritz
fe39dbb78c
language/node: log verbose npm pack output
...
This makes npm pack to log verbose debug output to the console to
simplify debugging npm pack failures.
Refs: https://github.com/Homebrew/brew/pull/2820#discussion_r123890729
Prevously Utils.popen_read swallowed all debug output.
2017-06-29 20:29:25 +02:00
Christian Moritz
495520a1f9
language/node: make packname detection more robust
...
This fixes some edge cases where verbose output from a prepublish script
could break our npm pack package name detection code by only using the
last line of the output printed by npm itself containing the desired
package name.
2017-06-29 20:29:25 +02:00
Christian Moritz
02113e2714
language/node: build native addons from source
...
By telling node-pre-gyp and prebuild to don't pull prebuild binaries and
instead build them from source. This still may not work for some custom
third party scripts for pulling prebuild binaries.
2017-06-29 20:29:25 +02:00
Christian Moritz
7d8124f339
language/node: set npm loglevel to max -ddd
...
to match the loglevel used in npm_debug.log (previous --verbose loglevel
would match -dd)
2017-06-29 20:29:25 +02:00
ilovezfs
1503c9fcb2
Merge pull request #2838 from ilovezfs/allow-formula-name-in-description
...
formula_desc_cop: allow formula name in desc
2017-06-29 09:19:49 -07:00
ilovezfs
7013f9dee3
formula_desc_cop: allow formula name in desc
...
except at the very beginning, as the audit originally intended.
See https://github.com/Homebrew/legacy-homebrew/pull/45493 .
2017-06-29 08:14:58 -07:00
Mike McQuaid
76ed7898d0
rubocop: bump PerceivedComplexity max.
2017-06-29 10:31:38 +01:00
Mike McQuaid
0f9f8fad13
Merge pull request #2828 from ed-flanagan/pretoken
...
Add PreToken composite
2017-06-29 10:09:31 +01:00
Ed Flanagan ed@flanagan.xyz
700b5e2738
Add PreToken composite
2017-06-27 03:17:23 -07:00
Mike McQuaid
4fb60d8988
docs.brew.sh: Tweak meta tags.
2017-06-27 08:07:25 +01:00
ilovezfs
13576111e0
Merge pull request #2822 from ilovezfs/software_spec-recursive-reqs
...
software_spec: define recursive deps and reqs
2017-06-25 08:43:24 -07:00
Mike McQuaid
3ce667f3b9
Merge pull request #2823 from MikeMcQuaid/test-simplify-minitest
...
test: simplify minitest inclusion.
2017-06-25 13:30:47 +01:00
Mike McQuaid
c45cca8e36
test: simplify minitest inclusion.
...
The previous version seems needlessly complicated given we only support
a single Ruby version. It was also blowing up on Bundler 1.15.X.
2017-06-25 13:04:36 +01:00
ilovezfs
cbf89e50bb
software_spec: define recursive deps and reqs
2017-06-25 03:38:21 -07:00
Mike McQuaid
943c69f6a6
Merge pull request #2814 from mansimarkaur/java
...
[WIP] Added tests for language/java
2017-06-25 09:18:36 +01:00
Mike McQuaid
f4cdd7a051
Merge pull request #2790 from GauthamGoli/audit_legacy_patches_rubocop
...
audit: Port audit_legacy_patches method to rubocop and add tests
2017-06-25 08:54:59 +01:00
mansimarkaur
fac708da7a
changes test names for class methods
2017-06-25 06:27:53 +05:30
mansimarkaur
1df9a475a8
Set java environment var to test overriding
2017-06-25 06:04:09 +05:30
Mike McQuaid
73d81bb96d
Merge pull request #2777 from mansimarkaur/inc_test_cov
...
Added tests for language/node.rb
2017-06-24 22:30:47 +01:00
Mike McQuaid
5f8a86c178
Merge pull request #2816 from MikeMcQuaid/test-needs-link
...
test: require non-keg-only formulae to be linked.
2017-06-24 13:30:21 +01:00
Mike McQuaid
1956c0a01c
Merge pull request #2817 from MikeMcQuaid/no-fossies-url
...
audit: don't use Fossies as a primary URL.
2017-06-24 13:29:42 +01:00
Gautham Goli
2e82754776
audit: Port audit_legacy_patches method to rubocop and add tests
2017-06-24 17:06:26 +05:30
mansimarkaur
67c48360fa
Improved code quality
2017-06-24 02:34:10 +05:30
mansimarkaur
66d5baf3fe
Removed extra space from include clause
2017-06-24 02:18:52 +05:30
Mike McQuaid
b9e3daac70
audit: don't use Fossies as a primary URL.
...
As requested in:
https://github.com/Homebrew/homebrew-core/issues/14486#issuecomment-307753234
2017-06-23 19:34:25 +01:00
Mike McQuaid
7d5cce569d
test: require non-keg-only formulae to be linked.
...
This can be overridden with `--force`.
As mentioned in:
https://github.com/Homebrew/homebrew-core/pull/14525#issuecomment-307838164
2017-06-23 17:42:09 +01:00
Mike McQuaid
f4f1f1a610
Merge pull request #2815 from ilovezfs/runtime-requirements
...
formula_installer: make unsatisifed recursive build reqs non-fatal for bottles
2017-06-23 17:34:34 +01:00
ilovezfs
301a6dc1d9
formula_installer: runtime reqs of build deps are build reqs
...
so don't consider their absence fatal if we're pouring a bottle.
2017-06-23 08:44:56 -07:00
mansimarkaur
690e841fca
Added tests for language/java
2017-06-23 06:26:23 +05:30
mansimarkaur
bfd19f9170
Stubbed nil:NilClass
2017-06-23 03:40:03 +05:30
mansimarkaur
5fed1f5cbe
Attempt to fix tests
2017-06-23 03:40:03 +05:30
mansimarkaur
69840e2a2f
Avoided the prepend_path not existing method error
2017-06-23 03:40:03 +05:30
mansimarkaur
f225eaf4d9
Added test for non existent node formula and existent npmrc
2017-06-23 03:40:03 +05:30
mansimarkaur
f8f239686d
Added rescue FormulaUnavailableError to setup_npm_environment
2017-06-23 03:40:03 +05:30
mansimarkaur
837ffa209c
stubbed the node formula
2017-06-23 03:40:03 +05:30
mansimarkaur
2cb678a6d5
Improved test quality
2017-06-23 03:40:03 +05:30
mansimarkaur
cf5db0e0df
Fixed style errors
2017-06-23 03:40:03 +05:30
mansimarkaur
7cd5d143c3
Added tests for language/node.rb
2017-06-23 03:40:03 +05:30
Mike McQuaid
8a5f12076b
Merge pull request #2809 from wang-boyu/master
...
diagnostic: Update whitelisted dylib used by Symantec
2017-06-22 09:28:51 +01:00
Wang Boyu
89d2cc00da
diagnostic: Update whitelisted dylib used by Symantec (again)
2017-06-22 16:00:54 +08:00
Wang Boyu
803c5c3afe
diagnostic: Update whitelisted dylib used by Symantec
2017-06-22 10:02:35 +08:00
Mike McQuaid
44c85c4683
Merge pull request #2801 from apjanke/formula-cop-uniform-_body_node-param
...
rubocops: refactor to use consistent _body_node parameter name
2017-06-21 08:08:49 +01:00
Markus Reiter
17b2694b1d
Merge pull request #2806 from reitermarkus/apfs
...
🔨 Fix sorting on APFS.
2017-06-20 20:32:37 +02:00
Markus Reiter
96f8452e17
Merge pull request #2793 from reitermarkus/trash
...
Add support for `uninstall/zap :trash`.
2017-06-20 16:30:09 +02:00
Markus Reiter
b2daed584d
Add support for uninstall/zap :trash.
2017-06-20 15:53:33 +02:00
Markus Reiter
fc739bf82e
Add trash util.
2017-06-20 15:53:33 +02:00
Markus Reiter
19cf6dcb3f
🔨 Fix sorting on APFS.
2017-06-20 15:44:54 +02:00
Mike McQuaid
80ce43dff1
Merge pull request #2776 from GauthamGoli/audit_checksum_rubocop_fix
...
audit: Fix audit_checksum method's rubocop and add more tests
2017-06-20 14:27:51 +01:00
Mike McQuaid
a1e5077adf
Merge pull request #2805 from woodruffw/harmless-dylibs
...
linkage_checker: Add harmless dylibs check.
2017-06-20 09:33:06 +01:00