admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
19,257 Commits 15 Branches 471 Tags
Commit Graph

19257 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Markus Reiter
40a0b8b10a Fix missing command method. 2019-10-15 17:39:15 +02:00
Markus Reiter
f762033a57 Move condition to nested if statement. 2019-10-14 11:28:30 +02:00
Markus Reiter
9a857ccf9b
Merge pull request #6596 from reitermarkus/dmg 
Fix `Dmg` detection.
 2019-10-14 11:28:20 +02:00
Markus Reiter
cc234d1948 Fix Dmg detection. 2019-10-14 10:44:52 +02:00
Issy Long
d0c3885f31
Merge pull request #6592 from issyl0/bump-rubocop-target-ruby-version 
Bump Rubocop's `TargetRubyVersion` to 2.6 and fix all offenses
 2019-10-14 09:39:21 +01:00
Mike McQuaid
cbf458ea9c
Lint/ElseAlignment: ignore some bugged autocorrections. 2019-10-14 09:03:02 +01:00
Mike McQuaid
f1702e5139
Merge pull request #6591 from amyspark/fix-depth-upgrade-check 
upgrade: reject formulae checked in earlier levels
2.1.14 		2019-10-14 08:44:10 +01:00
Issy Long
1f6168fe8a
Change regexp.match?(string) to string.match?(regexp) everywhere 
- Only try to call `.match?` on strings that aren't nil.
 2019-10-13 23:22:51 +01:00
Markus Reiter
eac74ec6e6
Merge pull request #6594 from reitermarkus/tar-dmg 
Fix `Dmg` being detected as `Tar`.
 2019-10-13 22:10:45 +02:00
Markus Reiter
67d51ef0e1 Fix Dmg being detected as Tar. 2019-10-13 17:19:02 +02:00
Issy Long
18e684fad7
Stringify dev-cmd/audit text variables when used in Regexp matching 
- To have the audit commands continue to work, and the tests passing
  (the previous error was [1]), everywhere we're trying to
  `.match?(text)`, instead do `.match?(text.to_s)`.

[1] 5) Homebrew::FormulaAuditor#audit_file __END__ but no DATA
    Failure/Error: fa.audit_file

    TypeError:
      no implicit conversion of Homebrew::FormulaText into String
    # ./dev-cmd/audit.rb:267:in `match?'
    # ./dev-cmd/audit.rb:267:in `audit_file'
    # ./test/dev-cmd/audit_spec.rb:137:in `block (3 levels) in <module:Homebrew>'
 2019-10-13 16:04:38 +01:00
Issy Long
fed1bbe029
Disable Metrics/LineLength for long URL lines in patches_spec.rb 
- The final two `brew style` offenses were for Metrics/LineLength where
  parsing the GitHub diff URL as a regex took 119/118 lines.
- This disables the cop for each of those long, problematic lines, and
  re-enables them straight afterwards, else they'd apply to the whole file
  from the first occurrence onwards, which we probably don't want?
- I wondered about increasing the LineLength limit to 119 or 120, but
  it appears to have been set for a justifiable reason in 80d75bc0d8.
 2019-10-13 16:04:37 +01:00
Issy Long
3570cb6e77
Auto-fix Style/NegatedUnless offenses 2019-10-13 16:04:36 +01:00
Issy Long
37fee928b5
Auto-fix Style/NegatedIf offenses 2019-10-13 16:04:35 +01:00
Issy Long
b87782ef7d
Auto-fix Style/UnpackFirst offenses 2019-10-13 16:04:34 +01:00
Issy Long
7193229b42
Auto-fix Layout/CommentIndentation offenses 2019-10-13 16:04:33 +01:00
Issy Long
489ba3f462
Auto-fix Layout/ClosingHeredocIndentation offenses 2019-10-13 16:04:32 +01:00
Issy Long
00adbbe98f
Auto-fix Layout/IndentHeredoc offenses 2019-10-13 16:04:31 +01:00
Issy Long
e5e28fbd69
Auto-fix more Layout/IndentationWidth offenses 
- These didn't appear in the first pass as the other offense fixes caused them.
 2019-10-13 16:04:30 +01:00
Issy Long
69d84ebfd9
Auto-fix Lint/ErbNewArguments offenses 2019-10-13 16:04:29 +01:00
Issy Long
245c61017f
Auto-fix Layout/ElseAlignment offenses 2019-10-13 16:04:28 +01:00
Issy Long
341ea60807
Auto-fix Style/RedundantBegin offenses 
- This also required auto-fixes for Layout/EmptyLinesAroundBlockBody and
  Layout/InconsistentIndentation once the auto-fixer had got rid of the
  "redundant begin"s.
 2019-10-13 16:04:27 +01:00
Issy Long
b78028b9c2
Auto-fix Performance/RegexpMatch offenses 2019-10-13 16:04:26 +01:00
Issy Long
6d7ef5c94d
Bump the Rubocop TargetRubyVersion parameter now we're using 2.6.3 
- This was set to 2.3 because Homebrew was running Ruby 2.3.7. Since
  https://github.com/Homebrew/brew/pull/6556, we're running 2.6.3. With
  this change, Rubocop will check against modern Ruby syntax.
 2019-10-13 10:00:18 +01:00
L. E. Segovia
024007f9e2
upgrade: address @MikeMcQuaid's comments 2019-10-12 22:06:08 +00:00
Mike McQuaid
16d477c696
Merge pull request #6523 from petdance/patch-1 
bash completion example should not call brew if brew doesn't exist
 2019-10-12 21:09:32 +01:00
Mike McQuaid
966e7ab363
Merge pull request #6581 from ytqh/remove-unsupported-option-in-xattr 
remove /usr/bin/xattr unsupported -s option in macOS 10.15
 2019-10-12 16:59:09 +01:00
Mike McQuaid
b438aa4d35
Merge pull request #6585 from BlueGone/search-migrated-cask-uneeded-warning 
Remove uneeded warning when searching for a cask migrated from formula
 2019-10-12 16:55:15 +01:00
L. E. Segovia
f4707a8041
upgrade: reject formulae checked in earlier levels 2019-10-12 15:53:21 +00:00
Thomas Plaçais
e616a23a0b
Remove uneeded warning message when searching for a cask that was migrated from a formula 2019-10-11 22:44:52 +01:00
Andy Lester
953a1bf20b Add quotes around the brew invocation 2019-10-11 08:51:43 -05:00
ytqh
24ef7fa5c8 remove xattr unsupported option in macOS 10.15 2019-10-11 21:18:53 +08:00
Mike McQuaid
70f232ada5
Merge pull request #6537 from tomjonandy/docs/cask-tap 
Docs: Add cask instructions to tap docs
 2019-10-11 09:30:45 +01:00
Mike McQuaid
9e56a8625d
Merge pull request #6531 from jpninanjohn/master 
Show correct message when invalid arguments are passed to brew
 2019-10-11 09:30:12 +01:00
Mike McQuaid
0d068341fc
Merge pull request #6467 from EricFromCanada/uses_from_macos-json 
Expose `uses_from_macos` list in formula API
 2019-10-11 09:28:01 +01:00
Mike McQuaid
dc9fe597f2
Merge pull request #6580 from middagj/feature/fix-frozen-string 
Fix frozen string bug
 2019-10-11 09:24:25 +01:00
Mike McQuaid
0e3ab6e6f2
exceptions: tweak build flags error message. 2019-10-11 09:02:41 +01:00
Jacob Middag
c6cb20a768
Fix frozen string bug 2019-10-11 09:34:43 +02:00
Mike McQuaid
a1a0569f75
Merge pull request #6578 from dawidd6/audit-uses-from-macos 
audit: replace depends_on with uses_from_macos
 2019-10-10 19:20:17 +01:00
Dawid Dziurla
86feb5a9de
audit: replace depends_on with uses_from_macos 2019-10-10 17:59:32 +02:00
Mike McQuaid
85e4013989
Merge pull request #6556 from Homebrew/ruby-2.6 
Ruby 2.6
 2019-10-10 16:37:36 +01:00
Mike McQuaid
209d12b89f
vendor-install: remove ARM bottles until built. 2019-10-10 16:17:06 +01:00
Mike McQuaid
2d51b8189b
test: disable some tests on Linux portable ruby. 2019-10-10 16:17:06 +01:00
Mike McQuaid
e3ee64a5fd
Ruby 2.6.3 brew tests fixes 2019-10-10 16:17:06 +01:00
Mike McQuaid
a36f00ae8b
Ruby 2.6 (and remove backports) gems 2019-10-10 16:17:05 +01:00
Mike McQuaid
e9aba2efb6
Require and provide portable Ruby 2.6.3. 2019-10-10 15:53:16 +01:00
Mike McQuaid
e3cf9592d1
Merge pull request #6577 from Homebrew/revert-6569-portable-ruby 
Revert "Do not run patchelf on portable-ruby [Linux]"
 2019-10-10 15:53:09 +01:00
Mike McQuaid
a7bfb80786
Revert "Do not run patchelf on portable-ruby [Linux]" 2019-10-10 15:16:30 +01:00
Mike McQuaid
33f38553a6
Merge pull request #6575 from MikeMcQuaid/brew-tap-docs 
How-to-Create-and-Maintain-a-Tap: note `brew tap-new`.
 2019-10-10 11:52:40 +01:00
Mike McQuaid
75d3bff267
Merge pull request #6574 from XD-DENG/patch-1 
Fix minor typo in How-to-Create-and-Maintain-a-Tap
 2019-10-10 11:52:28 +01:00