11682 Commits

Author SHA1 Message Date
Mike McQuaid
3e0d54d8b9 Merge pull request #1527 from alyssais/installed_dependencies
keg: update installed dependency resolution
2017-01-01 18:26:04 +00:00
Alyssa Ross
e1d7d44e5a tests: optlink fake kegs in uninstall test 2017-01-01 14:27:24 +00:00
Alyssa Ross
e4856143a6 keg: check installed dependencies iff optlinked 2017-01-01 14:27:24 +00:00
Alyssa Ross
94ead55772 keg: keg_only kegs can have installed dependents 2017-01-01 14:26:28 +00:00
Alyssa Ross
05b85a7bef keg: update installed dependency resolution
Closes #1525. (See there for a motivation for this change.)
2017-01-01 14:26:28 +00:00
Mike McQuaid
81b40f6564 Merge pull request #1761 from MikeMcQuaid/superenv-fix-stub
ENV/super: fix set_cpu_flags stub.
2016-12-31 23:11:28 +00:00
Mike McQuaid
9105ccece3 rubocop_todo: autogenerate update. 2016-12-31 22:44:15 +00:00
Mike McQuaid
f0fbcf5022 ENV/super: fix set_cpu_flags stub.
It should accept arguments.

Fixes https://github.com/Homebrew/homebrew-core/issues/8362
2016-12-31 22:44:05 +00:00
Mike McQuaid
ad593cf42c Merge pull request #1757 from alyssais/moved_formula
keg: handle dependencies of moved/renamed formulae
2016-12-31 18:39:55 +00:00
Markus Reiter
4b5489e172 Merge pull request #1759 from reitermarkus/bsexec
Remove `:bsexec` parameter from `SystemCommand`.
2016-12-31 19:19:21 +01:00
Alyssa Ross
524d9ce8f3 keg: test dep fallback with unknown formulae 2016-12-31 17:53:06 +00:00
Alyssa Ross
8b30abe060 keg: handle dependencies of moved/renamed formulae
In #1497 I switched from Keg#to_formula for comparing kegs to formulae
to comparing the name and tap in the keg's tab to the name and tap of
the formula.

However, this fails to match if the name and tap of the formula have
changed since the keg was installed, so it's clearly better to use
Keg#to_formula where possible, and fall back to the information in the
tab when #to_formula can't be used.
2016-12-31 17:53:06 +00:00
Mike McQuaid
9fa95d7218 Merge pull request #1758 from MikeMcQuaid/no-duplicate-formulae
formula, ARGV: don't output duplicate formulae.
2016-12-31 17:36:33 +00:00
Mike McQuaid
33fbf3f32d Merge pull request #1750 from alyssais/fallback_dependencies
keg: fall back for dependencies of buggy tabs
2016-12-31 17:34:55 +00:00
Mike McQuaid
1c9651f04f Merge pull request #1756 from alyssais/nil_dependents
keg: don't return nil dependencies
2016-12-31 17:34:17 +00:00
Mike McQuaid
d85a83c9dc Merge pull request #1752 from alyssais/uninstalling_dependencies
keg: fix fallback dependencies with multiple kegs
2016-12-31 17:33:08 +00:00
Mike McQuaid
82f4413964 formula, ARGV: don't output duplicate formulae.
If you specify a formula more than once or it exists in the Cellar with
an alias name and the main name (e.g. `qt` and `qt5`) you can see the
same formula showing up more than once. Instead, resolve these output
lists of formulae such that they are unique based on their `name`. This
doesn't use `full_name` as it's `name` that's use for the `Cellar`.
2016-12-31 17:03:29 +00:00
Markus Reiter
ed892243cd Remove :bsexec parameter from SystemCommand. 2016-12-31 18:02:42 +01:00
Alyssa Ross
fb920668c8 keg: don't return nil dependencies
This is a proper fix to the problem addressed by #1510.

The problem arises when f_kegs is nil, which can happen if the name and
tap used to install a keg don't match the name and tap currently
associated with its formula (i.e. if it's been renamed or moved).
2016-12-31 14:16:38 +00:00
Alyssa Ross
49310667b4 Revert "uninstall: remove nil requireds/dependents"
This reverts commit d7e72899e6f24dca5e02a734d5a4e64e39fc680e.
2016-12-31 12:23:53 +00:00
Alyssa Ross
b0a38c06bf docs: improve Keg.find_some_installed_dependencies
See https://github.com/Homebrew/brew/pull/1752#discussion_r94257147
2016-12-30 22:22:13 +00:00
Mike McQuaid
760a4601aa Merge pull request #1754 from MikeMcQuaid/audit-fix-uncommitted-version-scheme
formula_versions: handle uncommitted formulae.
2016-12-30 22:08:34 +00:00
Mike McQuaid
b1e27d689d Merge pull request #1701 from MikeMcQuaid/deprecate-std-superenv-stuff
ENV: deprecate old methods.
2016-12-30 20:43:27 +00:00
Mike McQuaid
9e2a8248a6 Merge pull request #1725 from MikeMcQuaid/curl-homepage-reliablity
audit: improve reliability of homepage audit.
2016-12-30 20:42:18 +00:00
Alyssa Ross
d998a3fcce tab: remove #reliable_runtime_dependencies?
See https://github.com/Homebrew/brew/pull/1750#discussion_r94243825 for
discussion.

Removes Tab#reliable_runtime_dependencies? in favour of returning nil
from Tab#runtime_dependencies if the list is unreliable.

Because Homebrew 1.1.6 hasn't been tagged yet, tabs created in tests
aren't created with a homebrew_version that marks the
runtime_dependencies in the Tab as reliable, so there are some tests
that fail. To work around this, I've had to add a line to some tests
that explicitly overrides the homebrew_version in the Tab. This is
really ugly though, so they should be removed as soon as possible after
1.1.6 is released.
2016-12-30 20:34:14 +00:00
Mike McQuaid
e50102d91e ENV: deprecate old methods.
These should have been deprecated long ago but we didn’t really have
the necessary framework to do so.
2016-12-30 20:20:13 +00:00
Mike McQuaid
b3c6334d3c audit: use new curl_args form.
This will use Curl’s default user agent to reduce homepage errors and
provides a function that can be used for other audits to perform
similar tests on URLs.
2016-12-30 20:17:34 +00:00
Mike McQuaid
c29a458dc1 Merge pull request #1751 from alyssais/uninstall_message
uninstall: a couple of dependency error/warning message improvements
2016-12-30 18:51:43 +00:00
Mike McQuaid
35ae78f43d formula_versions: handle uncommitted formulae.
Otherwise an uncommitted formula can trigger an invalid `brew audit`
result.

Fixes #1731.
2016-12-30 18:43:50 +00:00
Alyssa Ross
01e1f7d49e keg: fix fallback dependencies with multiple kegs
Fixes #1524.
2016-12-30 18:41:14 +00:00
Alyssa Ross
4322c1c562 tests: explain Homebrew version checking in tabs 2016-12-30 18:19:26 +00:00
Alyssa Ross
c41d1d8148 tab: remove #homebrew_tag
This method isn't used any more
2016-12-30 18:16:49 +00:00
Alyssa Ross
ce454bd141 tab: parse full Homebrew version string
It didn't occur to me that this would work, but it does! Magic.
2016-12-30 18:15:35 +00:00
Alyssa Ross
bbf53ad4ab uninstall: don't comma-seperate kegs in example
The example command given in the dependency errors/warnings previously
comma-seperated the kegs, which was incorrect syntax. This fixes that.
2016-12-30 17:45:37 +00:00
Alyssa Ross
ea3a41e213 uninstall: better example in dependency warning
Previously, this only included a subset of all the kegs the user was
trying to uninstall. With this change, all named formulae/kegs will be
included in the example command.
2016-12-30 17:44:18 +00:00
Markus Reiter
e2689a697c Merge pull request #1690 from reitermarkus/brew-cask-update
Deprecate `brew cask update`.
2016-12-30 18:00:11 +01:00
Mike McQuaid
c087c530ae Merge pull request #1749 from MikeMcQuaid/optional-check-recursive-dependencies
formula_installer: optional deps version check.
2016-12-30 16:37:28 +00:00
Alyssa Ross
e5db7927c9 keg: fall back for dependencies of buggy tabs
Fixes #1554.
2016-12-30 16:16:53 +00:00
Alyssa Ross
bdbc19c614 tab: implement #reliable_runtime_dependencies? 2016-12-30 16:16:28 +00:00
Alyssa Ross
a69997cab0 tests: include homebrew version in receipt fixture 2016-12-30 16:15:04 +00:00
Mike McQuaid
340000ce87 Merge pull request #1746 from MikeMcQuaid/always-filter-flags-deps
cc: always filter flags on deps.
2016-12-30 15:51:38 +00:00
Markus Reiter
c31f959ec1 Hide update from brew cask help. 2016-12-30 16:46:27 +01:00
Markus Reiter
cea1d18f45 Do not require compat/hbc/cli/update when —no-compat is specified. 2016-12-30 16:13:09 +01:00
Mike McQuaid
7f75b02133 formula_installer: optional deps version check.
Require `HOMEBREW_CHECK_RECURSIVE_VERSION_DEPENDENCIES` to be specified
(which will be by `brew test-bot`) to avoid this being inflicted on
end-users unnecessarily.
2016-12-30 14:36:53 +00:00
Mike McQuaid
e4497a2b42 cc: always filter flags on deps.
This has been tested by `brew test-bot` since March and there’s been no
issues so let’s turn it on by default.
2016-12-30 14:31:05 +00:00
Markus Reiter
ddaf17396e Remove brew cask update from ZSH completions. 2016-12-30 14:01:43 +01:00
Markus Reiter
b11f38659a Add warning to brew cask help. 2016-12-30 14:01:43 +01:00
Markus Reiter
1745997a30 Remove brew cask update from manpage. 2016-12-30 14:01:43 +01:00
Markus Reiter
a1154e9fab Deprecate brew cask update. 2016-12-30 14:01:43 +01:00
Markus Reiter
0f8cb4ba27 Add option to disable methods on specific date. 2016-12-30 14:01:43 +01:00