16625 Commits

Author SHA1 Message Date
Mike McQuaid
3b91c5f1ae
Merge pull request #4797 from MikeMcQuaid/rubocop-tweaks
.rubocop: tweak rules.
2018-09-02 21:13:23 +01:00
Mike McQuaid
bfb2d53f98
Merge pull request #4798 from Homebrew/revert-4771-rubocop-path
Revert "Add `$LOAD_PATH` for RuboCop cops."
2018-09-02 21:12:00 +01:00
Mike McQuaid
0aa9dce03c
Revert "Add $LOAD_PATH for RuboCop cops." 2018-09-02 20:49:25 +01:00
Mike McQuaid
80d75bc0d8
Homebrew/.rubocop: tweak rules.
Adjust the rules based on the current codebase. Remove various enable,
disables and default values that are unnecessary. Add more comments
explaining why. Make minor changes needed to enable a few more rules.
2018-09-02 20:15:09 +01:00
Mike McQuaid
0dc2c72693
Merge pull request #4795 from MikeMcQuaid/tests-leaks-prompt
tests: handle file leaks and SVN test prompt.
2018-09-02 18:31:44 +01:00
Mike McQuaid
662c1fab56
Merge pull request #4784 from MikeMcQuaid/line-length
Improve Homebrew/brew line length.
2018-09-02 16:35:24 +01:00
Mike McQuaid
bcb1ec5499
Improve Homebrew/brew line length.
Use 124 max line length everywhere. Also, reduce tap max line length to
189 as Homebrew/homebrew-core has that as a maximum now. In future
Homebrew/homebrew-core will also be reduced to 124 maximum line length.
2018-09-02 16:15:09 +01:00
Mike McQuaid
ec9e45a8f0
tests: handle file leaks and SVN test prompt.
- Ignore files that are generated by `brew tests`
- Make the SVN tests work without prompting for GitHub's SSL certificate
2018-09-02 13:43:58 +01:00
Mike McQuaid
5869842e7e
Merge pull request #4794 from MikeMcQuaid/tests-home
tests: set HOME.
2018-09-02 13:17:22 +01:00
Mike McQuaid
c46cecf277
tests: set HOME.
This is the only way to override the user's Git configuration which can
break tests when e.g. `gpg` cannot be found but signing is requested.
2018-09-02 12:56:31 +01:00
Mike McQuaid
794fe5d21d
Merge pull request #4778 from DomT4/gocache_follow_up
cleanup: fix go_cache cleanup
2018-09-02 10:16:37 +01:00
Dominyk Tiller
9102c120bb
cleanup: fix go_cache cleanup 2018-09-02 04:27:22 +01:00
Markus Reiter
449c3ffac3
Merge pull request #4791 from reitermarkus/fix-apache-mirror-download-strategy
Fix `CurlApacheMirrorDownloadStrategy` URL resolution.
2018-09-02 03:57:01 +02:00
Markus Reiter
e377bdb6fe Fix CurlApacheMirrorDownloadStrategy URL resolution. 2018-09-02 03:30:37 +02:00
Markus Reiter
93430e6ae2
Merge pull request #4789 from reitermarkus/avoid-network-call
Avoid network call in `#initialize`.
2018-09-01 16:47:20 +02:00
Markus Reiter
b54682f709 Avoid network call in #initialize. 2018-09-01 16:20:10 +02:00
Markus Reiter
f66ce9ce5d
Merge pull request #4788 from reitermarkus/no-cache-no-migration
Skip migration if cache is empty or doesn’t exist.
2018-09-01 16:17:54 +02:00
Markus Reiter
b954391214 Skip migration if cache is empty or doesn’t exist. 2018-09-01 15:29:17 +02:00
Vítor Galvão
ad66d54143
Merge pull request #4782 from amyspark/fix-quarantine-broken-symlinks
quarantine: do not automatically follow symlinks
2018-09-01 10:41:47 +01:00
Markus Reiter
0853fe14b2
Merge pull request #4787 from reitermarkus/fix-update
Only migrate cache files containing `--`.
2018-09-01 11:19:15 +02:00
Markus Reiter
3d15c7cb75 Only migrate cache files containing --. 2018-09-01 11:04:51 +02:00
Markus Reiter
d8dc1f7fe0
Merge pull request #4785 from reitermarkus/fix-cleanup-non-existent-sysmlink
Skip `mtime` for non-existent symlink.
2018-09-01 07:09:15 +02:00
Markus Reiter
ae18bdf161 Skip mtime for non-existent symlink. 2018-09-01 06:42:54 +02:00
Markus Reiter
9a699ccf54
Merge pull request #4662 from reitermarkus/resolve-url
Resolve URL to get real file extension.
2018-09-01 04:58:44 +02:00
Mike McQuaid
c83c2bc867
Merge pull request #4783 from Homebrew/dependabot/bundler/docs/rubyzip-1.2.2
[Security] Bump rubyzip from 1.2.1 to 1.2.2 in /docs
2018-08-31 19:11:39 +01:00
dependabot[bot]
6575240169
[Security] Bump rubyzip from 1.2.1 to 1.2.2 in /docs
Bumps [rubyzip](https://github.com/rubyzip/rubyzip) from 1.2.1 to 1.2.2. **This update includes security fixes.**
- [Release notes](https://github.com/rubyzip/rubyzip/releases)
- [Changelog](https://github.com/rubyzip/rubyzip/blob/master/Changelog.md)
- [Commits](https://github.com/rubyzip/rubyzip/compare/v1.2.1...v1.2.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-08-31 17:43:27 +00:00
L. E. Segovia
4c47a4b76d
quarantine: do not automatically follow symlinks
This prevents failure when Casks have broken framework symlinks.
2018-08-31 15:31:00 +00:00
Markus Reiter
f287214699 Just use resolved_path.file?. 2018-08-31 16:51:23 +02:00
Markus Reiter
9b50fd81d7 Move everything into one file. 2018-08-31 16:51:23 +02:00
Markus Reiter
443111896e Share common logic. 2018-08-31 16:51:23 +02:00
Markus Reiter
ccf396887a Add comment about refinement scope. 2018-08-31 16:51:23 +02:00
Markus Reiter
2773ce6156 Don’t clean up symlink target. 2018-08-31 16:51:23 +02:00
Markus Reiter
b63ac557bc Update symlink even if cached_location already exists. 2018-08-31 16:51:23 +02:00
Markus Reiter
9edc355052 Don’t glob for .incomplete downloads. 2018-08-31 16:51:23 +02:00
Markus Reiter
b7847e4657 Don’t migrate symlinks. 2018-08-31 16:51:23 +02:00
Markus Reiter
3988458919 Use real basename for output. 2018-08-31 16:51:23 +02:00
Markus Reiter
516a39f5a4 Move migrations into UpdateMigrator module. 2018-08-31 16:51:23 +02:00
Markus Reiter
fbcaa8c85a Resolve URL to get real file extension. 2018-08-31 16:51:23 +02:00
Claudia
47d3bbee1c
Merge pull request #4656 from amyspark/com-apple-quarantine
Enable quarantining of Homebrew-Cask's downloads
2018-08-31 15:50:29 +02:00
L. E. Segovia
f7cafb50ad
Enable quarantining of Homebrew-Cask's downloads 2018-08-31 13:16:11 +00:00
Michka Popoff
6e31c662f5
Merge pull request #4773 from iMichka/o2flag
superenv: Use 02 optimization flag for Linux builds
2018-08-30 11:09:50 +02:00
Mike McQuaid
2b9fead932
Merge pull request #4759 from MikeMcQuaid/lead-maintainer-guidelines
docs/Maintainer-Guidelines: add lead maintainer guidelines.
2018-08-30 09:00:55 +01:00
Dominyk Tiller
baab9d841f
Merge pull request #4774 from DomT4/GOCACHE
go: support & use aggressive caching
2018-08-30 04:44:37 +01:00
commitay
e4049b3005
Merge pull request #4775 from commitay/cargo-install
text_cop: update `cargo build` cop
2018-08-30 08:03:42 +10:00
Markus Reiter
801ec6e0a5
Merge pull request #4771 from reitermarkus/rubocop-path
Add `$LOAD_PATH` for RuboCop cops.
2018-08-29 23:51:11 +02:00
Mike McQuaid
8d13ef33e1
Maintainer-Guidelines: mention code of conduct. 2018-08-29 19:52:08 +01:00
Markus Reiter
eddd864a7d
Merge pull request #4776 from reitermarkus/system-command-with-spaces
Fix executable with spaces.
2018-08-29 19:58:01 +02:00
Markus Reiter
ad7054cc88 Fix executable with spaces. 2018-08-29 19:30:08 +02:00
commitay
0ce583964e text_cop: update cargo build cop 2018-08-29 23:06:53 +10:00
Dominyk Tiller
b333f7abe6
cleanup_spec: test go_cache cleanup 2018-08-29 13:16:56 +01:00