Mike McQuaid
390bf44f69
missing_formula: note on shallow clones.
...
This avoids the user confusion on incomplete results seen in
http://discourse.brew.sh/t/missing-formula-location/818/7
2017-06-03 10:02:40 +01:00
Mike McQuaid
0731a68cde
Merge pull request #2714 from choco/stty-width
...
Use stty instead of tput to get terminal width
2017-06-02 16:32:14 +01:00
Enrico Ghirardi
a9c83f14a7
Use stty instead of tput to get terminal width
...
Fixes https://github.com/Homebrew/brew/issues/2707
2017-06-02 17:00:52 +02:00
Mike McQuaid
ce80485aa4
Merge pull request #2664 from GauthamGoli/audit_caveats_rubocop
...
audit: Port audit_caveats method to rubocop and add tests
2017-06-02 15:48:22 +01:00
Mike McQuaid
760f92abba
Merge pull request #2717 from orangea/brew-edit-fix
...
don't try to find the full path of the editor in 'brew edit'
2017-06-02 15:45:59 +01:00
adrian
de78999def
don't try to find the full path of the editor in 'brew edit'
...
fixes #2709
2017-06-01 17:45:07 -07:00
ilovezfs
daa6788621
Merge pull request #2710 from DomT4/node
...
language/node: adjustments for npm 5.0.x
2017-06-01 16:49:24 -07:00
Dominyk Tiller
b6d81359f0
language/node: adjustments for npm 5.0.x
...
Goes with: https://github.com/Homebrew/homebrew-core/pull/14085
2017-06-01 21:45:26 +01:00
ilovezfs
8b26deef20
Merge pull request #2715 from Homebrew/revert-2698-operator-style
...
Revert "Fix operator spacing."
2017-06-01 04:23:53 -07:00
ilovezfs
197392b56d
Revert "Fix operator spacing."
2017-06-01 04:06:40 -07:00
Markus Reiter
63b2eb9ffd
Merge pull request #2698 from reitermarkus/operator-style
...
Fix operator spacing.
2017-06-01 08:52:49 +02:00
Markus Reiter
d34ba7395b
Fix operator spacing.
2017-05-31 19:53:41 +02:00
Gautham Goli
cf848a14d2
audit: Port audit_caveats method to rubocop and add tests
2017-05-31 22:59:48 +05:30
Misty De Meo
f9e8d84301
Merge pull request #2697 from mistydemeo/cask_fix_cabextract
...
cabextract: WARNING lines aren't fatal
2017-05-31 08:23:31 -07:00
Mike McQuaid
17650628b3
Merge pull request #2700 from sjackman/env-std-linux
...
Stdenv: Add ENV.libxml2 and ENV.x11 for Linux
2017-05-31 08:33:55 +01:00
Misty De Meo
120985e23f
Merge pull request #2684 from mistydemeo/add_vendored_sha256
...
Add vendored sha256
2017-05-30 19:10:00 -07:00
Misty De Meo
0c1186f47f
cabextract: remove -t test
...
The warnings this prints makes it not especially helpful, so
just assume the magic number test and job failure are enough.
Fixes #2689 .
2017-05-30 18:55:49 -07:00
Misty De Meo
587f338daa
vendor-install: use Ruby as a sha256 fallback
...
But still prefer shasum/sha256sum where present.
2017-05-30 18:48:55 -07:00
Misty De Meo
a40291ee4a
Pathname: use Digest::SHA256 alias
...
Digest::SHA2 wasn't exposed under that name in older versions of Ruby.
2017-05-30 18:30:16 -07:00
Mike McQuaid
90c971625e
Merge pull request #2704 from MikeMcQuaid/jenkins-brew-sh
...
Update jenkins.brew.sh links.
2017-05-30 20:28:50 +01:00
Mike McQuaid
9032574038
Update jenkins.brew.sh links.
...
These previously, incorrectly pointed to bot.brew.sh.
Fixes #2703 .
2017-05-30 19:14:40 +01:00
Mike McQuaid
344c492299
Merge pull request #2662 from GauthamGoli/audit_text_rubocop
...
audit: Port audit_text method to rubocop and add tests
2017-05-30 19:10:39 +01:00
Bob W. Hogg
e2c707d8b1
Stdenv: Add ENV.libxml2 and ENV.x11 for Linux
...
Add ENV.libxml2 primarily for the use of test do blocks.
Add a dummy ENV.x11 function.
See Linuxbrew/brew#356 and Linuxbrew/brew#382
2017-05-30 10:37:26 -07:00
Gautham Goli
cfbdc17cb7
Use relevant methods to consolidate logic in text_cop.rb
2017-05-30 15:28:05 +05:30
Gautham Goli
88f21b84f4
Refactor and add more methods in formula_cop.rb
2017-05-30 15:28:05 +05:30
Gautham Goli
51f2338dd5
audit: Port audit_text method to rubocop and add tests
2017-05-30 15:28:05 +05:30
Gautham Goli
5b97a8f2e1
Add methods in FormulaCop to find method nodes, dependency nodes
2017-05-30 15:28:05 +05:30
Mike McQuaid
d1f802c372
Merge pull request #2686 from MikeMcQuaid/remove-testbottest
...
Fix Linux build
2017-05-30 10:30:14 +01:00
Mike McQuaid
28cd0d3856
Fix Linux build
...
Remove `testbottest` formula (this should have lived in the `brew
test-bot` repository from the outset) and make various other changes to
fix the Linux build here.
2017-05-30 09:51:06 +01:00
Mike McQuaid
2f97b0ae55
Merge pull request #2695 from MikeMcQuaid/pin-bundler-version
...
tests: install specific Bundler version.
2017-05-30 07:44:24 +01:00
Misty De Meo
bfff7f9a6b
Merge pull request #2696 from mistydemeo/fix_cellar_lib_check
...
check_non_libraries: fix false positive subdirectory reports
2017-05-29 20:51:35 -07:00
Misty De Meo
2bca6fb338
check_non_libraries: fix false positive subdirectory reports
2017-05-29 16:49:21 -07:00
Mike McQuaid
2cbbdb51bf
tests: install specific Bundler version.
...
Otherwise `brew tests` fails with the latest. See the failing
Homebrew/homebrew-test-bot `master` build as an example.
2017-05-29 20:52:17 +01:00
Mike McQuaid
744e7dd190
Merge pull request #2679 from MikeMcQuaid/parallel-rubocop
...
Use parallel RuboCop
2017-05-29 19:22:46 +01:00
Mike McQuaid
7a38bab333
Fixup all RuboCop warnings.
2017-05-29 18:43:18 +01:00
Mike McQuaid
4356016b4a
Use parallel RuboCop
...
This requires updating to Rubocop 0.49.0 which will require some fixes
to rules, in Homebrew/brew and Homebrew/homebrew-core but opening this
for now so I remember.
2017-05-29 18:42:02 +01:00
Markus Reiter
3165fd2519
Merge pull request #2663 from reitermarkus/lockfile
...
Convert `FormulaLock` to more generic `LockFile`.
2017-05-29 19:27:58 +02:00
Markus Reiter
0a02d1a029
Merge pull request #2694 from reitermarkus/formatter-pluralize
...
Use `Formatter::pluralize` where possible.
2017-05-29 19:13:12 +02:00
Markus Reiter
d700a5ba18
Use Formatter::pluralize where possible.
2017-05-29 17:50:13 +02:00
Mike McQuaid
481a91a92d
Merge pull request #2693 from MikeMcQuaid/update-test-more-tweaks
...
update-test: tweak more edge cases.
2017-05-29 15:44:50 +01:00
Mike McQuaid
d7e2d5be36
update-test: tweak more edge cases.
...
Don't try to `fetch --depth=1` unless we've confirmed the repository is
already shallow. Otherwise this can discard history from a full clone.
Additionally, if the repository wasn't shallow but there's no tags found
assume that Git is too old and try a naive sort if on Linux where `sort`
is able to sort versions.
2017-05-29 15:13:08 +01:00
Mike McQuaid
dbf10cc06e
Merge pull request #2692 from MikeMcQuaid/update-test-no-tag-messaging
...
update-test: improve no tags found messaging.
2017-05-29 13:57:21 +01:00
Mike McQuaid
224d2c21ca
update-test: improve no tags found messaging.
...
Currently you just get `Could not find start commit!` which is not as
explicit as it could be.
2017-05-29 10:06:04 +01:00
Mike McQuaid
c2cb2c7868
Merge pull request #2682 from MikeMcQuaid/improve-installed-messaging
...
Improve some `brew install` messaging.
2017-05-29 09:15:15 +01:00
Mike McQuaid
da39db01a2
Merge pull request #2687 from issyl0/fix_formula_description_regex
...
Match the "formula name in description" on word boundaries
2017-05-29 08:06:27 +01:00
Markus Reiter
52b54aaeb9
Merge pull request #2690 from reitermarkus/rubocop-cache
...
Use `XDG_CACHE_HOME` for RuboCop.
2017-05-29 02:40:49 +02:00
Markus Reiter
dc4f303937
Remove unused popen_read_text method.
2017-05-29 01:45:05 +02:00
Markus Reiter
54c4580871
Use XDG_CACHE_HOME for RuboCop.
2017-05-29 01:31:38 +02:00
Isabell Long
279a4df6c3
Match the "formula name in description" on word boundaries
...
- The regexp for the "check if formula name is used in formula's
description" cop matches every instance of the formula name if it
exists, whether it's in a word or not.
- For example, the formula `mon` has the description "Monitor
hosts/services/whatever and alert about problems". This makes
`brew audit --strict` complain because it matches "Monitor",
which isn't the formula name! The formula `pass` has the description
"Password manager". Again, the strict audit matches "Password",
which isn't an issue.
- Instead, this change matches on a word boundary, so it will match
`mon:`, or `mon `, but not "Monitor", or, for example, "harmony".
- I've changed the tests to account for this change.
2017-05-29 00:26:47 +01:00
Mike McQuaid
803f9cbf7b
Merge pull request #2685 from MikeMcQuaid/more-macos-doctor
...
diagnostic: move some more macOS doctor checks.
2017-05-28 17:20:47 +01:00