admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
34,544 Commits 15 Branches 471 Tags
Commit Graph

34544 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sam Ford
ec7fd75934
Strategy#from_url: Replace #from_symbol call 
Passing the strategy symbol into the `#from_url` `select` block
means that we can also get rid of a `#from_symbol` call in a
different conditional branch, as we can directly compare the
`livecheck_strategy` symbol to `strategy_symbol`.
 2023-02-27 18:58:15 -05:00
Sam Ford
03823b5698
Strategy#from_url: Amend conditions for Json 
When the `Json` strategy was introduced, I forgot to also ensure
that it's only treated as usable (in `Strategy#from_url`) if a
`livecheck` block uses `strategy :json`. As a result, `Json` is
incorrectly treated as a usable strategy for all formulae/casks that
contain a `strategy` block.

Since all of these `livecheck` blocks specify a strategy, this bug
doesn't meaningfully impact livecheck's behavior (i.e., these checks
continue to use their explicitly-specified strategy). The only
practical difference is that `Json` incorrectly appears in the list
of usable strategies in livecheck's verbose JSON output.

This commit modifies `Strategy#from_url` to address this issue. The
easiest way to enforce this rule involved passing in the
`@strategies` key (a symbol) into the `select` block, so we can
compare it to `livecheck_strategy` (the strategy symbol specified in
the `livecheck` block).
 2023-02-27 18:58:13 -05:00
Mike McQuaid
86aeac6857
Merge pull request #14805 from dduugg/extend-kernel 
Move Kernel extensions into a separate file
 2023-02-27 19:38:35 +00:00
Douglas Eichelberger
1a0c02ffe0 Move tests too 2023-02-27 11:22:23 -08:00
Douglas Eichelberger
2b4d4a3707 Isolate Kernel extensions 2023-02-27 11:22:10 -08:00
Douglas Eichelberger
901a179ba6 Set back utils.rb file 2023-02-27 11:19:11 -08:00
Douglas Eichelberger
056ade18c0 Duplicate utils.rb history. 2023-02-27 11:19:11 -08:00
Douglas Eichelberger
ff48ce24c4 Copy utils.rb into extend/kernel.rb 2023-02-27 11:19:11 -08:00
Douglas Eichelberger
98f4fde68c Keep utils.rb 2023-02-27 11:19:11 -08:00
Mike McQuaid
810c7681f9
Merge pull request #14824 from MikeMcQuaid/cat_better_error 
dev-cmd/cat: improve error message.
 2023-02-27 17:54:48 +00:00
Mike McQuaid
d6ba3878ab
dev-cmd/cat: improve error message. 
Fixes #14815.

Co-authored-by: Adrian Ho <the.gromgit@gmail.com>
 2023-02-27 17:34:29 +00:00
Mike McQuaid
5eddc77baa
Merge pull request #14822 from maxim-belkin/wslview-win 
Use 'wslview' instead of 'xdg-open' on Windows
 2023-02-27 17:13:32 +00:00
Maxim Belkin
2b008ae7fd os/linux.rb: wsl_version: apply suggestions from code review 
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
 2023-02-27 16:56:28 +00:00
Maxim Belkin
c9b289fc3d Use 'wslview' instead of 'xdg-open' on Windows 2023-02-27 14:39:56 +00:00
Mike McQuaid
a7a3ecacba
Merge pull request #14804 from Bo98/cask-readall 
readall: reject casks with no URL
 2023-02-27 13:41:46 +00:00
Mike McQuaid
ee65414742
Merge pull request #14816 from issyl0/predicate-fork-exists-method 
utils/github: Tiny improvements, boolean methods end in `?` and remove unnecessary `.delete_prefix("/")`
 2023-02-27 13:34:01 +00:00
Mike McQuaid
5975ca981d
Merge pull request #14808 from dduugg/audit-types 
Fixed type error in 'brew audit'
 2023-02-27 13:33:05 +00:00
Mike McQuaid
4d0154fa79
Merge pull request #14806 from Homebrew/dependabot/bundler/Library/Homebrew/concurrent-ruby-1.2.1 
build(deps): bump concurrent-ruby from 1.2.0 to 1.2.1 in /Library/Homebrew
4.0.4 		2023-02-27 12:45:49 +00:00
Issy Long
a2d31faa72
dev-cmd/contributions: Support date ranges in PR reviews query 
- Now `brew contributions --from=2023-02-23 --to=2023-02-26` works to limit the
  results for reviews. I forgot this in the original implementation, again,
  ugh.
 2023-02-26 23:34:53 +00:00
apainintheneck
fdc2e9f3f5 Merge branch 'master' into delay-loading-from-cask-source-api 2023-02-26 14:50:13 -08:00
Rylan Polster
06cf85ffd4
Merge pull request #14814 from Rylan12/fix-from-content-tap-loading 
Set tap for casks when loading from contents via API
 2023-02-26 16:58:21 -05:00
apainintheneck
9af04fdf38 Add installer tests 2023-02-26 11:26:44 -08:00
Bo Anderson
09f4be844f
Merge pull request #14817 from Homebrew/sorbet-files-update 
sorbet: Update RBI files.
 2023-02-26 17:08:11 +00:00
Issy Long
214e2102c3
utils/github: Remove unnecessary .delete_prefix("/") 
- This workaround was originally added in 2020. I have confirmed with
  https://api.github.com/search/code?q=brew+language%3Aruby+org:Homebrew that
  the `path` string no longer has a leading `/`.
 2023-02-26 15:27:02 +00:00
Issy Long
550599d03b
utils/github: Switch check_fork_exists to fork_exists? 
- It's Ruby style convention that methods that return only booleans end with a
  question mark.
 2023-02-26 15:26:07 +00:00
Issy Long
a13556a1a6
Merge pull request #14813 from issyl0/contributions-approvals 2023-02-26 15:23:11 +00:00
apainintheneck
fd62cdf636 cask: delay loading from source API 
For casks with certain stanzas, *flight and language
stanzas in this case, we need to use the caskfile
to install them correctly. The JSON API is not an option.

This delays loading from the source API until just before
we try to install one of these casks. This reduces the
number of requests we make to the source API.
 2023-02-25 20:54:37 -08:00
BrewTestBot
85cebc5c8f
sorbet: Update RBI files. 
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
 2023-02-26 00:32:18 +00:00
Issy Long
591afa8ee0
utils/github: Appease brew style line length 2023-02-25 22:27:48 +00:00
Issy Long
66303bd092
Merge pull request #14812 from issyl0/contributions-order-maintiainers 
dev-cmd/contributions: Order the CSV by highest contributions total
 2023-02-25 22:20:45 +00:00
Issy Long
99d2bb9a53
utils/github: Use search_results_items method for code search 2023-02-25 22:01:12 +00:00
Issy Long
1edb59e086
test/search: Fix stubbing of GitHub::API.open_rest call 
Test failure:

```
Failure/Error:
  expect(described_class.search_taps("some-formula"))
    .to match(formulae: ["homebrew/foo/some-formula"], casks: ["homebrew/bar/some-cask"])

  GitHub::API asked to yield |[{"items"=>[{"path"=>"Formula/some-formula.rb", "repository"=>{"full_name"=>"Homebrew/homebrew-foo"}}, {"path"=>"Casks/some-cask.rb", "repository"=>{"full_name"=>"Homebrew/homebrew-bar"}}]}]| but no block was passed
```
 2023-02-25 22:00:37 +00:00
Rylan Polster
29bb0ee3bf
Set tap for casks when loading from contents via API 2023-02-25 16:24:58 -05:00
Issy Long
8c75eab88a
dev-cmd/contributions: Count PR reviews since they're super important 
- The search APIs don't have that high a rate limit but we shouldn't need to
  worry about that too much because, to get counts, the JSON response comes
  with a `total_count` number.
 2023-02-25 19:10:17 +00:00
Issy Long
0233851031
Merge pull request #14811 from Homebrew/sponsors-maintainers-man-completions 
Update manpage and completions.
 2023-02-25 18:10:25 +00:00
Issy Long
7b8f1c8714
dev-cmd/contributions: Order the CSV by highest contributions total 2023-02-25 18:04:01 +00:00
BrewTestBot
5d406ae54a
Update manpage and completions. 
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
 2023-02-25 17:52:54 +00:00
Issy Long
428193aa29
Merge pull request #14789 from issyl0/contributions-maintainers-csv 
dev-cmd/contributions: CSV output of totals per maintainer
 2023-02-25 17:51:59 +00:00
Issy Long
e68379f5df
dev-cmd/contributions: Fill in the "total" CSV row 
- Using the new "total across commits/coauthors/signoffs" data per-user,
  this also generates a more complete maintainers CSV.
 2023-02-25 01:05:41 +00:00
Bo Anderson
0172ad1028
Merge pull request #14794 from Bo98/api-check-shell 
Move `HOMEBREW_NO_INSTALL_FROM_API` defaults to shell
 2023-02-25 00:33:37 +00:00
Douglas Eichelberger
7f4250241f Fixd type error in 'brew audit' 2023-02-24 16:20:51 -08:00
Bo Anderson
e86a8c2477
Move HOMEBREW_NO_INSTALL_FROM_API defaults to shell 2023-02-24 21:53:08 +00:00
BrewTestBot
7690a50b2d
Update RBI files for concurrent-ruby. 
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
 2023-02-24 19:06:33 +00:00
BrewTestBot
e7980e9fb5
brew vendor-gems: commit updates. 2023-02-24 19:00:52 +00:00
dependabot[bot]
ddb4229df3
build(deps): bump concurrent-ruby in /Library/Homebrew 
Bumps [concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby) from 1.2.0 to 1.2.1.
- [Release notes](https://github.com/ruby-concurrency/concurrent-ruby/releases)
- [Changelog](https://github.com/ruby-concurrency/concurrent-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ruby-concurrency/concurrent-ruby/compare/v1.2.0...v1.2.1)

---
updated-dependencies:
- dependency-name: concurrent-ruby
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-02-24 18:57:22 +00:00
Bo Anderson
ba8fd26755
Merge pull request #14803 from Bo98/cask-nil-url 
cask: handle nil URLs
 2023-02-24 18:21:41 +00:00
Bo Anderson
09dbe9f86e
readall: reject casks with no URL 2023-02-24 18:07:19 +00:00
Bo Anderson
c416e4bbee
cask: handle nil URLs 2023-02-24 18:04:18 +00:00
Mike McQuaid
9fd50a9ab0
Merge pull request #14785 from samford/livecheck/add-json-strategy 
livecheck: Add `Json` strategy
 2023-02-24 18:02:40 +00:00
Bo Anderson
51e0c685f8
Merge pull request #14801 from Bo98/generate-errors 
generate-*-api: better errors
 2023-02-24 17:15:32 +00:00