Merge pull request #14804 from Bo98/cask-readall

readall: reject casks with no URL
This commit is contained in:
Mike McQuaid 2023-02-27 13:41:46 +00:00 committed by GitHub
commit a7a3ecacba
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -67,7 +67,15 @@ module Readall
success = T.let(true, T::Boolean)
casks.each do |file|
Cask::CaskLoader.load(file)
cask = Cask::CaskLoader.load(file)
# Fine to have missing URLs for unsupported macOS
macos_req = cask.depends_on.macos
next if macos_req&.version && Array(macos_req.version).none? do |macos_version|
bottle_tag.to_macos_version.public_send(macos_req.comparator, macos_version)
end
raise "Missing URL" if cask.url.nil?
rescue Interrupt
raise
rescue Exception => e # rubocop:disable Lint/RescueException