Douglas Eichelberger
2073e70696
brew style --fix
2023-02-27 21:43:10 -08:00
Douglas Eichelberger
f9f73f3ef6
Tidy up
2023-02-27 21:42:47 -08:00
Douglas Eichelberger
1ab278f74c
Fix style/type violations
2023-02-27 20:34:07 -08:00
Douglas Eichelberger
82dad857a8
Restore global
2023-02-27 20:31:01 -08:00
Douglas Eichelberger
6ea501b59f
Add tests
2023-02-27 20:30:55 -08:00
Douglas Eichelberger
325994a60c
Move inflection utils to Utils module
2023-02-27 20:20:56 -08:00
Douglas Eichelberger
0eccc0e987
git grep -l Utils::Inflection | xargs gsed -i 's|Utils::Inflection|Utils|g'
2023-02-27 20:18:27 -08:00
Douglas Eichelberger
86c500fdcc
Try removing inflections require
2023-02-27 20:18:10 -08:00
Douglas Eichelberger
8d788ec98c
Try removing String monkey-patched types
2023-02-27 20:18:10 -08:00
Douglas Eichelberger
cfdb0c2e4b
Fix type error
2023-02-27 20:18:10 -08:00
Douglas Eichelberger
7f3593e12d
inline titleize
2023-02-27 20:18:10 -08:00
Douglas Eichelberger
2c5067ec77
Port dynamic invocation
2023-02-27 20:18:10 -08:00
Douglas Eichelberger
3da68651e5
Port more call sites
2023-02-27 20:18:08 -08:00
Douglas Eichelberger
eb2b990575
Port more call sites
2023-02-27 20:17:33 -08:00
Douglas Eichelberger
2c73d4d9b7
Replace deconstantize inflection with util
2023-02-27 20:17:33 -08:00
Douglas Eichelberger
2400c6daed
brew style --fix
2023-02-27 20:17:33 -08:00
Douglas Eichelberger
d62211d3af
Replace demodulize inflection with util
2023-02-27 20:17:33 -08:00
Douglas Eichelberger
37015b6b08
Change to pluralize, port more call sites
2023-02-27 20:17:33 -08:00
Douglas Eichelberger
0438a3a538
Draft implementation to replace ActiveSupport inflections
2023-02-27 20:17:33 -08:00
Mike McQuaid
6db7732fa3
Merge pull request #14821 from issyl0/support-date-ranges-in-pr-reviews-query
...
dev-cmd/contributions: Support date ranges in PR reviews query
2023-02-28 00:06:41 +00:00
Douglas Eichelberger
1a0c02ffe0
Move tests too
2023-02-27 11:22:23 -08:00
Douglas Eichelberger
2b4d4a3707
Isolate Kernel extensions
2023-02-27 11:22:10 -08:00
Douglas Eichelberger
901a179ba6
Set back utils.rb file
2023-02-27 11:19:11 -08:00
Douglas Eichelberger
056ade18c0
Duplicate utils.rb history.
2023-02-27 11:19:11 -08:00
Douglas Eichelberger
ff48ce24c4
Copy utils.rb into extend/kernel.rb
2023-02-27 11:19:11 -08:00
Douglas Eichelberger
98f4fde68c
Keep utils.rb
2023-02-27 11:19:11 -08:00
Mike McQuaid
810c7681f9
Merge pull request #14824 from MikeMcQuaid/cat_better_error
...
dev-cmd/cat: improve error message.
2023-02-27 17:54:48 +00:00
Mike McQuaid
d6ba3878ab
dev-cmd/cat: improve error message.
...
Fixes #14815 .
Co-authored-by: Adrian Ho <the.gromgit@gmail.com>
2023-02-27 17:34:29 +00:00
Mike McQuaid
5eddc77baa
Merge pull request #14822 from maxim-belkin/wslview-win
...
Use 'wslview' instead of 'xdg-open' on Windows
2023-02-27 17:13:32 +00:00
Maxim Belkin
2b008ae7fd
os/linux.rb: wsl_version: apply suggestions from code review
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-02-27 16:56:28 +00:00
Maxim Belkin
c9b289fc3d
Use 'wslview' instead of 'xdg-open' on Windows
2023-02-27 14:39:56 +00:00
Mike McQuaid
a7a3ecacba
Merge pull request #14804 from Bo98/cask-readall
...
readall: reject casks with no URL
2023-02-27 13:41:46 +00:00
Mike McQuaid
ee65414742
Merge pull request #14816 from issyl0/predicate-fork-exists-method
...
utils/github: Tiny improvements, boolean methods end in `?` and remove unnecessary `.delete_prefix("/")`
2023-02-27 13:34:01 +00:00
Mike McQuaid
5975ca981d
Merge pull request #14808 from dduugg/audit-types
...
Fixed type error in 'brew audit'
2023-02-27 13:33:05 +00:00
Mike McQuaid
4d0154fa79
Merge pull request #14806 from Homebrew/dependabot/bundler/Library/Homebrew/concurrent-ruby-1.2.1
...
build(deps): bump concurrent-ruby from 1.2.0 to 1.2.1 in /Library/Homebrew
2023-02-27 12:45:49 +00:00
Issy Long
a2d31faa72
dev-cmd/contributions: Support date ranges in PR reviews query
...
- Now `brew contributions --from=2023-02-23 --to=2023-02-26` works to limit the
results for reviews. I forgot this in the original implementation, again,
ugh.
2023-02-26 23:34:53 +00:00
Rylan Polster
06cf85ffd4
Merge pull request #14814 from Rylan12/fix-from-content-tap-loading
...
Set tap for casks when loading from contents via API
2023-02-26 16:58:21 -05:00
Bo Anderson
09f4be844f
Merge pull request #14817 from Homebrew/sorbet-files-update
...
sorbet: Update RBI files.
2023-02-26 17:08:11 +00:00
Issy Long
214e2102c3
utils/github: Remove unnecessary .delete_prefix("/")
...
- This workaround was originally added in 2020. I have confirmed with
https://api.github.com/search/code?q=brew+language%3Aruby+org:Homebrew that
the `path` string no longer has a leading `/`.
2023-02-26 15:27:02 +00:00
Issy Long
550599d03b
utils/github: Switch check_fork_exists
to fork_exists?
...
- It's Ruby style convention that methods that return only booleans end with a
question mark.
2023-02-26 15:26:07 +00:00
Issy Long
a13556a1a6
Merge pull request #14813 from issyl0/contributions-approvals
2023-02-26 15:23:11 +00:00
BrewTestBot
85cebc5c8f
sorbet: Update RBI files.
...
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml ) workflow.
2023-02-26 00:32:18 +00:00
Issy Long
591afa8ee0
utils/github: Appease brew style
line length
2023-02-25 22:27:48 +00:00
Issy Long
99d2bb9a53
utils/github: Use search_results_items
method for code search
2023-02-25 22:01:12 +00:00
Issy Long
1edb59e086
test/search: Fix stubbing of GitHub::API.open_rest
call
...
Test failure:
```
Failure/Error:
expect(described_class.search_taps("some-formula"))
.to match(formulae: ["homebrew/foo/some-formula"], casks: ["homebrew/bar/some-cask"])
GitHub::API asked to yield |[{"items"=>[{"path"=>"Formula/some-formula.rb", "repository"=>{"full_name"=>"Homebrew/homebrew-foo"}}, {"path"=>"Casks/some-cask.rb", "repository"=>{"full_name"=>"Homebrew/homebrew-bar"}}]}]| but no block was passed
```
2023-02-25 22:00:37 +00:00
Rylan Polster
29bb0ee3bf
Set tap for casks when loading from contents via API
2023-02-25 16:24:58 -05:00
Issy Long
8c75eab88a
dev-cmd/contributions: Count PR reviews since they're super important
...
- The search APIs don't have that high a rate limit but we shouldn't need to
worry about that too much because, to get counts, the JSON response comes
with a `total_count` number.
2023-02-25 19:10:17 +00:00
Issy Long
7b8f1c8714
dev-cmd/contributions: Order the CSV by highest contributions total
2023-02-25 18:04:01 +00:00
Issy Long
428193aa29
Merge pull request #14789 from issyl0/contributions-maintainers-csv
...
dev-cmd/contributions: CSV output of totals per maintainer
2023-02-25 17:51:59 +00:00
Issy Long
e68379f5df
dev-cmd/contributions: Fill in the "total" CSV row
...
- Using the new "total across commits/coauthors/signoffs" data per-user,
this also generates a more complete maintainers CSV.
2023-02-25 01:05:41 +00:00