12752 Commits

Author SHA1 Message Date
Mike McQuaid
1d40061c69 Merge pull request #3291 from JCount/lines-cop-fix-wine-universal-binary
lines_cop: add ENV.universal_binary audit exemption for wine
2017-10-18 10:32:34 +01:00
Mike McQuaid
a5c8628ffb Merge pull request #3333 from DomT4/java_versioning
java_requirement: fix Java 9 version detection
2017-10-18 10:03:39 +01:00
Mike McQuaid
c7d21dadfe Merge pull request #3270 from sjackman/os-requirement
Add depends_on :linux and :macos
2017-10-18 09:43:45 +01:00
Markus Reiter
c4e8c7906d Merge pull request #3329 from ashfurrow/messaging
Specifies which errant version of Ruby is used in raise.
2017-10-18 08:15:48 +02:00
Dominyk Tiller
19790679bc
java_requirement: fix detection of new Java versioning scheme
Closes https://github.com/Homebrew/brew/issues/3331.
2017-10-18 07:13:33 +01:00
Shaun Jackman
230c87aff0 Rename MinimumMacOSRequirement to MacOSRequirement
Move MinimumMacOSRequirement to compat.
2017-10-17 16:16:44 -07:00
Shaun Jackman
95e144a1c8 Add depends_on :linux and :macos 2017-10-17 16:16:12 -07:00
Ash Furrow
11572c749b
Specifies which errant version of Ruby is used in raise. 2017-10-17 17:24:04 -04:00
Markus Reiter
cf349018d5 Merge pull request #3323 from reitermarkus/edit-invalid-cask
Allow editing invalid Casks.
2017-10-17 22:51:19 +02:00
Mike McQuaid
69d28f9d8f Merge pull request #3294 from DomT4/an_empty_string_is_a_naughty_desc
formula_desc_cop: empty string is not a valid desc
2017-10-17 21:29:24 +01:00
Mike McQuaid
77f3fcf254 Merge pull request #3293 from DomT4/predicate_audit
audit: more *_predicate nudging/tweaks
2017-10-17 21:12:21 +01:00
Mike McQuaid
5f64d0fdcc Merge pull request #3298 from vszakats/pull302
pull: fix bintray verification failing due to redirection
2017-10-17 21:00:14 +01:00
Markus Reiter
b4e1e39d3b Merge pull request #3296 from reitermarkus/refactor-languages
Refactor `MacOS::languages`.
2017-10-15 22:13:04 +02:00
Markus Reiter
8c3c72ec00 Allow editing invalid Casks. 2017-10-15 22:04:20 +02:00
JCount
85fa79b5cf lines_cop_spec: improve language in universal_binary and build tests 2017-10-15 10:36:51 -04:00
JCount
ca52eee2ad lines_cop_spec: add test for ENV.universal_binary audit exemption for wine 2017-10-15 10:26:03 -04:00
JCount
e882ce1919 lines_cop: add ENV.universal_binary audit exemption for wine 2017-10-15 10:25:35 -04:00
Dominyk Tiller
29070e5cbe
formula_desc_cop_spec: add empty string test 2017-10-14 02:50:08 +01:00
Dominyk Tiller
075f818118
formula_desc_cop: empty string is not a valid desc
Just a slightly tweaked version of https://github.com/Homebrew/brew/issues/3286#issuecomment-334983011
2017-10-14 02:48:55 +01:00
Markus Reiter
e1808bf0e3 Merge pull request #3309 from reitermarkus/system-command
Refactor `SystemCommand`.
2017-10-14 00:03:14 +02:00
ilovezfs
82afe5d7f7 fileutils: deprecate rake DSL
superenv and the `:ruby` requirement make a `rake` DSL unnecessary.
2017-10-13 02:01:28 -07:00
Markus Reiter
c931a1be38 Refactor SystemCommand. 2017-10-12 23:33:05 +02:00
Markus Reiter
30b84ac6f3 Merge pull request #3303 from reitermarkus/special-file-names
Properly handle special characters in file names.
2017-10-12 19:56:06 +02:00
Markus Reiter
04363b25a3 Properly handle special characters in file names. 2017-10-11 17:43:54 +02:00
Markus Reiter
5b8a3d381b Refactor MacOS::languages. 2017-10-10 17:11:22 +02:00
Markus Reiter
71b6e239d7 Set RuboCop maximum to current maximum. 2017-10-10 17:00:04 +02:00
Dominyk Tiller
0865ab0d1b audit: nudge to use predicate for 'executable?' as well 2017-10-10 15:45:41 +01:00
Viktor Szakats
811f5fd145 pull: fix bintray verification failing due to redirection 2017-10-10 13:35:49 +00:00
Dominyk Tiller
a0f4861934
audit: broaden refute_predicate nudge 2017-10-09 16:46:01 +01:00
Mike McQuaid
56458f03fc Merge pull request #3277 from sjackman/audit-notable
audit: Silence not notable on non-Homebrew taps
2017-10-08 13:41:15 -07:00
Shaun Jackman
53dd0e3f28 audit: Silence not notable on non-Homebrew taps
Silence "GitHub repository not notable" on non-Homebrew taps.
2017-10-08 10:35:53 -07:00
Markus Reiter
175ca909ee Clean up code style and remove .rubocop_todo.yml. 2017-10-08 16:10:37 +02:00
Markus Reiter
91ab116ace Merge pull request #3289 from reitermarkus/cask-loader
Fix regexes in `CaskLoader`.
2017-10-08 16:07:09 +02:00
Markus Reiter
efbc1b0cb4 Add specs for CaskLoader. 2017-10-08 15:48:54 +02:00
Markus Reiter
cbd9715e5b Fix regexes in CaskLoader. 2017-10-08 15:21:04 +02:00
Markus Reiter
69e2be832c Fix comment location. 2017-10-08 14:14:24 +02:00
Dominyk Tiller
2a25825a12
audit: tweak assert/refute_predicate audit
Addresses some of the issues I raised in https://github.com/Homebrew/homebrew-core/pull/19127#issue-263566817.
Would still like to work out a way to check `File.exist?`-style language
inside the `test do` block exclusively but for now it's better to be
too conservative on the audit than to be overly-zealous and flag too
much.
2017-10-08 06:54:49 +01:00
Markus Reiter
bae08d5188 Don’t track files in test and vendor. 2017-10-08 01:47:12 +02:00
Markus Reiter
9795195726 Fix RuboCop tests. 2017-10-07 23:30:47 +02:00
Markus Reiter
5cbf8bdaa7 Merge pull request #3283 from reitermarkus/cask-loader
Add helper method for Cask fixture paths and refactor CaskLoader.
2017-10-07 18:30:32 +02:00
Markus Reiter
97333df4cb Add helper method for Cask fixture paths and refactor CaskLoader. 2017-10-07 16:11:25 +02:00
Markus Reiter
62315e93f8 Merge pull request #3280 from commitay/cask-internal-audit
InternalAuditModifiedCask: audit renamed Casks
2017-10-07 15:55:02 +02:00
commitay
4fde8f56ce add pkg / binary comment 2017-10-07 23:10:59 +10:00
commitay
a7cf6c1ff0 Cask AbstractArtifact: fix install order 2017-10-07 22:06:39 +10:00
commitay
d5cc68fba3 InternalAuditModifiedCask: audit renamed Casks 2017-10-07 12:53:07 +10:00
Markus Reiter
8f43d6b9f7 Merge pull request #3267 from reitermarkus/refactoring
Refactor DSL and Artifact classes.
2017-10-07 00:32:42 +02:00
Mike McQuaid
708c4e0ebd Merge pull request #3273 from MikeMcQuaid/mdfind-reject-backups
os/mac: ignore apps found in Time Machine backups.
2017-10-06 15:20:51 +01:00
ilovezfs
10491e1c30 Merge pull request #3274 from MikeMcQuaid/official-taps-remove-apache
official_taps: remove apache.
2017-10-05 21:00:48 -07:00
Mike McQuaid
3c0162a5ba Merge pull request #3269 from DomT4/assert_predicate
audit: prefer assert/refute_predicate over File.exist?
2017-10-06 04:34:56 +01:00
Mike McQuaid
dd2083d03d Merge pull request #3262 from kabel/version-detect-php
Add version detection support for php URL
2017-10-06 04:34:12 +01:00