1133 Commits

Author SHA1 Message Date
Mike McQuaid
264afb67df dev-cmd/audit: fix Rubocop warnings. 2016-09-11 19:14:55 +01:00
Mike McQuaid
90d16a8f86 dev-cmd/aspell-dictionaries: fix Rubocop warnings. 2016-09-11 18:28:43 +01:00
Mike McQuaid
237b70168e bottle: set bottle block tap.
Avoids issues when using `—keep-old`
2016-09-11 17:33:39 +01:00
Mike McQuaid
f583199f6e test-bot: don't try to git clean any taps.
Also, unify the cleanup code and be more careful and consistent with
untapping.
2016-09-11 14:14:31 +01:00
Mike McQuaid
3d73515028 test-bot: try again to fix homebrew/core untap.
Be more selective with the `git clean` and remove the broken attempt
to autotap if missing (as it'd be slow anyway).
2016-09-11 12:31:44 +01:00
Mike McQuaid
2ec5423356 test-bot: --ci-upload can upload from current dir.
Look in the current directory rather than only allowing upload from
Jenkins.
2016-09-11 11:28:15 +01:00
Mike McQuaid
ad3359b96e Merge pull request #916 from MikeMcQuaid/bottle-old-value
bottle: fix old_value/value ordering for --merge.
2016-09-11 10:39:58 +01:00
Mike McQuaid
be6876c79a bottle: fix old_value/value ordering for --merge.
Previously this was the wrong way around causing it to not be accepting
enough on e.g. a bump from :any to :any_no_relocation.
2016-09-10 21:15:28 +01:00
Mike McQuaid
d0c33b3705 bottle: use key/value rather than field.
Consistent naming is good.
2016-09-10 19:43:49 +01:00
Mike McQuaid
ea5da9b592 bottle: further improve --keep-old mismatching.
- Make the code more similar between `bottle` and `bottle --merge`.
- Also output the mismatched values when using `--merge`.
2016-09-10 16:12:27 +01:00
Mike McQuaid
cfc930011d Merge pull request #907 from MikeMcQuaid/brew-tests-developer
tests: always set HOMEBREW_DEVELOPER=1.
2016-09-10 15:39:47 +01:00
Mike McQuaid
44ba4583b7 bottle: improve --keep-old failure output.
If fields have changed: tell the user what they were before and are
afterwards.
2016-09-10 10:13:33 +01:00
Mike McQuaid
274035381d tests: always set HOMEBREW_DEVELOPER=1.
Unit tests should be run consistently no matter who is running them and
we can stub `ARGV.homebrew_developer?` if we need to change them.
2016-09-10 09:50:40 +01:00
Mike McQuaid
71881fd7a6 Add DEVELOPER COMMANDS to manpage. 2016-09-08 20:46:51 +01:00
Mike McQuaid
86bfd36af2 Don't hide some (now) developer commands. 2016-09-08 20:46:37 +01:00
Mike McQuaid
af8605ea4b Move developer-focused commands to dev-cmd. 2016-09-08 20:46:37 +01:00
Mike McQuaid
ebdb879fe4 Add --help to all developer commands.
Also, flag those that we never want to be in a manpage.
2016-09-08 09:05:00 +01:00
Mike McQuaid
665c56538e test-bot: separate tap/core no formula handling.
`e.tap` calls the tap method which wants a block on
`FormulaUnavailableError` so the previous approach is 👎.
2016-09-07 12:47:23 +01:00
Mike McQuaid
f9fe5b6798 test-bot: handle missing tap in exception.
Handle the case where a `FormulaUnavailableError` does not contain a tap
reference so fall back to `CoreTap` in this case.
2016-09-07 11:40:28 +01:00
Mike McQuaid
159ba9b012 test-bot: put exception, retry on missing formula.
This will be useful in debugging (and recovering from) the situation
where sometimes formulae can't be found when specifying multiple on the
command-line.
2016-09-07 08:42:00 +01:00
Mike McQuaid
b21d724618 test-bot: tweak cleaning behaviour again.
Always run `git clean -ffdx` on HOMEBREW_REPOSITORY. Also, ensure that
if we can't find a formula that's logged.
2016-09-06 12:00:08 +01:00
Mike McQuaid
c676189455 test-bot: git clean less in cleanup_*.
There's edge-cases which is breaking tap CI.
2016-09-06 08:44:11 +01:00
Mike McQuaid
0a098ae55d test-bot: never cleanup homebrew/core.
Otherwise weird things happen and formulae can't be found.
2016-09-05 20:17:49 +01:00
Mike McQuaid
3acaecca8b test-bot: use UPSTREAM_BOTTLE_KEEP_OLD.
This is set by Jenkins to indicate a downstream bottle upload job needs
to use `brew bottle --keep-old`.
2016-09-04 20:07:37 +01:00
Mike McQuaid
81747364e7 Merge pull request #869 from MikeMcQuaid/test-bot-cleanup-all-taps
test-bot: cleanup all repositories.
2016-09-04 18:59:16 +01:00
ilovezfs
de65f28d3c Merge pull request #376 from ilovezfs/bump-formula-pr-audit
bump-formula-pr: audit formula before opening PR

note that it was made opt-in not opt-out
2016-09-04 10:28:27 -07:00
Mike McQuaid
14236c3950 test-bot: cleanup all repositories.
The test bot currently only focuses on doing cleanup on the current tap
and the HOMEBREW_REPOSITORY. This should be extended to cover all
repositories as e.g. a syntax error in homebrew/core can break the CI
for all the other taps.
2016-09-04 11:26:38 +01:00
Mike McQuaid
d8a2a90dac test-bot: add missing @tap check. 2016-09-04 11:04:36 +01:00
Mike McQuaid
1feda75081 test-bot: don't run brew tests etc. when formulae.
If there's formulae changes or the specified argument is a formula then
don't waste time running e.g. `brew tests`.
2016-09-03 20:24:47 +01:00
ilovezfs
f5a462bca1 bump-formula-pr: audit formula before opening PR 2016-09-03 10:47:04 -07:00
Mike McQuaid
0dc0bc1617 Merge pull request #773 from reitermarkus/report-cask-coverage
Also report Cask coverage.
2016-09-01 20:31:40 +01:00
Steven Peters
bcdd20a165 test-bot: use --full-name in brew deps invocation
This allows changed formulae in taps to be tested in the proper order.
See #738 for more details.
2016-08-28 00:30:38 -07:00
Markus Reiter
c1621f7f54 Also report Cask coverage. 2016-08-27 10:17:20 +02:00
Markus Reiter
a11f536280 Remove exist? check for brew-cask-tests.rb. 2016-08-26 11:46:32 +02:00
William Woodruff
f0efaac5aa
Enable ruby-macho by default.
Flips HOMEBREW_RUBY_MACHO to HOMEBREW_NO_RUBY_MACHO.
2016-08-20 10:31:34 -04:00
Martin Afanasjew
bb4d168c48 Merge pull request #760 from jasonkarns/bump-formula-pr-return-to-branch
bump-formula-pr: return to starting branch
2016-08-20 11:36:43 +02:00
Jason Karns
f40fd1df90 bump-formula-pr: return to starting branch
After branching, bumping, pushing, and pr-ing; return to whatever branch
was originally checked out.

In most cases, I'd imagine users to want to continue receiving tap
updates from master. However, after using bump-formula-pr, the tap in
which the formula was bumped is left on the working branch that was
doing the bumping and pull-request. After opening the PR, we should
return to whatever branch the user originally had checked out – most
likely master. (But git allows us to just say "previous branch" by using
`-`)
2016-08-19 15:59:55 -04:00
Jason Karns
07efe1e771 bump-formula-pr now creates non-tracking branches
Without `--no-track`, some git setups may automatically set
`origin/master` as the tracked upstream for the newly created branch.
This upstream is what hub defaults as --head when opening PRs. By not
allowing git to set `origin/master` as upstream, hub can then use the
proper --head for the PR.

Since hub still needs to know what --head is intended to be, we can set
the branch's upstream when pushing: with the --set-upstream option.

Fixes #755
2016-08-19 10:50:51 -04:00
Mike McQuaid
27ecf588c7 Rename bottle's revision to rebuild. 2016-08-18 17:32:35 +01:00
Xu Cheng
e423617d77
remove ruby 1.8 compatible codes 2016-08-18 14:35:39 +08:00
Mike McQuaid
8490985953 test-bot: tap cask before cask-tests. 2016-08-17 14:47:41 +01:00
Mike McQuaid
cf71e30180 Merge pull request #724 from MikeMcQuaid/assume-ruby-two
Assume Ruby 2
2016-08-17 11:07:17 +01:00
Mike McQuaid
3ae663c013 test-bot: assume Ruby 2. 2016-08-17 09:19:56 +01:00
Mike McQuaid
135ecd1295 Prepare for Homebrew Cask to be imported.
- ignore Cask's files in `readall` (for now, there's an intentional
  syntax error that will need fixed)
- run Cask's tests if they exist
- don't check Cask's files in coverage reports (for now)
2016-08-17 09:11:11 +01:00
Martin Afanasjew
823505a058 Fix minor issues in command help text formatting
- Inconsistent or unneeded indentation
- Missing or superfluous empty lines
- Missing or wrongly formatted arguments in command summary
- Missing punctuation
2016-08-17 01:25:51 +02:00
Mike McQuaid
65164cb386 update-test: tweak master not updated check.
Loosen this a bit; we don't necessarily expect the end commit is the one
we're looking for, just that it has changed from the start commit (i.e.
some sort of update has occurred).

Addresses some false negatives on `master` branch merges that weren't
present on the PR commits.
2016-08-14 11:52:22 +01:00
Mike McQuaid
b9d5b11f32 update-test: check we end up at end commit.
This would have caught the bug fixed in 985c67.
2016-08-11 11:26:37 +01:00
Mike McQuaid
1a240cd52a Tweak HOMEBREW_NO_AUTO_UPDATE handling.
This can just live in `brew.sh` and then it doesn’t need repeated in
all the other places.
2016-08-10 15:37:04 +01:00
Mike McQuaid
3f7adf214d test-bot: never auto-update. 2016-08-09 09:01:54 +01:00
Mike McQuaid
e011589635 Revert "test-bot: don't run cmd taps generic tests."
This reverts commit 24f7e671317dfe22f1d8e10426db2e9074674bc9.
2016-08-08 10:52:34 +01:00