1133 Commits

Author SHA1 Message Date
Mike McQuaid
9fa014710d audit: further refactor http content checks.
Check homepages and don’t check mirrors unless `—strict`.
2017-02-23 10:16:27 +00:00
Mike McQuaid
96a8f8f172 audit: check for version aliases.
Current version aliases should be provided for versioned formulae so
people can `brew install foo@1.2` to provide pin-like behaviour.
2017-02-23 09:14:54 +00:00
Mike McQuaid
1a436b4d24 Merge branch 'master' into mirror_audit 2017-02-23 09:12:18 +00:00
Mike McQuaid
5e90575004 audit: handle redirects in get_content_details. 2017-02-23 09:09:58 +00:00
Mike McQuaid
5390897883 audit: refactor http content checks. 2017-02-23 09:09:33 +00:00
Markus Reiter
3f8e52e574 Merge pull request #2091 from reitermarkus/spec-exclude-needs_macos
Exclude specs with `:needs_macos` tag when not on macOS.
2017-02-23 09:34:17 +01:00
Markus Reiter
48a211fc90 Convert os/mac/language test to spec. 2017-02-23 02:47:33 +01:00
Mike McQuaid
ac5b6b6eea Revert "audit: fix revision should be removed." 2017-02-22 08:49:24 +00:00
ilovezfs
4e34f7b60e Merge pull request #2086 from MikeMcQuaid/audit-revision-remove-fix
audit: fix revision should be removed.
2017-02-21 14:09:58 -08:00
Markus Reiter
168a96d919 Exclude specs with :needs_macos tag when not on macOS. 2017-02-21 21:55:16 +01:00
ilovezfs
b59bf2ff64 Revert "audit: check for version aliases." 2017-02-21 11:31:18 -08:00
Mike McQuaid
2f42dfc68a audit: fix revision should be removed.
Regression introduced in #1754 which meant that (due to storing the
current formula revision in `attributes_map`) `stable_revisions.empty?`
would never be `true`.
2017-02-21 18:50:07 +00:00
Mike McQuaid
606790d062 audit: check for version aliases.
Current version aliases should be provided for versioned formulae so
people can `brew install foo@1.2` to provide pin-like behaviour.
2017-02-21 15:36:49 +00:00
Mike McQuaid
96a695bc6d Merge pull request #2054 from zmwangx/bump-formula-pr-smarter-dupe
bump-formula-pr: improve duplicate detection
2017-02-20 22:54:51 +00:00
Mike McQuaid
125a6eee21 audit: fix brew style. 2017-02-20 22:48:03 +00:00
David Broder-Rodgers
55bc2a3019 Merged 404 and security mirror auditing logic 2017-02-20 19:24:35 +00:00
David Broder-Rodgers
12501b4046 Prevent mirror curl for file:/// URL 2017-02-20 19:24:35 +00:00
David Broder-Rodgers
a699d284d0 Use DownloadStrategyDetector to classify mirror URLs 2017-02-20 19:24:35 +00:00
David Broder-Rodgers
81b3368c9c Added better check for HTTP git URLs 2017-02-20 19:24:35 +00:00
David Broder-Rodgers
a731f4e17c Updated HTTP mirror check to use new url_status_code method 2017-02-20 19:24:34 +00:00
David Broder-Rodgers
d3ac333197 Rubocop styling fixes 2017-02-20 19:24:31 +00:00
David Broder-Rodgers
3e7dfe4aab Updated mirror audit problem message 2017-02-20 19:24:25 +00:00
David Broder-Rodgers
ed9f775b77 Added support for returning HTTP status codes and for git and svn URLs 2017-02-20 19:24:19 +00:00
David Broder-Rodgers
ea440ca328 Markups to online mirror auditing 2017-02-20 19:24:13 +00:00
David Broder-Rodgers
7eec6a3a25 Updated resource auditing to detect invalid mirrors when using --online 2017-02-20 19:23:58 +00:00
ilovezfs
c667a43b97 audit: fix insecure mirror check when stdout is empty 2017-02-20 07:51:04 -08:00
Zhiming Wang
81a7609213
bump-formula-pr: improve duplicate detection
Reduce the chance of false flagging by making sure that the existing pr
surfaced by GitHub.issues_for_formula actually contains the exact formula name
in its title.
2017-02-20 10:36:24 -05:00
Mike McQuaid
d24ac0555c Merge pull request #1722 from broder/insecure_audit
Added check for insecure mirror URLs
2017-02-20 11:26:41 +00:00
Mike McQuaid
b2dd6bc9b0 audit: fix brew style warning. 2017-02-15 14:41:06 +00:00
Mike McQuaid
9c3825fc77 Merge pull request #1997 from ilovezfs/block-duplicate-pull-requests
bump-formula-pr: block duplicate pull-requests
2017-02-15 14:39:13 +00:00
Viktor Szakats
64448834a6 fix existing rule for github.io homepages 2017-02-13 16:20:34 +00:00
Viktor Szakats
a09169f248 audit: enforce https for *.sourceforge.io urls 2017-02-13 14:58:28 +00:00
Mike McQuaid
7281cfaf63 Merge pull request #1972 from timotheecour/pr_brew_where_command
add `brew formula` command to show location of a formula
2017-02-13 08:32:35 +00:00
ilovezfs
539120143b bump-formula-pr: block duplicate pull-requests 2017-02-12 10:36:24 -08:00
Alyssa Ross
9e97eadccb rubocop: trailing comma in multiline method calls
Discussed in
https://github.com/Homebrew/brew/pull/1987/files#r100693581.

This was originally ommitted because it wasn't compatible with Ruby 1.8.
(See https://github.com/Homebrew/legacy-homebrew/pull/48144#r49928971).
2017-02-12 15:11:38 +00:00
Mike McQuaid
674e5f13f8 Merge pull request #1873 from GauthamGoli/audit_custom_cops
Custom Cops for `brew audit`
2017-02-12 13:09:28 +00:00
Markus Reiter
1292a4b219 Merge pull request #1955 from vszakats/patch-2
audit: enforce https://*.sourceforge.io/ homepages
2017-02-12 11:05:21 +01:00
Timothee Cour
0d715f90ea applied changes suggested in PR 2017-02-11 16:38:06 -08:00
Timothee Cour
ac091437e5 renamed where to formula 2017-02-11 16:38:06 -08:00
Timothee Cour
ae829ed229 add brew where command 2017-02-11 16:38:06 -08:00
Markus Reiter
c4ac308302 Allow brew tests to run specs. 2017-02-11 15:59:54 +01:00
Mike McQuaid
1413cd15ba Merge pull request #1958 from maveonair/tests-cli-help
Fix: Documentation of --only in tests cmd
2017-02-10 14:56:16 +00:00
Viktor Szakats
03253a8d8b audit: enforce https://*.sourceforge.io/ homepages
Ref: https://sourceforge.net/blog/introducing-https-for-project-websites/
2017-02-10 14:53:32 +00:00
Markus Reiter
2d05c9d80c Merge pull request #1961 from vszakats/githuburl
audit: enforce https for github.com urls
2017-02-09 06:24:56 +01:00
ilovezfs
79280826f5 pull: fix false positives for nonstandard bump subjects when untapped
If the formula's tap isn't tapped yet when running `brew pull`, a false
positive occurs for the nonstandard bump subject check, and a bogus
warning is printed, which claims the bump subject should refer to the
old version not the new version.
2017-02-08 00:58:20 -08:00
Viktor Szakats
11ebfdafb2 audit: enforce https for github.com urls 2017-02-07 00:19:58 +00:00
Fabian Mettler
ba2ec8abcc Fix: Documentation of --only in tests cmd
This pull request fixes the documentation for the —only flag of the
tests cmd.
2017-02-06 14:22:17 +01:00
Gautham Goli
1f5cf4fd40 Update docs and manpages to include --fix option 2017-02-06 12:46:26 +05:30
David Broder-Rodgers
64c83f3286 Use file checksum rather than file diffing 2017-02-02 21:25:29 +00:00
David Broder-Rodgers
d4aa98d230 Updated mirror checks to compare ETags, Content-Lengths and binary files 2017-01-30 21:49:42 +00:00