admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
6,770 Commits 15 Branches 471 Tags
Commit Graph

249 Commits

Author SHA1 Message Date
Jack Nagel
7c4324d5ea Fix formula template comment audit 2014-12-22 01:12:44 -05:00
Jack Nagel
cd7004b579 Deprecate appending the CVS module name to the URL string 2014-12-22 00:52:10 -05:00
Jack Nagel
0344d243e4 Deprecate made-up URL schemes 
This deprecates URLs that begin with the following fake URL schemes:
  bzr://
  cvs://
  hg://
  fossil://
  svn+http://

Despite their appearance, they are not actually accepted by the
corresponding tools. They exist only as hints to the download strategy
detection code, and are stripped from the URL before the URL is handed
off to the VCS program.

This is not documented, and may lead one to believe it is a valid URL
that can be used elsewhere, when it actually only works inside Homebrew.

We have a better mechanism for specifying the download strategy that is
straightforward and explicit:
  :using => :hg

Recommend that instead.

Closes Homebrew/homebrew#35114.
 2014-12-19 12:28:18 -05:00
Jack Nagel
ef48a5e7d7 Deprecate UnsafeSubversionDownloadStrategy 2014-12-18 16:45:15 -05:00
Jack Nagel
89dc0b9787 One less place where Formula is reopened 2014-11-12 21:41:14 -06:00
Jack Nagel
16a2220834 Exempt the head-only tap from the head-only audit warning 2014-11-12 21:32:44 -06:00
Jack Nagel
673f08f17e audit: compare file mode directly 2014-10-29 22:47:17 -05:00
Jack Nagel
1195718d0e Rename "f" to "formula" in the installer 2014-10-29 22:41:03 -05:00
Jack Nagel
f8c0c27566 Deprecate insecure download strategies 2014-10-18 17:39:53 -05:00
Jack Nagel
b6631b9a15 audit: call puts once instead of problems.size + 2 times 2014-10-17 00:35:51 -05:00
Jack Nagel
fb30041640 audit: loop over deps once 2014-10-17 00:11:46 -05:00
Jack Nagel
73d08fcc1a Audit devel and head deps 2014-10-17 00:08:17 -05:00
Jack Nagel
b05351d0b2 Reorganize post-install checks so we can share more code 2014-10-13 23:13:01 -05:00
Jack Nagel
b46ebf8a29 Simplify post-install audit output 2014-10-13 23:13:00 -05:00
Jack Nagel
09d53f4fc5 Remove audit whitelist 
This is currently unnecessary.
 2014-10-13 23:13:00 -05:00
Tim D. Smith
9134718f9c Audit formulæ for easy-install.pth files 
Closes Homebrew/homebrew#32860.
 2014-10-02 11:58:13 -07:00
Jack Nagel
c4818394cb Post-install audit for shadowed header files 2014-10-01 23:32:53 -05:00
chdiza
22d8380b05 audit: make has_DATA? ignore commented-out lines 
Before this change, audit would detect commented-out lines
containing the string 'DATA' as if there were no commenting.
Then it could complain, e.g., problem "'DATA' was found, but no
'__END__'", which would be a false alarm in that circumstance.

Closes Homebrew/homebrew#32568.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2014-09-23 15:19:13 -05:00
Jack Nagel
d7dddc8f08 Audit for outdated devel versions 2014-09-23 13:04:55 -05:00
Jack Nagel
e717508b7b audit: access the homepage attribute once 2014-09-14 15:43:20 -05:00
Mike McQuaid
d3150f3a06 audit: fix line number typo. 
Closes Homebrew/homebrew#32031.
 2014-09-02 11:50:00 +01:00
Jack Nagel
fe1bf57a15 audit: fix line number off-by-one 2014-09-01 23:25:16 -05:00
Jack Nagel
0bf3ec593d Fix false positive audit warning 2014-08-21 15:13:13 -05:00
Jack Nagel
f4ae1c9e1b Hide the options data structure better 2014-07-31 19:59:09 -05:00
Jack Nagel
dc2080bd9f Remove patch hacks from audit 2014-07-29 16:22:06 -05:00
Adam Vandenberg
bb2c9b7ba4 audit 'def test' 
Closes Homebrew/homebrew#31120
 2014-07-27 15:10:15 -07:00
Jack Nagel
72129668f4 audit: warn when using old-style patches 2014-07-11 12:46:41 -05:00
Jack Nagel
330e18bb17 Use predicate methods instead of inspecting the tags array 2014-07-01 21:57:30 -05:00
Jack Nagel
10a1952d2c Only "extend self" once on the Homebrew module 2014-06-19 13:10:36 -05:00
Jack Nagel
5c24876d02 Fix audit suggestion 2014-06-15 23:28:06 -05:00
Jack Nagel
62e79c8d09 audit: read formula text in binmode 2014-06-04 15:37:36 -05:00
Jack Nagel
9f42b6b9c7 Drop emacs dep audit 
cf. Homebrew/homebrew#24802.
 2014-05-04 22:45:57 -05:00
Adam Vandenberg
7fe9413cf1 audit: use .diff instead of .patch for github diffs 2014-04-11 07:31:56 -07:00
Lee Hanxue
af4aff8c13 brew audit: show line number for whitespace 
Closes Homebrew/homebrew#24481.
Closes Homebrew/homebrew#24490.
 2014-04-06 10:30:36 -07:00
Jack Nagel
63da62c6d0 Revert "Audit gnome URLs, prefer download.gnome.org" 
This reverts commit 557ef8df05a8ea28ed903f08b2009ebc0e218f5a.
 2014-04-03 09:29:23 -05:00
Mike McQuaid
bf8ff2dcb7 audit: check the use of Dir[] 
Sometimes `Dir[]` is used with single files/directories unnecessarily.
 2014-03-31 11:52:59 -05:00
Jack Nagel
94f324d778 Audit gnome URLs, prefer download.gnome.org 2014-03-30 18:00:00 -05:00
Mike McQuaid
7846ed4f76 audit: don't warn about tarball in non-GitHub URL. 2014-03-25 16:14:03 +00:00
Jack Nagel
f760ee2751 audit: #{prefix}/Frameworks -> #{frameworks} 2014-03-21 20:09:56 -05:00
Ian Lancaster
58456a5469 audit: suggest proper if build.with(out) usage 
Closes Homebrew/homebrew#27759.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2014-03-21 17:07:27 +00:00
Jack Nagel
dc8218fdb5 audit: catch new style gist URLs 2014-03-19 18:24:10 -05:00
Geoff Nixon
9bbe38aa59 audit: fix gist patch URL regex 
Closes Homebrew/homebrew#27255.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Conflicts:
	Library/Homebrew/cmd/audit.rb
 2014-03-19 18:24:08 -05:00
Jack Nagel
4f051abc3e Teach audit about new patches implementation 2014-03-13 21:35:41 -05:00
Ian Lancaster
9c345bfc03 audit: Raise problem with non-https Google Code download urls 2014-03-08 09:10:54 -08:00
Mike McQuaid
a5bed1ea31 audit: check for good with/without usage. 
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2014-03-08 00:54:35 +00:00
Mike McQuaid
1070acfe7a audit: don't use GitHub zip files. 
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2014-03-08 00:54:35 +00:00
Mike McQuaid
1fd8e7fd75 audit: better handle formulae whitelisting. 
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2014-03-08 00:54:35 +00:00
Adam Vandenberg
7e45cbafca audit: ...or quoted 2014-03-05 07:53:53 -08:00
Adam Vandenberg
d55dc8d01e audit: find env/export as a full word, not as a prefix 
Closes Homebrew/homebrew#27219.
 2014-03-05 07:53:19 -08:00
Jaime Marquínez Ferrándiz
8a014b3221 audit: Raise a problem if the SourceForge download url uses http instead of https 
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2014-03-02 09:16:53 -08:00