6770 Commits

Author SHA1 Message Date
Jack Nagel
1bdeeefb94 Overriding #initialize is not supported, so drop late validation 2014-12-26 16:05:34 -05:00
Jack Nagel
dbfbe76ac1 Fix warning 2014-12-26 15:39:34 -05:00
Mike McQuaid
dc7b54ae43 formula: add/improve more API docs.
Closes Homebrew/homebrew#35266.
2014-12-26 20:24:20 +00:00
Jack Nagel
80aef5fdb9 Fix method redefinition warning
test_defined? gets defined in the method_added hook.
2014-12-26 12:05:59 -05:00
Jack Nagel
dd90030213 Fix "possible reference to past scope" warnings on 2.2 2014-12-26 11:58:09 -05:00
Jack Nagel
c50fdbd139 Implement GithubGistFormula in a more natural way 2014-12-26 01:31:56 -05:00
Mike McQuaid
7afe1ed67a requirements: recommend casks where available.
Also, tweak the XQuartz requirement to not show 0.0.0 versions being required.

Closes Homebrew/homebrew#35254.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-12-25 20:45:57 +00:00
Baptiste Fontaine
278b77e6c5 Quote path in conflict error rm command
Fixes Homebrew/homebrew#35143.
Closes Homebrew/homebrew#35239.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-12-24 12:16:16 -05:00
Jack Nagel
1b1a73bddb Always show attribute value in validation error message 2014-12-23 15:37:24 -05:00
Jack Nagel
e8e5889d32 Update minitest 2014-12-23 15:37:24 -05:00
Mike McQuaid
f9917768a9 test-bot: fix use of select!. 2014-12-23 20:19:45 +00:00
Mike McQuaid
f475f750f9 test-bot: test bottled dependents.
Test everything that `brew uses` a formula, has a bottle and a test.

This should allow some quick gains in terms of spotting formulae that may need
revisioned to avoid problems with shifting dependencies. As the test-bot lives
in a data centre with (very) fast internet the fetch and extraction time
shouldn't slow things down much.

Closes Homebrew/homebrew#35092.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-12-23 19:14:30 +00:00
Kevin Sjöberg
73ff739583 Convert dependencies to formulas for name matching
Dependency names are prefixed with the tap location, therefore
dependency names do not match formula names. We convert dependencies
into formulas to ensure proper name checking.

Closes Homebrew/homebrew#35058.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-12-23 14:08:40 -05:00
Jaime Marquínez Ferrándiz
a0b36563ea language_module_dependency: fix finding opam.
`opam list <package>` only checks if the package is available

Closes Homebrew/homebrew#35209.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-12-23 10:14:53 +00:00
Misty De Meo
62addcfce8 uninstall: improve grammar for multiple version message 2014-12-23 00:50:46 -08:00
Jack Nagel
be59b4ea4f Mark cached_location as an attribute 2014-12-23 01:27:10 -05:00
Jack Nagel
32bf6d9937 Avoid check-then-act pattern in clear_cache 2014-12-23 01:11:08 -05:00
Jack Nagel
957ef9b6b9 Document download strategy interface 2014-12-23 01:04:44 -05:00
Jack Nagel
5575fb843c Don't raise NotImplementedError 2014-12-23 01:04:44 -05:00
Jack Nagel
cef553491c The class-level keg_only_reason is private API 2014-12-22 11:50:31 -05:00
Jack Nagel
d831473fe5 Use "@api private" instead of "@private"
http://www.rubydoc.info/gems/yard/file/docs/Tags.md#private
http://www.rubydoc.info/gems/yard/file/docs/Tags.md#api
2014-12-22 11:49:37 -05:00
Jack Nagel
7c4324d5ea Fix formula template comment audit 2014-12-22 01:12:44 -05:00
Jack Nagel
d3daa8a25b Mark deprecated download strategies as such 2014-12-22 00:52:10 -05:00
Jack Nagel
cd7004b579 Deprecate appending the CVS module name to the URL string 2014-12-22 00:52:10 -05:00
Jack Nagel
df70d960f8 Assume CVS module name when none is given 2014-12-22 00:43:02 -05:00
Jack Nagel
8a1ed0e748 Allow :module => "name" for CVS URLs 2014-12-22 00:43:02 -05:00
Baptiste Fontaine
69b01772cc Typo in skip_clean? documentation
Closes Homebrew/homebrew#35142.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-12-20 11:41:00 -05:00
Jack Nagel
0344d243e4 Deprecate made-up URL schemes
This deprecates URLs that begin with the following fake URL schemes:
  bzr://
  cvs://
  hg://
  fossil://
  svn+http://

Despite their appearance, they are not actually accepted by the
corresponding tools. They exist only as hints to the download strategy
detection code, and are stripped from the URL before the URL is handed
off to the VCS program.

This is not documented, and may lead one to believe it is a valid URL
that can be used elsewhere, when it actually only works inside Homebrew.

We have a better mechanism for specifying the download strategy that is
straightforward and explicit:
  :using => :hg

Recommend that instead.

Closes Homebrew/homebrew#35114.
2014-12-19 12:28:18 -05:00
Xu Cheng
fff4b83a52 (un)linkapps: allow unlink/link specific formulae.
Closes Homebrew/homebrew#35080.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-12-19 16:35:45 +00:00
Jack Nagel
d97daa7c1b Fix references to url 2014-12-18 20:09:52 -05:00
Jack Nagel
ef48a5e7d7 Deprecate UnsafeSubversionDownloadStrategy 2014-12-18 16:45:15 -05:00
Jack Nagel
eec429b9b6 Add :using => :fossil 2014-12-18 13:06:05 -05:00
Jack Nagel
867a87b50a Move url munging to initialize 2014-12-18 13:06:05 -05:00
Jack Nagel
ef4347b898 Start versioning cached git clones 2014-12-18 12:57:37 -05:00
Alan Ivey
cec6ee6527 Update brew-services information
@gapple has taken the mantle of brew services: https://github.com/Homebrew/homebrew/issues/28657#issuecomment-58318215

Closes Homebrew/homebrew#35090.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-12-18 15:39:37 +00:00
Mike McQuaid
4716ee838e Revert "Start versioning cached git clones"
This reverts commit f4fe50a0958b7b47b32041e11d4943d6ae7d3972.
2014-12-18 13:03:32 +00:00
Jack Nagel
1cfeba04a8 Start versioning cached git clones 2014-12-17 23:18:17 -05:00
Jack Nagel
6096ec9568 Unset LIBRARY_PATH before builds
See https://gcc.gnu.org/onlinedocs/gcc/Environment-Variables.html

Closes Homebrew/homebrew-versions#592.
2014-12-17 14:40:05 -05:00
Jack Nagel
9a2f2aee7e Use Utils.popen_read to avoid shelling out in a few places 2014-12-16 15:51:57 -05:00
Jack Nagel
8c0928ccca Use quiet_system to avoid the shell 2014-12-16 15:27:36 -05:00
Jack Nagel
7e20b353a2 Utils.popen_read doesn't doesn't require a block 2014-12-16 15:27:36 -05:00
Kyungdahm Yun
a70a805111 Capitalize descriptions of --HEAD, --devel
Closes Homebrew/homebrew#35027.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-12-16 12:22:29 -05:00
Dominyk Tiller
1c3a810830 Documentation Updates
Some minor changes to reflect Homebrew/homebrew#34989, and other bits and pieces.

Closes Homebrew/homebrew#35023.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-12-16 00:41:07 -05:00
Mike McQuaid
2cb5da6916 create: remove formula include. 2014-12-15 07:50:14 +00:00
Jack Nagel
9a89878b75 Revert "Skip temporary directory when target directory is known"
This reverts commit 028ee18b851497f8aede55004bcdcc5c16f087cc.
2014-12-14 17:59:35 -05:00
Jack Nagel
5ca4dbfd25 Skip temporary directory when target directory is known 2014-12-14 13:32:55 -05:00
Mike McQuaid
612230a705 doctor: check cache directory is writable.
Fixes Homebrew/homebrew#32304.
Fixes Homebrew/homebrew#34933.
2014-12-14 10:17:29 +00:00
Jack Nagel
0ed43d607b Validate arguments in Resource#stage 2014-12-13 23:27:59 -05:00
Xu Cheng
a3000f3ea9 tap-readme: fix indent
Closes Homebrew/homebrew#34953.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-12-13 18:14:49 -05:00
Jack Nagel
d91d56555c Formula#install has public visibility
It is called with an explicit receiver in build.rb, so the base class
method should also be public.
2014-12-12 22:31:15 -05:00