29701 Commits

Author SHA1 Message Date
Sam Ford
085827f605
Handle variable strategy block arguments
There are times where a regex isn't needed in a `strategy` block and
these changes explicitly handle that situation.

This allows the Symbol Proc format used in some `Sparkle` `livecheck`
blocks (e.g., `strategy :sparkle, &:version`) to continue working
instead of failing with a "wrong number of arguments (given 1,
expected 0)" error. This error would occur because a Symbol Proc only
only expects one argument (e.g., an `Item`, not an `Item` and a
regex/nil).

There's an argument to be made for avoiding the Symbol Proc format
for `strategy` blocks but I haven't found a way of selectively
disabling the Style/SymbolProc cop only for a `strategy` DSL method
call. That is to say, if we don't use the Symbol Proc format, `brew
style` will give a "Pass &:version as an argument to strategy instead
of a block." offense.

Besides that, this also replaces the `block` type signatures in
livecheck strategies with `T.untyped`. Sorbet doesn't know how to
handle a `Proc` with a variable number of arguments and can't be
taught how (i.e., `T.any` with a `Proc` signature for each variation
doesn't work). The aforementioned changes cause Sorbet to complain
about there being both too many and too few arguments, so the only
way to win is not to play the game. Hopefully we can restore the
`block` type signatures in the future (if upstream resolves this
years-old issue) but `T.untyped` seems to be our only option for now.
2021-11-19 23:58:55 -05:00
Sam Ford
e73524b093
livecheck: Fix debug strategy info printing
The `ExtractPlist` strategy doesn't return certain values (e.g.,
`:url`), so it's necessary to also ensure these values are present
before printing related debug info. Without these changes, we end up
printing info for a blank value (e.g., "URL (strategy):").
2021-11-19 23:58:55 -05:00
Sam Ford
9e8900fb6e
Allow regex to be passed into all strategy blocks
This modifies cask-related livecheck strategies to allow passing a
regex into a `strategy` block, when appropriate. These strategies
were outliers that explicitly rejected a regex even if a `strategy`
block was used, forcing any regex to be inlined in the `strategy`
block (instead of being defined using `#regex`).

With these changes, all `strategy` blocks will be able to accept a
regex, further simplifying the mental model. This also helps to
better align the various `find_versions` and `versions_from_*`
methods across strategies.
2021-11-19 23:58:54 -05:00
Alexander Bayandin
27a76295a4
Merge pull request #12279 from bayandin/synced-versions-formulae
formula_auditor: add audit for formulae with synced versions
2021-11-19 12:24:33 +00:00
Mike McQuaid
7241f8db2e
Merge pull request #12450 from scpeters/unbottled_taps
dev-cmd/unbottled: don't skip non-core formulae
2021-11-19 12:20:20 +00:00
Mike McQuaid
a0660e9c1b
Merge pull request #12448 from FnControlOption/renames
Print warning if given old short name of renamed formula
2021-11-19 12:20:12 +00:00
Mike McQuaid
a36cfa2c71
Merge pull request #12452 from FnControlOption/switch
Add missing `--formulae/--casks` aliases for `--formula/--cask`
2021-11-19 12:19:18 +00:00
fn ⌃ ⌥
b766799d95 Add missing --formulae/--casks aliases for --formula/--cask 2021-11-18 12:41:03 -08:00
Nanda H Krishna
faaa980860
Merge pull request #12451 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.9351
build(deps-dev): bump sorbet from 0.5.9338 to 0.5.9351 in /Library/Homebrew
2021-11-18 14:15:49 -05:00
BrewTestBot
dde131ace6
brew vendor-gems: commit updates. 2021-11-18 18:11:53 +00:00
dependabot[bot]
a45b15ce23
build(deps-dev): bump sorbet in /Library/Homebrew
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.9338 to 0.5.9351.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-18 18:05:20 +00:00
fn ⌃ ⌥
55fc6e1c9b migrate: load specified formulae by keg to avoid rename warning 2021-11-18 09:47:25 -08:00
Steve Peters
aa4e39785c
dev-cmd/unbottled: don't skip non-core formulae
Related to Homebrew/homebrew-test-bot#705

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
2021-11-18 08:13:44 -08:00
Mike McQuaid
1e37a188cb
Merge pull request #12444 from iMichka/docs
docs/Acceptable-Formulae: specify the list of supported platforms
2021-11-18 12:14:44 +00:00
Mike McQuaid
f05ecd647d
Merge pull request #12435 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-1.23.0
build(deps): bump rubocop from 1.22.0 to 1.23.0 in /Library/Homebrew
2021-11-18 12:09:15 +00:00
Michka Popoff
c4f57af057
docs/Acceptable-Formulae: specifiy the list of supported platforms 2021-11-18 11:49:55 +00:00
Mike McQuaid
a2e2ea4b51
.rubocop.yml: allow OpenStruct. 2021-11-18 11:48:30 +00:00
BrewTestBot
68f1685b97
Update RBI files for rubocop. 2021-11-18 11:48:30 +00:00
BrewTestBot
7e6c6fee33
brew vendor-gems: commit updates. 2021-11-18 11:48:30 +00:00
dependabot[bot]
840db1db18
build(deps): bump rubocop from 1.22.0 to 1.23.0 in /Library/Homebrew
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.22.0 to 1.23.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.22.0...v1.23.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-18 11:48:30 +00:00
Mike McQuaid
f7bd2d4122
Merge pull request #12442 from Homebrew/dependabot/bundler/Library/Homebrew/rbi-0.0.7
build(deps): bump rbi from 0.0.6 to 0.0.7 in /Library/Homebrew
2021-11-18 11:33:57 +00:00
fn ⌃ ⌥
db0c1d999b Print warning if given old short name of renamed formula 2021-11-17 22:20:48 -08:00
Bo Anderson
dbe565eff2
Regenerate Tapioca RBI 2021-11-18 01:59:04 +00:00
BrewTestBot
fa3bf7804f
Update RBI files for rbi. 2021-11-18 01:39:47 +00:00
BrewTestBot
17ac7ec75d
brew vendor-gems: commit updates. 2021-11-18 01:34:22 +00:00
dependabot[bot]
f96fffbed8
build(deps): bump rbi from 0.0.6 to 0.0.7 in /Library/Homebrew
Bumps [rbi](https://github.com/Shopify/rbi) from 0.0.6 to 0.0.7.
- [Release notes](https://github.com/Shopify/rbi/releases)
- [Commits](https://github.com/Shopify/rbi/compare/v0.0.6...v0.0.7)

---
updated-dependencies:
- dependency-name: rbi
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-18 01:30:03 +00:00
Bo Anderson
38630a6f80
Merge pull request #12447 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.9338
build(deps-dev): bump sorbet from 0.5.9327 to 0.5.9338 in /Library/Homebrew
2021-11-18 01:30:01 +00:00
BrewTestBot
2a4b5f7c1c
brew vendor-gems: commit updates. 2021-11-17 18:07:49 +00:00
dependabot[bot]
38e913fc20
build(deps-dev): bump sorbet in /Library/Homebrew
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.9327 to 0.5.9338.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-17 18:04:57 +00:00
Mike McQuaid
f1121fc65a
Merge pull request #12445 from FnControlOption/csv
cask: add `#csv` to version DSL
2021-11-17 12:17:45 +00:00
Mike McQuaid
cf1e701a2c
Merge pull request #12441 from Homebrew/dependabot/bundler/Library/Homebrew/mime-types-3.4.1
build(deps): bump mime-types from 3.3.1 to 3.4.1 in /Library/Homebrew
2021-11-17 11:21:34 +00:00
Mike McQuaid
26cf90fef7
Merge pull request #12446 from Homebrew/update-man-completions
Update maintainers, manpage and completions.
2021-11-17 11:18:07 +00:00
BrewTestBot
d087e783d8
Update RBI files for mime-types. 2021-11-17 10:56:46 +00:00
BrewTestBot
d9786dd5bb
brew vendor-gems: commit updates. 2021-11-17 10:52:07 +00:00
BrewTestBot
de7e7a230b
Update maintainers, manpage and completions.
Autogenerated by the [update-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/update-man-completions.yml) workflow.
2021-11-17 10:51:48 +00:00
Mike McQuaid
07f14c32e9
Merge pull request #12423 from FnControlOption/deps
deps: add `--graph` and `--dot` switches
2021-11-17 10:49:19 +00:00
Mike McQuaid
5e72aea97c
Merge pull request #12439 from carlocab/file-annotations
utils/github/actions: make `file` a mandatory argument
2021-11-17 10:48:57 +00:00
dependabot[bot]
3e14f3380f
build(deps): bump mime-types from 3.3.1 to 3.4.1 in /Library/Homebrew
Bumps [mime-types](https://github.com/mime-types/ruby-mime-types) from 3.3.1 to 3.4.1.
- [Release notes](https://github.com/mime-types/ruby-mime-types/releases)
- [Changelog](https://github.com/mime-types/ruby-mime-types/blob/main/History.md)
- [Commits](https://github.com/mime-types/ruby-mime-types/compare/v3.3.1...v3.4.1)

---
updated-dependencies:
- dependency-name: mime-types
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-17 10:48:36 +00:00
Mike McQuaid
c31e8a122e
Merge pull request #12440 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-0.5.9327
build(deps-dev): bump sorbet from 0.5.9319 to 0.5.9327 in /Library/Homebrew
2021-11-17 10:48:32 +00:00
Mike McQuaid
af3d21e7c1
Merge pull request #12443 from Homebrew/dependabot/bundler/Library/Homebrew/mime-types-data-3.2021.1115
build(deps): bump mime-types-data from 3.2021.0901 to 3.2021.1115 in /Library/Homebrew
2021-11-17 10:47:31 +00:00
fn ⌃ ⌥
68160df041 cask: add #csv to version DSL 2021-11-16 16:34:12 -08:00
BrewTestBot
84a979d76b
Update RBI files for mime-types-data. 2021-11-16 18:20:18 +00:00
BrewTestBot
06bca8991e
brew vendor-gems: commit updates. 2021-11-16 18:15:31 +00:00
BrewTestBot
d371359c1c
brew vendor-gems: commit updates. 2021-11-16 18:10:51 +00:00
dependabot[bot]
cd779bd347
build(deps): bump mime-types-data in /Library/Homebrew
Bumps [mime-types-data](https://github.com/mime-types/mime-types-data) from 3.2021.0901 to 3.2021.1115.
- [Release notes](https://github.com/mime-types/mime-types-data/releases)
- [Changelog](https://github.com/mime-types/mime-types-data/blob/main/History.md)
- [Commits](https://github.com/mime-types/mime-types-data/compare/v3.2021.0901...v3.2021.1115)

---
updated-dependencies:
- dependency-name: mime-types-data
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-16 18:06:08 +00:00
dependabot[bot]
ebec7f98d0
build(deps-dev): bump sorbet in /Library/Homebrew
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.9319 to 0.5.9327.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-16 18:04:45 +00:00
fn ⌃ ⌥
87e9a495d1 deps: add --graph and --dot switches 2021-11-16 08:50:39 -08:00
fn ⌃ ⌥
a188215d69 deps: minor refactoring 2021-11-16 08:45:59 -08:00
Carlo Cabrera
105d1f9cfc
utils/github/actions: make file a mandatory argument
An annotation is pretty useless if you don't specify a file to place the
annotation on, so let's just require it.
2021-11-16 23:42:03 +08:00
Mike McQuaid
d63c4d2761
Merge pull request #12431 from EricFromCanada/docs-section-2
Updates for Docs section 2
2021-11-16 14:59:26 +00:00