663 Commits

Author SHA1 Message Date
Tim Masliuchenko
91ddb6e53d Cleanup specs 2019-10-24 14:22:13 +03:00
Tim Masliuchenko
87f29857f0 Pass section to the constructor 2019-10-23 18:34:16 +03:00
Tim Masliuchenko
22d821323c Feedbacks 2019-10-23 16:28:00 +03:00
Markus Reiter
04493e2dde Fix trash.swift without arguments. 2019-10-23 06:59:39 +02:00
Tim Masliuchenko
3ef5e06943 Add Manpage artifact 2019-10-22 15:21:49 +03:00
Markus Reiter
7a5e4d1269 Remove User::automation_access?. 2019-10-22 07:38:35 +02:00
Mike McQuaid
8a93230c15
test/cask: remove disabled functionality tests. 2019-10-15 09:52:33 +01:00
Mike McQuaid
1b4fdc17f4
Raise deprecation exceptions in tests
Previously tests which hit `odeprecated` would print warnings but not
always raise exceptions or fail. Combine this with the ability to have
`odeprecated` to turn into `odisabled` on certain dates and you have
tests that may fail just on the clock changing (this is bad).

Instead, ensure that tests always raise deprecations as exceptions so
that new deprecations will have their tests handled immediately.
2019-10-15 08:52:42 +01:00
Issy Long
341ea60807
Auto-fix Style/RedundantBegin offenses
- This also required auto-fixes for Layout/EmptyLinesAroundBlockBody and
  Layout/InconsistentIndentation once the auto-fixer had got rid of the
  "redundant begin"s.
2019-10-13 16:04:27 +01:00
Mike McQuaid
e3ee64a5fd
Ruby 2.6.3 brew tests fixes 2019-10-10 16:17:06 +01:00
Markus Reiter
b6b9cd248c Refactor brew cask style. 2019-10-04 23:43:48 +02:00
Markus Reiter
7f39d333bc Move assert_success to SystemCommand::Result. 2019-10-04 23:39:25 +02:00
Markus Reiter
e351e6b31c
Merge pull request #6482 from alecclarke/run-style-checks-on-test-casks
Include test casks in the cask style check.
2019-10-04 23:15:59 +02:00
Markus Reiter
b1d0c61fea Update Gems. 2019-10-03 09:22:44 +02:00
Alec Clarke
45806f6a97 Include test casks in the cask style check.
Currently the tests casks found in "/Homebrew/test/support/fixtures/cask/Casks" and "/Homebrew/test/support/fixtures/third-party/Casks" aren't included in the paths checked when running "brew cask style".

This change includes these test cask paths in the checked paths, and also includes the auto style fixes made by running `brew cask style --fix`.
2019-09-23 08:50:24 -04:00
Alec Clarke
af10d13381 Check blacklisted Casks when auditing.
In some cases, certain Casks shouldn't be resubmitted for specific reasons: difficult to maintain, developers maintain their own version, ...

To make sure these cases are restricted - we can add them to a blacklist and have the blacklist checked as part of the `brew cask audit` steps.
2019-09-17 06:29:46 -07:00
Markus Reiter
d8afed206f Use AppleScript to check if GUI apps are running. 2019-09-15 01:37:04 +02:00
Markus Reiter
f010aa48ff Skip AppleScript actions if Automation Access isn't granted. 2019-09-13 16:35:44 +02:00
Markus Reiter
16d2f8264c Use MacOSRequirement for casks. 2019-08-21 06:57:21 +02:00
Jonathan Chang
7ddc185b35 Fix various typos 2019-08-19 16:12:34 +10:00
Doug Hogan
55fcd01bed cask/cmd/upgrade: add --dry-run option. 2019-07-26 23:20:56 -07:00
Mike McQuaid
3dc82bc8bf
Commit 'brew style --fix' results. 2019-07-23 17:09:57 +01:00
Cheng XU
ba517e07e2
fix brew style error
Spec path should end with cask/cmd/cache*_spec.rb.
describe Cask::Cmd::Cache, :cask do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-05-23 15:50:55 +08:00
Cheng XU
8ad48f56e8
add test for brew cask --cache 2019-05-23 15:28:00 +08:00
Isabell (Issy) Long
7a367980b6
Add a blank line between brew cask info output for multiple casks
- `brew info` adds a blank line between info output for multiple
  formulae. This replicates that display for `brew cask info`, as
  requested in Issue 6126.
2019-05-13 19:45:08 +01:00
Julian Mayer
a061a8d9f7 add optional checking whether appcast contains the version stanza to "brew cask audit" 2019-05-07 17:06:54 +02:00
Mike McQuaid
c4f72312ce
Fixup brew style failures. 2019-04-30 09:19:18 +01:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Vítor Galvão
0ee226769a hbc: remove all *_to_slashes 2019-04-17 16:31:35 +01:00
Mike McQuaid
8229e592d7
cask/cmd/info_spec: needs network connection.
Tag it accordingly.
2019-04-17 17:34:33 +09:00
Mike McQuaid
1281c4a663
Merge pull request #5983 from zachauten/continue-upgrading-casks-after-failure
'brew cask upgrade' will continue upgrading casks after a failure
2019-04-14 10:01:32 +01:00
Mike McQuaid
0750971870
Merge pull request #5893 from reitermarkus/version-unstable
Add `#unstable?` method for cask versions.
2019-04-14 10:00:57 +01:00
Mike McQuaid
3b842ef41f
Merge pull request #6014 from vitorgalvao/caskroom-home
cask home: update to brew.sh
2019-04-14 10:00:15 +01:00
EricFromCanada
e0558dc7c7 trim line breaks 2019-04-13 21:37:48 -04:00
EricFromCanada
fa6404e0f5 grammar fixes 2019-04-13 21:29:32 -04:00
Vítor Galvão
67ca3d372a cask home cmd: update homepage to brew.sh 2019-04-13 19:47:14 +01:00
Zach Auten
41b5b788d5 'brew cask upgrade' will continue upgrading casks after a failure
'cask upgrade' command collects all exceptions thrown
from individual casks during the upgrade process. If
there were more than one cask that raised exceptions
during the upgrade process, a MultipleCaskErrors
exception will be thrown.

Issue #5203
2019-04-12 19:26:33 -04:00
Michael
2fbe4fe3b7
Update create_spec.rb 2019-04-07 02:10:01 +02:00
Mike McQuaid
75257886f2
Cleanup some RSpec tests
Fix some Rubocop RSpec checks, update some values and improve
documentation.
2019-03-28 19:16:56 +00:00
Markus Reiter
2a3b7d072d Add #unstable? method for cask versions. 2019-03-27 13:48:03 +01:00
Markus Reiter
42d90f8bd9 Use same logic for installer script: and uninstall script:. 2019-03-03 06:21:11 +01:00
Mike McQuaid
17f3ee1957
Improve Bundler cleanup
Rather than trying to be smart and doing this ourselves in `brew cleanup` let’s just installed Bundler somewhere it doesn’t try to clean itself up and use `bundle install --cleanup` when we need cleanup done.

Also, use `ohai` and `odie` when possible as they look nicer.
2019-02-27 14:02:46 +00:00
Markus Reiter
707cb33346 Add tests for Cask::Config. 2019-02-15 10:09:14 +01:00
Markus Reiter
190ff7558a Use saved cask config for reinstall/upgrade/uninstall. 2019-02-15 10:09:14 +01:00
Markus Reiter
fda6e0cab3 Split cask config into three tiers. 2019-02-15 10:09:14 +01:00
Markus Reiter
1e1ce1c471 Save config file for casks. 2019-02-15 10:09:14 +01:00
Mike McQuaid
3060125c45
rubocop: autofix problems. 2019-02-11 09:50:09 +00:00
Markus Reiter
0fcc62db31 Run uninstall rmdir: after uninstalling artifacts. 2019-02-08 01:09:48 +01:00
Danny Weinberg
b0124c4fb0 Cask handle already downloaded file
The current logic for curl_download tries to restart any existing
partial download, but this fails for some servers when the file is
already fully downloaded, returning a status code 416. This updates the
function to check for the file being already downloaded and if so bails
early.

The following command used to fail when run more than once but now works
as expected:
```
brew cask info https://raw.githubusercontent.com/homebrew/homebrew-cask/master/Casks/docker.rb
```
2019-02-01 14:57:50 -08:00
Markus Reiter
d22c2eca9e Refactor ConflictsWith to be a DelegateClass(Hash). 2019-01-27 21:48:12 +01:00