admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
39,924 Commits 15 Branches 471 Tags
Commit Graph

663 Commits

Author SHA1 Message Date
Markus Reiter
eccd20e276 Merge Hbc::Container classes into UnpackStrategy. 2018-07-24 16:44:27 +02:00
Markus Reiter
e5e8033145 Add system_command helpers. 2018-07-22 23:24:18 +02:00
Markus Reiter
28384ba518 Rename Hbc::SystemCommand to SystemCommand. 2018-07-22 21:11:47 +02:00
Claudia
8666d8fa18
Increase spec timeout to 30 seconds 
I’ve noticed the deadlock test in `cask/system_command_spec.rb` appears to fail spuriously, e. g. in #4529.

Details:

https://travis-ci.org/Homebrew/brew/jobs/406827725#L297-L318

With the spec taking 2 seconds on average on my 2017 MBP, I feel it’s
entirely plausible for the aging test-bot hardware to get knocked by
the 15-second timeout.

Given that the spec will pass early anyway if it passes, I feel it’s
reasonable to bump the timeout to 30 seconds.
 2018-07-22 16:27:16 +02:00
Markus Reiter
2452b27866 Refactor ErrorDuringExecution. 2018-07-19 16:41:27 +02:00
Markus Reiter
e5865e7e7f Assimilate Containers with UnpackStrategy. 2018-07-16 23:50:45 +02:00
commitay
43bfbe2060
Merge pull request #4343 from commitay/cask-info-updates 
cask info: display `auto_updates`
 2018-07-16 09:32:17 +10:00
Mike McQuaid
bd5131d710
Merge pull request #4392 from MikeMcQuaid/more-deprecation-disabled 
Disable more deprecations.
 2018-07-15 14:48:00 +01:00
commitay
6d1f99fa5f cask info: display auto_updates 2018-07-15 11:13:04 +10:00
Markus Reiter
b7e849799f
Merge pull request #4469 from reitermarkus/systemcommand-path 
Don’t expand `executable` path in `SystemCommand`.
 2018-07-14 22:45:43 +02:00
Mike McQuaid
5c6ef3d920 Disable more deprecations. 
- Turn more old `odeprecated` into `odisabled`
- Remove more old `odisabled`
- Remove code for older Ruby versions
 2018-07-14 16:00:50 +01:00
Vítor Galvão
3742cf892c
Merge pull request #4457 from commitay/latest-autoupdate 
cask audit: check for `latest` with `auto_updates`
 2018-07-14 14:29:19 +01:00
Markus Reiter
a9e109e31a Don’t expand executable path in SystemCommand. 2018-07-14 02:33:42 +02:00
Markus Reiter
232fb9721e Hbc::init does not exist anymore. 2018-07-13 23:03:18 +02:00
Mike McQuaid
62f8c96bdb test/cask/cli_spec: temporary skip some tests. 
These seem to be related to a leaking RSpec double between tests and
I've verified `brew cask install` still behaves as expected so
let's skip them temporarily.
 2018-07-13 09:14:40 +01:00
commitay
ba929cd9e1 cask audit: check for latest with auto_updates 2018-07-12 19:22:47 +10:00
Mike McQuaid
459e2bfa48
Merge pull request #4455 from reitermarkus/heredocs 
Use more descriptive heredoc names.
 2018-07-12 09:30:35 +01:00
Markus Reiter
7762ce32aa Use more descriptive heredoc names. 2018-07-11 18:15:30 +02:00
Markus Reiter
20ec595cb2 Fix Installer not supporting plain executables. 2018-07-11 16:56:37 +02:00
Markus Reiter
05cb6cda08 Add Installer spec. 2018-07-11 16:46:33 +02:00
Markus Reiter
37f3a603ce Use env utility instead of with_env. 2018-07-11 16:46:33 +02:00
Markus Reiter
1f5311888e Add failing spec for SystemCommand. 2018-07-11 15:58:38 +02:00
Markus Reiter
98bb073b46
Merge pull request #4265 from claui/fix-pkg-environment 
Fix PKG installer environment
 2018-07-11 08:25:19 +02:00
Markus Reiter
4ddb1123d7
Merge pull request #4426 from reitermarkus/refactor-system-command-plist 
Simplify `Hbc::SystemCommand::Result#plist`.
 2018-07-09 18:30:32 +02:00
Markus Reiter
fcf8cb24fd Remove unused incremental_hash method. 2018-07-06 23:14:34 +02:00
Claudia
3dbb735f3c
Fix PKG installer environment 
This commit solves an issue where the environment handed to
`/usr/sbin/installer` is not the same as the environment used by the
graphical PKG installer.

This is evident in some post-install scripts, e. g. the
`component-10.pkg/Scripts/postinstall` script in the `dymo-label`
cask. The code says:

```
USER_ID=`id -u ${USER}`

launchctl bootstrap gui/$USER_ID /Library/LaunchAgents/com.dymo.dls.webservice.plist
```

The graphical installer will export e. g. `USER=alice`, and
everything works as intended.

However, `brew cask install` does not override `sudo`’s default,
which is `USER=ROOT`. This violates the assumptions in the script.

This commit fixes the issue by configuring `sudo` to override the
following environment variables with the proper user name:

- `LOGNAME`
- `USER`
- `USERNAME`
 2018-07-06 09:38:00 +02:00
Markus Reiter
e07eddc391 Simplify Hbc::SystemCommand::Result#plist. 2018-07-05 10:54:35 +02:00
commitay
44a78a12a9
Merge pull request #4344 from commitay/cask-audit-all-appcasts 
cask audit: check for devmate and hockeyapp appcasts
 2018-07-04 11:13:40 +10:00
Claudia
79682df8b6
Re-enable tests by removing a stray rspec :focus 2018-07-02 16:01:01 +02:00
Andrew Janke
e0a8a79921 Style fixes for Rubocop 0.57.1 2018-06-30 19:40:14 -04:00
commitay
b12498159b cask audit: check for devmate and hockeyapp appcasts 2018-06-28 23:17:05 +10:00
Markus Reiter
a8bfe09c49 Remove tests for brew cask search. 2018-06-18 16:23:35 +02:00
Vítor Galvão
9831e67452
Merge pull request #4346 from commitay/version-minor_patch 
cask dsl versions: add minor_patch
 2018-06-16 13:18:21 +01:00
commitay
c5bbf28dd6 cask dsl versions: add minor_patch 2018-06-15 22:40:33 +10:00
Markus Reiter
44f56a0773 Refactor join("") to join. 2018-06-15 13:56:08 +02:00
Markus Reiter
502b393d66 Fix tests. 2018-06-14 22:45:20 +02:00
commitay
c3ac638b9f appcast: remove calculate_checkpoint 2018-06-11 13:15:32 +10:00
commitay
c68526ac09 audit: remove appcast checkpoints 2018-06-11 13:14:00 +10:00
Markus Reiter
12ab263784 Remove Hbc.default_tap. 2018-06-09 10:13:28 +02:00
Markus Reiter
fee2b56e14 Rename Cask tap for specs. 2018-06-09 10:03:21 +02:00
Markus Reiter
3d423b0587 Add path method to Caskroom and Cache. 2018-06-09 09:52:48 +02:00
Markus Reiter
458a1e7903 Remove Locations module. 2018-06-09 09:01:09 +02:00
Markus Reiter
cb7f25ceb8 Refactor brew cask search. 2018-06-07 18:42:30 +02:00
Markus Reiter
845cb99e29 Ignore HOMEBREW_NO_GITHUB_API when testing. 2018-06-07 14:02:31 +02:00
Markus Reiter
717032d86d Use Searchable module. 2018-06-07 14:02:31 +02:00
Markus Reiter
14b3b82fca Remove exact match from brew cask search. 2018-06-07 13:48:35 +02:00
commitay
b9b3952494 cask audit: review changes 2018-06-05 19:20:38 +10:00
commitay
c354d76e47 cask audit: various 2018-06-05 19:13:32 +10:00
commitay
f012b5acf8 cask audit: check for sourceforge appcast 2018-06-05 16:42:19 +10:00
Markus Reiter
de246cc528 Update Homebrew-Cask references. 2018-05-25 18:20:02 +02:00