20749 Commits

Author SHA1 Message Date
Mike McQuaid
04ae589d5c
cmd/uninstall: note etc files that stay around.
We don't remove `etc` files on uninstall. Now we have `pkgetc`, though,
we have a pretty decent guess at what files in `etc` may belong to a
given package and can warn about them being left around on uninstall.

Thoughts: should we do the same thing for `var`? I don't see it being
used nearly as consistently.
2020-05-08 10:37:51 +01:00
Mike McQuaid
a635db0f26
Merge pull request #7525 from MikeMcQuaid/deprecated_cask_taps
os/mac/diagnostic: check for deprecated cask taps.
2020-05-08 09:53:52 +01:00
Mike McQuaid
2b224a66a5
os/mac/diagnostic: check for deprecated cask taps.
We keep seeing users popping up with these (#7449) so advise an untap.
2020-05-08 09:18:55 +01:00
Mike McQuaid
29abc81f51
Merge pull request #7519 from MikeMcQuaid/cleanup-tweaks
cleanup: tweak missing clean file behaviour.
2020-05-07 11:24:11 +01:00
Mike McQuaid
38bd4e6d10
Merge pull request #7521 from MikeMcQuaid/fix-options
cli: fix options handling.
2020-05-07 11:14:27 +01:00
Mike McQuaid
929a4678c6
Merge pull request #7518 from MikeMcQuaid/shellenv_bash_profile
shellenv: recommend .bash_profile
2020-05-07 11:03:22 +01:00
Mike McQuaid
80ce0c7adc
Merge pull request #7513 from Homebrew/dependabot/bundler/Library/Homebrew/activesupport-6.0.3
build(deps): bump activesupport from 6.0.2.2 to 6.0.3 in /Library/Homebrew
2020-05-07 11:01:22 +01:00
Mike McQuaid
4da5c09c25
cleanup: tweak missing clean file behaviour.
Instead of cleaning every time if the file is missing: don't clean this
time, touch the file and clean when it's next needed.

Now that this feature has been around for longer this makes more sense
for existing installations and stops the first `brew install` run on a
new/test installation without this file always running a `brew cleanup`.

Also, fix up the use of a compat/deprecated method hit by tests by
this change.
2020-05-07 11:01:09 +01:00
Mike McQuaid
426c0ceb18
brew vendor-gems: commit updates. 2020-05-07 10:37:19 +01:00
Mike McQuaid
c05b3a755f
shellenv: recommend .bash_profile
Fixes #7516
2020-05-07 10:34:59 +01:00
Mike McQuaid
7d2f8749ca
Merge pull request #7520 from MikeMcQuaid/cli_args_style
cli/args: cleanup weird style.
2020-05-07 10:33:39 +01:00
Mike McQuaid
c91f397605
cli: fix options handling.
Fix breaking options on taps again (second time in two weeks, sob).

To avoid doing this again: also add a test for this case (that I've
verified would have caught these cases).
2020-05-07 10:33:02 +01:00
Mike McQuaid
85a9fc4abe
cli/args: cleanup weird style.
This got autofixed by RuboCop but looks weird.
2020-05-07 10:02:34 +01:00
dependabot-preview[bot]
5e4e0401b0
build(deps): bump activesupport in /Library/Homebrew
Bumps [activesupport](https://github.com/rails/rails) from 6.0.2.2 to 6.0.3.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v6.0.3/activesupport/CHANGELOG.md)
- [Commits](https://github.com/rails/rails/compare/v6.0.2.2...v6.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-07 08:19:29 +00:00
Mike McQuaid
954c833de2
Merge pull request #7514 from Homebrew/dependabot/bundler/docs/activesupport-6.0.3
build(deps): bump activesupport from 6.0.2.2 to 6.0.3 in /docs
2020-05-07 09:18:17 +01:00
dependabot-preview[bot]
f3e373cf6f
build(deps): bump activesupport from 6.0.2.2 to 6.0.3 in /docs
Bumps [activesupport](https://github.com/rails/rails) from 6.0.2.2 to 6.0.3.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v6.0.3/activesupport/CHANGELOG.md)
- [Commits](https://github.com/rails/rails/compare/v6.0.2.2...v6.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-06 18:06:36 +00:00
Mike McQuaid
61b98a5e2e
Merge pull request #7511 from rwhogg/tap-pin-command-explanation
docs: Update tap-pin and tap-unpin disable explanations
2020-05-06 14:27:00 +01:00
Bob Wombat Hogg
63e6632aa9 docs: Update tap-pin and tap-unpin disable explanations
I interpreted the existing message as meaning "you don't pin
a tap any more, rather you pin a specific formula from that
tap". I.e. the command still worked, but it had to be done
on a per-formula basis (eg. `brew tap-pin linuxbrew/xorg/mesa` instead
of just `brew tap-pin linuxbrew/xorg`)

IMO, this makes it clearer that the command itself is no longer
supported.
2020-05-06 08:54:54 -04:00
Mike McQuaid
c88d587b5b
Merge pull request #7508 from MikeMcQuaid/pkgetc
formula: add pkgetc method.
2020-05-06 11:04:54 +01:00
Mike McQuaid
be5bbcd78a
Merge pull request #7509 from MikeMcQuaid/cli_refactoring
Refactor CLI to remove `unless args_parsed`
2020-05-06 11:04:22 +01:00
Mike McQuaid
20a1199375
Refactor CLI to remove unless args_parsed
Refactor the CLI::Args module so it doesn't have different paths to
check arguments depending on whether the arguments have been parsed or
not. Instead, set the values we need from the global ARGV at
first, global initialisation time where they will be thrown away when
the actual arguments are parsed.

To do this some other general refactoring was needed:
- more methods made private when possible
- e.g. `HEAD?` used consistently instead of `head` before arguments
  are parsed.
- formula options are only parsed after named arguments are extracted
2020-05-05 17:47:51 +01:00
Mike McQuaid
a5a5a1a83a
Merge pull request #7510 from MikeMcQuaid/disable-rspec-filepath
rubocop_rspec: disable RSpec/FilePath.
2020-05-05 16:17:54 +01:00
Mike McQuaid
60c9472b14
rubocop_rspec: disable RSpec/FilePath.
We keep adding to the list of exceptions and this fails if it isn't run
in the right directory.
2020-05-05 15:50:10 +01:00
Mike McQuaid
316da98140
Merge pull request #7503 from Bo98/since-fix
os/mac/software_spec: fix argument error in valid  use case
2020-05-05 09:10:33 +01:00
Mike McQuaid
34978edd90
Merge pull request #7460 from vidusheeamoli/port-keg-only-rubocop
audit: Port audit_keg_only to RuboCop and add tests
2020-05-05 09:05:18 +01:00
Mike McQuaid
8e318d81bc
formula: add pkgetc method.
This should provide a more "type-safe" way of referring to the `etc`
directories of other formulae e.g.
https://github.com/Homebrew/homebrew-core/pull/54257 so that the output
will change if the formula name changes.
2020-05-05 08:34:07 +01:00
vidusheeamoli
f851688541 audit: Port audit_keg_only to rubocop and add tests
audit: add test

audit: fixed test

audit: added another test case

audit: fix test

audit: fix test

audit: fix keg only
2020-05-05 10:47:49 +05:30
Shaun Jackman
e10e955525
Merge pull request #7506 from sjackman/docker
docker.yml: Set persist-credentials: false
2020-05-04 16:46:18 -07:00
Shaun Jackman
f4e32ebcb1 docker.yml: Set persist-credentials: false 2020-05-04 16:16:18 -07:00
Shaun Jackman
6065dd1f1a
Merge pull request #7504 from sjackman/docker-hub
docker.yml: Fix a typo
2020-05-04 15:27:25 -07:00
Shaun Jackman
3a9e12efac docker.yml: Fix a typo 2020-05-04 15:00:36 -07:00
Shaun Jackman
b06a7af604
Merge pull request #7494 from sjackman/docker-hub
docker.yml: Deploy the tagged image to Docker Hub
2020-05-04 12:57:33 -07:00
Shaun Jackman
305ecfd66e docker.yml: Deploy tagged image to Docker Hub 2020-05-04 12:34:59 -07:00
Bo Anderson
16141e7eff os/mac/software_spec: fix argument error in valid use case 2020-05-04 17:16:39 +01:00
Mike McQuaid
e1f3b0b971
Merge pull request #7500 from MikeMcQuaid/deps_args_spec
deps_spec: check args.
2.2.15
2020-05-04 13:28:13 +01:00
Mike McQuaid
b73beaba91
Merge pull request #7502 from MikeMcQuaid/cmdline_args_trim
cli: readability improvements.
2020-05-04 13:04:39 +01:00
Mike McQuaid
f567302ebf
deps_spec: check args. 2020-05-04 12:59:56 +01:00
Mike McQuaid
9324a85955
cli: readability improvements.
- Rename `cmdline_args` to `argv` to make it more obvious where they
  come from.
- Make the `if args_parsed` early return into `unless args_parsed` to
  (hopefully) make it clearer that this is not the "normal" case and
  to not check `argv` unless arguments haven't been parsed.
2020-05-04 12:42:29 +01:00
Mike McQuaid
ee108f5b26
Merge pull request #7499 from Homebrew/revert-7490-argv-cleanup-25
Revert "ARGV: Deprecate ARGV.flags_only and replace with Homebrew.args.flags_only"
2020-05-04 11:56:16 +01:00
Mike McQuaid
ae353ff42e
Revert "ARGV: Deprecate ARGV.flags_only and replace with Homebrew.args.flags_only" 2020-05-04 11:12:25 +01:00
Mike McQuaid
53fe2c94db
Merge pull request #7495 from Homebrew/dependabot/bundler/Library/Homebrew/rspec-support-3.9.3
build(deps): bump rspec-support from 3.9.2 to 3.9.3 in /Library/Homebrew
2020-05-04 08:56:05 +01:00
Mike McQuaid
dcd48b0357
Merge pull request #7496 from Homebrew/dependabot/bundler/Library/Homebrew/rspec-core-3.9.2
build(deps): bump rspec-core from 3.9.1 to 3.9.2 in /Library/Homebrew
2020-05-04 08:55:47 +01:00
dependabot-preview[bot]
417bdca22d
build(deps): bump rspec-core from 3.9.1 to 3.9.2 in /Library/Homebrew
Bumps [rspec-core](https://github.com/rspec/rspec-core) from 3.9.1 to 3.9.2.
- [Release notes](https://github.com/rspec/rspec-core/releases)
- [Changelog](https://github.com/rspec/rspec-core/blob/master/Changelog.md)
- [Commits](https://github.com/rspec/rspec-core/compare/v3.9.1...v3.9.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-04 05:59:23 +00:00
dependabot-preview[bot]
35869b917d
build(deps): bump rspec-support from 3.9.2 to 3.9.3 in /Library/Homebrew
Bumps [rspec-support](https://github.com/rspec/rspec-support) from 3.9.2 to 3.9.3.
- [Release notes](https://github.com/rspec/rspec-support/releases)
- [Changelog](https://github.com/rspec/rspec-support/blob/master/Changelog.md)
- [Commits](https://github.com/rspec/rspec-support/compare/v3.9.2...v3.9.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-04 05:58:51 +00:00
Mike McQuaid
9befd55d5e
Merge pull request #7492 from Bo98/docker-fix
Dockerfile: restore git-core PPA
2020-05-03 14:49:31 +01:00
Bo Anderson
5935da6c6c Dockerfile: restore git-core PPA 2020-05-03 14:29:09 +01:00
Mike McQuaid
9e5932c214
Merge pull request #7485 from MikeMcQuaid/formula_cellar_check_plist
formula_cellar_checks: check plist.
2020-05-03 14:21:21 +01:00
Mike McQuaid
c5267f1c75
formula_cellar_checks: check plist.
Check plists so https://github.com/Homebrew/homebrew-services/issues/219 does not occur.
2020-05-03 13:59:08 +01:00
Mike McQuaid
92f26e991c
Merge pull request #7490 from GauthamGoli/argv-cleanup-25
ARGV: Deprecate ARGV.flags_only and replace with Homebrew.args.flags_only
2020-05-03 13:41:07 +01:00
Mike McQuaid
6175f477bb
Merge pull request #7456 from sjackman/docker
Build Docker images for Ubuntu 18.04 and 20.04
2020-05-03 13:40:14 +01:00