20657 Commits

Author SHA1 Message Date
Mike McQuaid
0404ce21f2
Merge pull request #7464 from Homebrew/dependabot/bundler/Library/Homebrew/parser-2.7.1.2
build(deps): bump parser from 2.7.1.1 to 2.7.1.2 in /Library/Homebrew
2020-04-30 09:53:31 +01:00
dependabot-preview[bot]
5feffaccc7
build(deps): bump parser from 2.7.1.1 to 2.7.1.2 in /Library/Homebrew
Bumps [parser](https://github.com/whitequark/parser) from 2.7.1.1 to 2.7.1.2.
- [Release notes](https://github.com/whitequark/parser/releases)
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/whitequark/parser/compare/v2.7.1.1...v2.7.1.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-30 05:38:51 +00:00
Mike McQuaid
e8a29a2d72
Merge pull request #7440 from FTLam11/FTLam11-#7432-add-json-option-to-brew-cask-outdated
Add JSON support for brew cask outdated, fixes #7432
2020-04-29 11:40:22 +01:00
Frank Lam
682914bf40
Improve readability of guard clause
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-04-29 18:16:39 +08:00
Mike McQuaid
fdc5096e09
Merge pull request #7461 from herder/shell_detection
[fix] Improve shell detection in shellenv
2020-04-29 10:00:12 +01:00
Mike McQuaid
855d639b81
Merge pull request #7462 from MikeMcQuaid/deprecate-before-disabled
formula: disable! deprecates before disable date.
2020-04-29 09:57:05 +01:00
Mike McQuaid
04a64bb724
formula: disable! deprecates before disable date.
This makes more sense to me; if we expect a formula will be disabled at
a given point in the future then we should deprecate it immediately.
2020-04-29 09:34:40 +01:00
Niklas Herder
2f4d4b8684
[fix] Improve shell detection in shellenv
$SHELL is set to only the binary name in some environments (e.g. fish, not /usr/bin/fish), causing detection of fish/csh/tsch to fail without this change.
2020-04-29 08:20:06 +02:00
Mike McQuaid
d48d1e5e2c
Merge pull request #7455 from EricFromCanada/bash-command-completion
completions/bash: complete names of commands
2020-04-28 09:15:52 +01:00
Mike McQuaid
e2bc0fa687
Merge pull request #7453 from bayandin/mirror-use-bintray
dev-cmd/mirror: use Bintray wrapper
2.2.14
2020-04-28 08:59:19 +01:00
Frank Lam
9a605a1dd6
Refactor Cask#outdated_info 2020-04-28 12:21:51 +08:00
EricFromCanada
0dc177d649 completions/bash: complete names of commands 2020-04-27 18:32:12 -04:00
Alexander Bayandin
cc799b1f31 dev-cmd/mirror: switch to Bintray wrapper 2020-04-27 23:17:25 +01:00
Alexander Bayandin
a34e0c1893 bintray: discard unused output from curl 2020-04-27 20:25:11 +01:00
Mike McQuaid
223b66bcdc
Merge pull request #7451 from claui/fix-cask-loading-this-time-for-real
Cask loader: add missing canonicalisation
2020-04-27 16:19:01 +01:00
Mike McQuaid
e02a3ba145
Merge pull request #7450 from Bo98/expat-pc
os/mac/pkgconfig: add expat.pc
2020-04-27 14:32:59 +01:00
Claudia
b8aa808b9d
Make sure DEFAULT_DIRS values are Pathnames
This commit fixes the PR #7417 bug.

The call to `canonicalize` needs to wrap `DEFAULT_DIRS`, not the
other way around. This was mixed up in PR #7417 due to an oversight.
2020-04-27 15:25:28 +02:00
Bo Anderson
a016d65424 os/mac/pkgconfig: add expat.pc 2020-04-27 14:10:44 +01:00
Claudia
c85df70757
Fix flaw in Cask test helper
This commit fixes a flaw in the Cask test helper, causing the broken `Cask::Config` test to actually fail.

The flaw occurred while patching the `Cask::Config::DEFAULT_DIRS` hash.
While the original hash uses strings as values, the patched one used
`Pathname` values, masking a broken `Cask::Config::from_json` test.

Now the broken test fails like it should.
2020-04-27 15:09:36 +02:00
Claudia
cad8be3278
Add broken test, revealing test helper flaw
This commit adds a broken test, which is meant to expose a flaw in the
constructor of `Cask::Config`.

That (broken) test still passes because there’s also a flaw in our
test helper code.

The helper flaw happens to neutralize the `Cask::Config` flaw.
2020-04-27 15:00:22 +02:00
Claudia
dd3267ece0
Add test for JSON-based cask config loader
Previously, the JSON-based cask config loader was untested.
This commit changes the interface to accept a string, making the loader
easier to test. The commit also adds a test.
2020-04-27 14:54:56 +02:00
Mike McQuaid
efef0087a6
Merge pull request #7448 from MikeMcQuaid/actions-cache-gems
workflows/tests: cache RubyGems.
2020-04-27 11:50:01 +01:00
Mike McQuaid
37d87e3fa3
workflows/tests: cache RubyGems.
This should save about a minute for each CI run.
2020-04-27 11:31:21 +01:00
Bo Anderson
2c64eab710
Merge pull request #7442 from Bo98/ncurses-pc
os/mac/pkgconfig: add ncurses.pc & ncursesw.pc
2020-04-27 10:39:27 +01:00
Mike McQuaid
1a51b3e41b
Merge pull request #7443 from Bo98/libedit-pc
os/mac/pkgconfig: add libedit.pc
2020-04-27 08:41:04 +01:00
Mike McQuaid
ba5d1ef796
Merge pull request #7445 from Bo98/libffi-pc
os/mac/pkgconfig: add libffi.pc
2020-04-27 08:40:28 +01:00
Mike McQuaid
b33c823111
Merge pull request #7417 from claui/fix-cask-loading
Fix cask loading after adding an artifact type
2020-04-27 08:40:19 +01:00
Mike McQuaid
8c681d836b
Merge pull request #7441 from bayandin/bump-revision-stable-do
bump-revision: re-apply proper fix for handling stable block
2020-04-27 08:39:44 +01:00
Mike McQuaid
5618b9c53b
Merge pull request #7446 from Bo98/hombrew
cmd/list: fix Hombrew typo
2020-04-27 08:37:55 +01:00
Mike McQuaid
2575d137d8
Merge pull request #7447 from Homebrew/dependabot/bundler/Library/Homebrew/mime-types-data-3.2020.0425
build(deps): bump mime-types-data from 3.2019.1009 to 3.2020.0425 in /Library/Homebrew
2020-04-27 08:30:08 +01:00
dependabot-preview[bot]
00ae9f5a2e
build(deps): bump mime-types-data in /Library/Homebrew
Bumps [mime-types-data](https://github.com/mime-types/mime-types-data) from 3.2019.1009 to 3.2020.0425.
- [Release notes](https://github.com/mime-types/mime-types-data/releases)
- [Changelog](https://github.com/mime-types/mime-types-data/blob/master/History.md)
- [Commits](https://github.com/mime-types/mime-types-data/compare/v3.2019.1009...v3.2020.0425)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-27 06:01:38 +00:00
Bo Anderson
95f226cf51 cmd/list: fix Hombrew typo 2020-04-27 00:47:24 +01:00
Bo Anderson
c7120f1cfb os/mac/pkgconfig: add libffi.pc 2020-04-26 23:26:16 +01:00
Bo Anderson
c49c21faa3 os/mac/pkgconfig: add libedit.pc 2020-04-26 22:10:20 +01:00
Bo Anderson
29c121be98 os/mac/pkgconfig: add ncurses.pc & ncursesw.pc 2020-04-26 21:38:44 +01:00
EricFromCanada
5a4a57310f bump-revision: insert after homepage if stable block is present 2020-04-26 15:13:34 +01:00
Alexander Bayandin
7ba0f34f72 Revert "Merge pull request #7316 from bayandin/fix-bump-revision"
This reverts commit a7fdc7046f5cda8743591040117e409cd24dae76, reversing
changes made to bfa175d118112989b24908ea16c5a97c1dd011e4.
2020-04-26 15:11:31 +01:00
Frank Lam
dabbfe3e3e
Fix linter offenses 2020-04-26 21:31:21 +08:00
Mike McQuaid
bdc7ebf3c7
Merge pull request #7434 from GauthamGoli/argv-cleanup-22
ARGV: Deprecate ARGV.build_bottle? and replace with Homebrew.args.build_bottle
2020-04-26 14:14:35 +01:00
Frank Lam
f2fa2c5d30
Add JSON support to brew cask outdated
* brew outdated already has JSON support, now users and tools can get
similar results with brew cask outdated --json
2020-04-26 21:13:19 +08:00
Frank Lam
65ff9155f8
Add Cask#outdated_info to format output 2020-04-26 21:07:42 +08:00
Mike McQuaid
7b48dd59b0
Merge pull request #7438 from atetubou/create_completion
completions/bash: add flags for create
2020-04-26 13:56:55 +01:00
Mike McQuaid
193f2c09fa
Merge pull request #7435 from bayandin/patch-2
bintray: fix package creation for verbose output
2020-04-26 13:40:27 +01:00
Mike McQuaid
3911ff4080
Merge pull request #7433 from issyl0/lint-dockerfile
Lint the homebrew/brew Dockerfile with `hadolint`
2020-04-26 13:39:09 +01:00
Mike McQuaid
a7fdc7046f
Merge pull request #7316 from bayandin/fix-bump-revision
bump-revision: fix handling formula with stable block
2020-04-26 13:31:45 +01:00
Gautham G
b0ac5bab31
ARGV: Deprecate ARGV.build_bottle? and replace with Homebrew.args.build_bottle 2020-04-26 13:28:44 +01:00
tikuta
c6545687ea completions/bash: add flags for create
Sorts flags also.
2020-04-26 21:25:07 +09:00
Alexander Bayandin
1d7ed982ec bintray: force curl to fail on server errors 2020-04-26 10:03:32 +01:00
Issy Long
785f3ab464
Dockerfile: Tabs to spaces
- My editor converted some of these to spaces when I changed the lines
  in the previous commit. We should be consistent, so I made all of them
  into spaces.
2020-04-26 09:55:14 +01:00
Issy Long
9baebbe38a
Lint the homebrew/brew Dockerfile with hadolint
- I suggested this for the contents of
  [Linuxbrew/docker](https://github.com/Linuxbrew/docker) in
  https://github.com/Linuxbrew/docker/issues/75. People agreed, and
  Shaun asked me to do the same here.
- This adds a step to CI to lint the Dockerfile, via
  [hadolint](https://github.com/hadolint/hadolint), on Ubuntu.
- The linting errors it surfaced on this Dockerfile were:

```
Dockerfile:4 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
Dockerfile:30 DL3020 Use COPY instead of ADD for files and folders
Dockerfile:32 DL3003 Use WORKDIR to switch to a directory
```

- [DL3008](https://github.com/hadolint/hadolint/wiki/DL3008) - pinning
  versions in `apt-get install` - is at odds with what we recommend in the
  normal Homebrew on Linux dependency install instructions. We don't
  want the dependency management of having to check each of these
  Dockerfiles periodically for the latest version numbers of packages
  and have to update them. So I've disabled this lint.

- [DL3003](https://github.com/hadolint/hadolint/wiki/DL3003) - use
  WORKDIR to `cd` - is disabled in this case due to [review
  comments](https://github.com/Homebrew/brew/pull/7433/files#r415098255).
2020-04-26 09:54:36 +01:00