8545 Commits

Author SHA1 Message Date
Martin Afanasjew
02cd2c899a bottle: fix Ruby 1.8 breakage
`OpenStruct` (of which `Tab` is a subclass) doesn't support subscripting
with square brackets. Use normal dot notation to restore compatibility.
2015-12-16 02:12:50 +01:00
Mike McQuaid
b0e39203fe bottle: don't use empty tab. 2015-12-15 17:05:24 +00:00
Baptiste Fontaine
50f94e5233 audit: don't fail if there's no tap
Closes Homebrew/homebrew#47041.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-12-15 15:52:05 +01:00
Mike McQuaid
214c865167 bottle: make bottle checksums reproducible.
I've set all the variable data to versions that are dependent on the
latest source file date and various modification dates also to the
latest source file date. With this if you rerun `brew bottle`
multiple times in a row you will see the same checksum even if you have
`brew reinstall`ed (as long as upstream does not hardcode e.g. the
build date).

I debugged this with diffoscope and worked on this as part of the
Athens 2015 reproducible builds workshop:
https://reproducible-builds.org/events/athens2015/

Closes Homebrew/homebrew#46587.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-12-15 14:24:18 +00:00
Mike McQuaid
e5ba31fcdc Allow multiple option_names in dep/reqs.
This means that dependencies can be merged but still maintain all
their option names.

Closes Homebrew/homebrew#46916.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-12-15 08:37:16 +00:00
Mike McQuaid
484c70d19f test_dependency: add failing option names test.
This test will obviously fail but it does mark that the option names
are not being merged correctly.
2015-12-15 08:37:16 +00:00
Mike McQuaid
7095378b31 Add option_name tests. 2015-12-15 08:37:16 +00:00
Martin Afanasjew
a4a2b305f2 formula_installer: prefer 'Dependable#run?'
Both `req.tags.include?(:run)` and `req.run?` are currently equivalent,
but the latter relies less on implementation details.
2015-12-15 05:36:05 +01:00
Baptiste Fontaine
f1ac9b5776 pretty_duration: fixed for int arguments
Without this the returned string is not as accurate if the method is
called with an int larger than 120.

Closes Homebrew/homebrew#47002.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-12-14 16:34:12 +01:00
Baptiste Fontaine
9127ee1928 plural: tests added 2015-12-14 15:01:31 +01:00
Baptiste Fontaine
fedbb06278 os/mac: indent fixes 2015-12-14 13:50:00 +01:00
Alex Dunn
af77e8b380 Formulary: explicitly require tap
Fixes Homebrew/homebrew#46984.
2015-12-13 20:19:53 -08:00
Martin Afanasjew
b0b5d22af1 man: modernize and reduce code duplication
Also use `popen_read` instead of `safe_system` for cleaner argument
passing and write the output with `atomic_write`.

Closes Homebrew/homebrew#46826.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2015-12-13 22:18:27 +01:00
Martin Afanasjew
4a89cfb1dc man: remove broken --verbose functionality 2015-12-13 22:18:26 +01:00
Martin Afanasjew
9789726fff update: make stashing local changes more robust
Users with local changes and without a configured Git identity won't be
able to update Homebrew via `brew update`, as the update will fail when
trying to stash the local modifications with `git stash`. They will be
unable to proceed until they follow Git's advice to configure their
identity or they manage to revert their local changes.

This change always sets a commit e-mail and name, avoiding this issue. A
nice bonus is that experienced Git users can see who created the stash
commit (identifying `brew update` as the author).

Fixes Homebrew/homebrew#46930.

Closes Homebrew/homebrew#46939.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2015-12-13 22:18:14 +01:00
Martin Afanasjew
18bf5a74a8 cleanup: consistently document --dry-run option
All other commands document both `--dry-run` and `-n` in the option
description and mention only `--dry-run` in the command summary. Let's
do the same for `cleanup`.

Closes Homebrew/homebrew#46942.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2015-12-13 02:20:02 +01:00
Xu Cheng
3cc101ec5e pull: use tap object
Fix the regression introduced by Homebrew/homebrew#46735.
2015-12-13 01:29:52 +08:00
Mike McQuaid
c347d40f1b test-bot: allow tapuser/taprepo/tapformula format. 2015-12-11 20:16:05 +00:00
Xu Cheng
71e023a2c6 test-bot: fix resolve_test_tap 2015-12-11 21:46:02 +08:00
Xu Cheng
43713afa5f test-bot: remove dead code 2015-12-11 17:14:51 +08:00
Mike McQuaid
d48bdcdabb test-bot: remove ci-reset-and-update. 2015-12-11 08:48:59 +00:00
Xu Cheng
5773ca64c5 test-bot: fix Bintray url for bottle uploading 2015-12-11 16:19:51 +08:00
Mike McQuaid
65b197d2e0 test-bot: fix tap URL detection from Jenkins. 2015-12-11 08:10:59 +00:00
Mike McQuaid
e3dcf7776a Revert "test-bot: remove dead code."
This reverts commit 373da8666e633b06d8a5bb98621461b700f4b2d7.
2015-12-11 08:08:51 +00:00
Dominyk Tiller
5b98a6c67d xcode.md: document xcode 7.2
Closes Homebrew/homebrew#46822.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2015-12-10 14:27:02 +00:00
Dominyk Tiller
50dc5f7a3d os/mac/xcode: expect xcode 7.2 2015-12-10 14:27:02 +00:00
Dominyk Tiller
6b42a0c1f5 os/mac: add xcode 7.2 2015-12-10 14:27:02 +00:00
Anton Danilchenko
7c78f76d16 Troubleshooting: fixed typo
Closes Homebrew/homebrew#46867.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2015-12-10 14:18:34 +00:00
Martin Afanasjew
233a38ac95 brew.rb: improve handling of --version/-v option
Make both `--version` and `-v` print the Homebrew version and exit, if
provided as first and sole argument. `brew --version` no longer accepts
additional arguments (they were previously ignored). Otherwise interpret
`brew -v <arguments>` as if `brew <arguments> -v` was executed instead
(no change here), but no longer print a line with the Homebrew version.

Closes Homebrew/homebrew#46790.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2015-12-10 15:01:59 +01:00
Martin Afanasjew
85181a067f manpage: remove superfluous spaces for consistency
All other alternatives already don't use spaces around the pipe symbol.

Closes Homebrew/homebrew#46825.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2015-12-10 15:00:36 +01:00
Martin Afanasjew
8144f90eac manpage: fix formatting of command list
Restore definition list in `COMMANDS` section, thus massively improve
formatting. In theory, `ronn` supports nested (definition) lists. In
practice, this does not work (and is unlikely to be fixed soon because
upstream seems to be rather inactive) causing the entire definition list
to be longer recognized because of a single nested list. Work around by
rearranging the `tap` documentation (sole command with a nested list).
2015-12-10 15:00:36 +01:00
Mike McQuaid
4b3056e2fc test-bot: fetch/audit formulae despite requirement
It's still useful to do a basic test even if requirements cannot be
satisfied.
2015-12-10 10:43:45 +00:00
Mike McQuaid
d2a44869f0 test-bot: remove dead code. 2015-12-10 10:43:45 +00:00
Ryan Hendrickson
8ce81af67a ENV: warn_if_universal_binaries_not_supported
Raise an error when attempting to create universal binaries with a GCC
that can't do so.

Closes Homebrew/homebrew#46630.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-12-10 11:23:11 +01:00
Josh Hagins
d5de719c2b Do not brew install brew-cask
Refs caskroom/homebrew-cask#15381

Closes Homebrew/homebrew#46845.
2015-12-10 09:32:53 +00:00
Mike McQuaid
6d384a730f brew: cask is now a tap command.
So we can remove the formula installation from `brew.rb`.

Closes Homebrew/homebrew#46843.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-12-10 09:31:39 +00:00
Robert Eshleman
6d1959b265 Remove Git Conflict Markers in Documentation
`Formula-Cookbook.md` contains leftover git conflict markers introduced
in 15f291ddaa05cc010456a733b799382175c29dd4.

This commit removes the conflict makers and a duplicated paragraph.

Closes Homebrew/homebrew#46836.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-12-09 15:31:02 +00:00
Baptiste Fontaine
48b39ba1e7 audit: flag '--with{,out}-check' options
Closes Homebrew/homebrew#46794.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-12-09 11:29:47 +01:00
Mike McQuaid
d36d88edf2 Allow taps to link manpages.
A blocker for https://github.com/caskroom/homebrew-cask/pull/15381
being merged.

Closes Homebrew/homebrew#46795.
2015-12-09 09:09:26 +00:00
Xu Cheng
ed35c18fcf test-tab: tap is a Tap object now
Closes Homebrew/homebrew#46735.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-12-09 16:57:00 +08:00
Xu Cheng
fe032e3e96 avoid using FORMULA_RENAMES directly 2015-12-09 16:56:59 +08:00
Xu Cheng
571011ad59 migrator: tap is a Tap object now 2015-12-09 16:56:59 +08:00
Xu Cheng
c796198398 formula_versions: tap is a Tap object now 2015-12-09 16:56:59 +08:00
Xu Cheng
9a384f5134 exceptions: tap is a Tap object now 2015-12-09 16:56:59 +08:00
Xu Cheng
62a623f0c3 info: tap is a Tap object now 2015-12-09 16:56:59 +08:00
Xu Cheng
d948ec231d audit: tap is a Tap object now 2015-12-09 16:56:59 +08:00
Xu Cheng
8b510f82c4 bottles: tap is a Tap object now 2015-12-09 16:56:59 +08:00
Xu Cheng
b100ad223d Tap#==: allow compare with string 2015-12-09 16:56:59 +08:00
Xu Cheng
72f4323ea5 Tab#tap: returns tap object 2015-12-09 16:56:59 +08:00
Xu Cheng
5debd5b132 Formula#tap: returns tap object 2015-12-09 16:56:59 +08:00