nandahkrishna
8e5451df2f
style: use parentheses for assignment in conditions
2021-02-12 18:33:37 +05:30
Mike McQuaid
e8c71aeb8c
rubocops/lines: check for if ENV["CI"]
usage.
...
Suggested in:
https://github.com/Homebrew/homebrew-core/pull/70675#issuecomment-775092539
2021-02-12 11:25:44 +00:00
Michka Popoff
865fb15ad7
on_os block: allow to contain conflicts_with
...
Some conflicts are os-specific.
2021-02-08 13:27:04 +01:00
Rylan Polster
5f57601fd8
style: re-enable bottle order cop
2021-02-04 17:18:20 -05:00
Carlo Cabrera
2de172e050
rubocops/bottle: disable bottle order check
...
This is causing CI failures at homebrew/core [1], so let's disable this
for now.
[1] 01b6830646
2021-02-04 11:18:09 +00:00
Seeker
4c42d717fd
rubocops: add cops to check bottle format, indentation, and order
...
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
Co-authored-by: Seeker <meaningseeking@protonmail.com>
2021-02-03 20:46:20 -05:00
Mike McQuaid
d6957a3acb
Homebrew 3.0.0 deprecations/disables
2021-01-29 19:50:24 +00:00
Michka Popoff
38ae6e0c0d
style: re-enable sha256 checks for bottle blocks
...
Follow up PR to #10450
2021-01-28 20:35:31 +01:00
Michka Popoff
b87c23bb7e
style: do not fail on sha256 lines with cellar information
...
Fixes:
1-01-28T17:17:10.7152456Z [31m==>[0m [1m[31mFAILED[0m[0m
2021-01-28T17:17:10.7163169Z [36mFormula/dhall-json.rb[0m:14:12: [33mC[0m: sha256 should be 64 characters
2021-01-28T17:17:10.7175011Z sha256 cellar: :any_skip_relocation, big_sur: "a1e0cb4f7e4a7e0994b43ecd783240356631d36655cfbf59a903cc3f6a799242"
2021-01-28T17:17:10.7176620Z ^^^^^^
2021-01-28T17:17:10.7178131Z [36mFormula/dhall-json.rb[0m:14:15: [33mC[0m: sha256 contains invalid characters
2021-01-28T17:17:10.7179886Z sha256 cellar: :any_skip_relocation, big_sur: "a1e0cb4f7e4a7e0994b43ecd783240356631d36655cfbf59a903cc3f6a799242"
2021-01-28T17:17:10.7181198Z ^^
2021-01-28T17:17:10.7182390Z [36mFormula/dhall-json.rb[0m:15:12: [33mC[0m: sha256 should be 64 characters
2021-01-28T17:17:10.7183801Z sha256 cellar: :any_skip_relocation, catalina: "050f219d8050cf46a54487e0cad414374a5d2b4a6422d1e2e2c7a682149c3afb"
2021-01-28T17:17:10.7184956Z ^^^^^^
2021-01-28T17:17:10.7186016Z [36mFormula/dhall-json.rb[0m:15:15: [33mC[0m: sha256 contains invalid characters
2021-01-28T17:17:10.7187458Z sha256 cellar: :any_skip_relocation, catalina: "050f219d8050cf46a54487e0cad414374a5d2b4a6422d1e2e2c7a682149c3afb"
2021-01-28T17:17:10.7188630Z ^^
2021-01-28 18:27:21 +01:00
EricFromCanada
a427de5bee
capitalization fixes
...
"curl" is the binary, while "cURL" is the umbrella project.
2021-01-26 15:36:44 -05:00
Seeker
5c3dec6476
rubocops: move some methods from FormulaCop to HelperFunctions
2021-01-15 10:15:11 -08:00
Seeker
33edb9f901
rubocops: point to offending OS-specific block in resource blocks
2021-01-13 23:18:32 -08:00
Jonathan Chang
641afdd2de
rubocops: permit mirror
in OS-specific resources
2021-01-14 17:04:40 +11:00
Jonathan Chang
ac8eb00443
rubocops/cask/*: use rubocop v1 API
2021-01-12 19:16:38 +11:00
Jonathan Chang
30f7a872b5
rubocops/unless_multiple_conditions: use rubocop v1 API
2021-01-12 19:16:38 +11:00
Jonathan Chang
23b8d0ccb8
rubocops/desc: use rubocop v1 API
2021-01-12 19:16:38 +11:00
Jonathan Chang
929e481dce
rubocops/keg_only: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
df8e030174
rubocops/patches: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
c3f797d9ac
rubocops/components_order: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
f57c96465c
rubocops/conflicts: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
92e07f5c0b
rubocops/homepage: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
63bebf542f
rubocops/dependency_order: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
986f5dac0d
rubocops/livecheck: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
a778dc3bdb
rubocops/class: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
3bda457478
rubocops/text: use rubocop v1 API
2021-01-12 19:11:43 +11:00
Jonathan Chang
c18ffa84ca
rubocops/deprecate_disable: use rubocop v1 API
2021-01-12 19:11:42 +11:00
Jonathan Chang
9046d778e0
rubocops/checksum: use rubocop v1 API
2021-01-12 19:11:42 +11:00
Jonathan Chang
b8fb568021
rubocops/lines: use rubocop v1 API
2021-01-12 19:11:42 +11:00
Jonathan Chang
f81e89193e
rubocops: update helpers for rubocop v1 API
2021-01-12 19:11:42 +11:00
Jonathan Chang
5844fc4f00
Merge pull request #10255 from iMichka/netcat
...
uses_from_macos: add netcat
2021-01-09 19:44:10 +11:00
Seeker
2a80427755
unless_multiple_conditions: add autocorrect
2021-01-08 10:33:56 -08:00
Seeker
b9854bd4cf
rubocops: add unless_multiple_conditions
2021-01-08 10:33:54 -08:00
Seeker
332778025a
utils/ast: add Sorbet method signatures
2021-01-07 13:54:05 -08:00
Michka Popoff
5329972955
uses_from_macos: add netcat
2021-01-07 22:27:15 +01:00
Mike McQuaid
051fba341f
rubocops/homepage: don't attempt to auto-correct an empty string.
...
Fixes #10232
2021-01-06 13:53:15 +00:00
Mike McQuaid
dad7dc6a14
Merge pull request #10196 from souleater7/delete-devel
...
Delete references to devel
2021-01-06 09:15:52 +00:00
Michka Popoff
e0b6f4d816
gperf: add to uses_from_macos allowlist
2021-01-02 23:21:14 +01:00
souleater7
e50e3e4b22
Delete references to devel
2021-01-01 10:16:31 -08:00
Mike McQuaid
7ab50ef6f6
rubocops/homepage: fix frozen string error.
2020-12-31 13:30:24 +00:00
Seeker
4924b7633c
components_order: allow if-else statements inside on_os blocks
...
Co-Authored-By: Rylan Polster <rslpolster@gmail.com>
2020-12-23 19:28:11 -05:00
Rylan Polster
27ce5754c9
style: fix on_macos/on_linux resource block checks
2020-12-23 17:04:24 -05:00
Mike McQuaid
87dd13aea6
Deprecate cask requirements.
...
This probably has to wait until 2.7.0 now and will require a bunch of
formula changes/deprecations but we should probably start moving in this
direction given we're not installing any of these on our CI any more.
2020-12-15 14:19:45 +00:00
Sam Ford
ad544e465d
Add livecheck group to cask stanza order
2020-12-12 17:43:25 -05:00
Seeker
85373df30e
Merge pull request #9095 from SeekingMeaning/bottle-ast
...
bottle: add bottle stanza by traversing AST
2020-12-11 09:05:14 -08:00
Seeker
b8aa67be5b
bottle: add bottle stanza by traversing AST
2020-12-10 13:38:57 -08:00
Seeker
c4da302303
on_macos/on_linux block: improve rubocop message
...
Co-authored-by: Markus Reiter <me@reitermark.us>
2020-12-10 11:47:25 -08:00
Seeker
5a643ff0db
on_macos/on_linux block: fix rubocop for special cases
2020-12-08 14:33:47 -08:00
Rylan Polster
01cf98e526
Remove style exceptions for ProvidedByMacos and UsesFromMacos
2020-12-03 14:30:34 -05:00
Rylan Polster
78060765b2
rubcops/provided_by_macos: fix wording for core formulae
2020-12-02 21:19:17 -05:00
Rylan Polster
f450bfbf5e
style: migrate some lists back to Homebrew/brew
2020-12-02 20:56:07 -05:00