admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #2482 from MikeMcQuaid/audit-dependency-options

Browse Source 
audit: ensure default dependencies don't use options.
This commit is contained in:
Mike McQuaid 2017-04-22 11:07:16 +01:00 committed by GitHub
commit fdcffb25a9
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/dev-cmd/audit.rb
View File

@ -1031,11 +1031,15 @@ class FormulaAuditor
end
if line =~ /depends_on :tex/
problem ":tex is deprecated."
problem ":tex is deprecated"
end
if line =~ /depends_on\s+['"].+['"]\s+=>\s+:(lua|perl|python|ruby)(\d*)/
problem "Formulae should vendor #{$1} modules rather than use `depends_on ... => :#{$1}#{$2}`."
if line =~ /depends_on\s+['"](.+)['"]\s+=>\s+:(lua|perl|python|ruby)(\d*)/
problem "#{$2} modules should be vendored rather than use deprecated `depends_on \"#{$1}\" => :#{$2}#{$3}`"
end
if line =~ /depends_on\s+['"](.+)['"]\s+=>\s+.*['"](.+)['"]/
problem "Dependency #{$1} should not use option #{$2}"
end
# Commented-out depends_on