Merge pull request #2479 from MikeMcQuaid/audit-new-formula-patches

audit: new formulae should not require patches.
2017-04-22 11:06:27 +01:00 · 2017-04-22 11:06:27 +01:00 · 96ea97967a
commit 96ea97967a
parent 6e1faf5b88 1775c32210
1 changed files with 3 additions and 0 deletions
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@ -732,7 +732,10 @@ class FormulaAuditor
        }
      end

+      next if spec.patches.empty?
      spec.patches.each { |p| patch_problems(p) if p.external? }
+      next unless @new_formula
+      problem "New formulae should not require patches to build. Patches should be submitted and accepted upstream first."
    end

    %w[Stable Devel].each do |name|