remove unnecessary explicit return val

This commit is contained in:
Elizabeth Tackett 2020-06-29 09:33:24 -05:00
parent 5d9d0bb284
commit f82da9009f
2 changed files with 7 additions and 9 deletions

View File

@ -120,8 +120,7 @@ module Utils
puts "==============Formatted outdated packages============\n" puts "==============Formatted outdated packages============\n"
outdated_packages.each do |package_name, package_details| outdated_packages.each do |package_name, package_details|
puts "" puts "\nFormula: #{package_name}"
puts "Formula: #{package_name}"
puts "Current formula version: #{package_details['homebrew_version']}" puts "Current formula version: #{package_details['homebrew_version']}"
puts "Repology latest version: #{package_details['repology_version']}" puts "Repology latest version: #{package_details['repology_version']}"
puts "Livecheck latest version: #{package_details['livecheck_latest_version']}" puts "Livecheck latest version: #{package_details['livecheck_latest_version']}"

View File

@ -1,7 +1,7 @@
require "open3" require "open3"
class BrewCommands class BrewCommands
def livecheck_check_formula(formula_name) def livecheck_check_formula(formula_name)
puts "- livecheck formula : #{formula_name}" puts "- livecheck formula : #{formula_name}"
command_args = [ command_args = [
@ -20,7 +20,7 @@ class BrewCommands
# eg: ["burp", "2.2.18", "2.2.18"] # eg: ["burp", "2.2.18", "2.2.18"]
package_name, brew_version, latest_version = livecheck_output package_name, brew_version, latest_version = livecheck_output
{'name' => package_name, 'current_brew_version' => brew_version, 'livecheck_latest_version' => latest_version} {'name' => package_name, 'current_brew_version' => brew_version, 'livecheck_latest_version' => latest_version}
end end
@ -40,7 +40,7 @@ class BrewCommands
def parse_formula_bump_response(formula_bump_response) def parse_formula_bump_response(formula_bump_response)
response, status = formula_bump_response response, status = formula_bump_response
response response
end end
def check_for_open_pr(formula_name, download_url) def check_for_open_pr(formula_name, download_url)
@ -48,8 +48,7 @@ class BrewCommands
response = bump_formula_pr(formula_name, download_url) response = bump_formula_pr(formula_name, download_url)
return true if !response.include? 'Error: These open pull requests may be duplicates' !response.include? 'Error: These open pull requests may be duplicates'
false end
end
end end