From f82da9009fe0f862df5ed534d3914a51bf4718f2 Mon Sep 17 00:00:00 2001 From: Elizabeth Tackett Date: Mon, 29 Jun 2020 09:33:24 -0500 Subject: [PATCH] remove unnecessary explicit return val --- Library/Homebrew/utils/update.rb | 3 +-- scripts/helpers/brew_commands.rb | 13 ++++++------- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/Library/Homebrew/utils/update.rb b/Library/Homebrew/utils/update.rb index 87b363bb08..48a18daa10 100644 --- a/Library/Homebrew/utils/update.rb +++ b/Library/Homebrew/utils/update.rb @@ -120,8 +120,7 @@ module Utils puts "==============Formatted outdated packages============\n" outdated_packages.each do |package_name, package_details| - puts "" - puts "Formula: #{package_name}" + puts "\nFormula: #{package_name}" puts "Current formula version: #{package_details['homebrew_version']}" puts "Repology latest version: #{package_details['repology_version']}" puts "Livecheck latest version: #{package_details['livecheck_latest_version']}" diff --git a/scripts/helpers/brew_commands.rb b/scripts/helpers/brew_commands.rb index 526162095b..380e64da48 100644 --- a/scripts/helpers/brew_commands.rb +++ b/scripts/helpers/brew_commands.rb @@ -1,7 +1,7 @@ require "open3" class BrewCommands - + def livecheck_check_formula(formula_name) puts "- livecheck formula : #{formula_name}" command_args = [ @@ -20,7 +20,7 @@ class BrewCommands # eg: ["burp", "2.2.18", "2.2.18"] package_name, brew_version, latest_version = livecheck_output - + {'name' => package_name, 'current_brew_version' => brew_version, 'livecheck_latest_version' => latest_version} end @@ -40,7 +40,7 @@ class BrewCommands def parse_formula_bump_response(formula_bump_response) response, status = formula_bump_response - response + response end def check_for_open_pr(formula_name, download_url) @@ -48,8 +48,7 @@ class BrewCommands response = bump_formula_pr(formula_name, download_url) - return true if !response.include? 'Error: These open pull requests may be duplicates' - false - end + !response.include? 'Error: These open pull requests may be duplicates' + end -end \ No newline at end of file +end