admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

versions: use the actual class name when unloading

Browse Source 
And document a bit more why this hack is present.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
This commit is contained in:
Jack Nagel 2012-01-12 00:57:23 -06:00
parent 1ed22ff1c3
commit e9a0f24ccb
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Library/Homebrew/cmd/versions.rb
View File

@ -62,8 +62,15 @@ class Formula
mktemp do mktemp do
path = Pathname.new(Pathname.pwd+"#{name}.rb") path = Pathname.new(Pathname.pwd+"#{name}.rb")
path.write text_from_sha(sha) path.write text_from_sha(sha)
# FIXME: shouldn't have to do this?
Object.send(:remove_const, "#{name.capitalize}") # Unload the class so Formula#version returns the correct value.
# Note that this means that the command will error out after it
# encounters a formula that won't import. This doesn't matter
# for most formulae, but e.g. Bash at revision aae084c9db has a
# syntax error and so `versions` isn't able to walk very far back
# through the history.
# FIXME shouldn't have to do this?
Object.send(:remove_const, "#{Formula.class_s(name)}")
Formula.factory(path).version Formula.factory(path).version
end rescue nil end rescue nil
end end