From e9a0f24ccbd74e9494e0641037d27b23631e22cf Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Thu, 12 Jan 2012 00:57:23 -0600 Subject: [PATCH] versions: use the actual class name when unloading And document a bit more why this hack is present. Signed-off-by: Jack Nagel --- Library/Homebrew/cmd/versions.rb | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cmd/versions.rb b/Library/Homebrew/cmd/versions.rb index 6962825450..5a84e9b50b 100644 --- a/Library/Homebrew/cmd/versions.rb +++ b/Library/Homebrew/cmd/versions.rb @@ -62,8 +62,15 @@ class Formula mktemp do path = Pathname.new(Pathname.pwd+"#{name}.rb") path.write text_from_sha(sha) - # FIXME: shouldn't have to do this? - Object.send(:remove_const, "#{name.capitalize}") + + # Unload the class so Formula#version returns the correct value. + # Note that this means that the command will error out after it + # encounters a formula that won't import. This doesn't matter + # for most formulae, but e.g. Bash at revision aae084c9db has a + # syntax error and so `versions` isn't able to walk very far back + # through the history. + # FIXME shouldn't have to do this? + Object.send(:remove_const, "#{Formula.class_s(name)}") Formula.factory(path).version end rescue nil end