admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Migrate VERSIONED_FORMULAE_CONFLICTS_ALLOWLIST

Browse Source
This commit is contained in:
Rylan Polster 2020-11-27 01:23:19 -05:00
parent 80a46edee4
commit e823dd713e
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Library/Homebrew/rubocops/conflicts.rb
View File

@ -12,10 +12,6 @@ module RuboCop
MSG = "Versioned formulae should not use `conflicts_with`. " \ MSG = "Versioned formulae should not use `conflicts_with`. " \
"Use `keg_only :versioned_formula` instead." "Use `keg_only :versioned_formula` instead."
ALLOWLIST = %w[
bash-completion@2
].freeze
def audit_formula(_node, _class_node, _parent_class_node, body_node) def audit_formula(_node, _class_node, _parent_class_node, body_node)
find_method_calls_by_name(body_node, :conflicts_with).each do |conflicts_with_call| find_method_calls_by_name(body_node, :conflicts_with).each do |conflicts_with_call|
next unless parameters(conflicts_with_call).last.respond_to? :values next unless parameters(conflicts_with_call).last.respond_to? :values
@ -35,7 +31,7 @@ module RuboCop
return unless versioned_formula? return unless versioned_formula?
problem MSG if !ALLOWLIST.include?(@formula_name) && problem MSG if !tap_style_exception?(:versioned_formulae_conflicts_allowlist) &&
method_called_ever?(body_node, :conflicts_with) method_called_ever?(body_node, :conflicts_with)
end end

2
Library/Homebrew/test/rubocops/conflicts_spec.rb
View File

@ -85,6 +85,4 @@ describe RuboCop::Cop::FormulaAudit::Conflicts do
expect(new_source).to eq(corrected_source) expect(new_source).to eq(corrected_source)
end end
end end
include_examples "formulae exist", described_class::ALLOWLIST
end end