diff --git a/Library/Homebrew/rubocops/conflicts.rb b/Library/Homebrew/rubocops/conflicts.rb index 7a24be5ce1..dd8e524e14 100644 --- a/Library/Homebrew/rubocops/conflicts.rb +++ b/Library/Homebrew/rubocops/conflicts.rb @@ -12,10 +12,6 @@ module RuboCop MSG = "Versioned formulae should not use `conflicts_with`. " \ "Use `keg_only :versioned_formula` instead." - ALLOWLIST = %w[ - bash-completion@2 - ].freeze - def audit_formula(_node, _class_node, _parent_class_node, body_node) find_method_calls_by_name(body_node, :conflicts_with).each do |conflicts_with_call| next unless parameters(conflicts_with_call).last.respond_to? :values @@ -35,7 +31,7 @@ module RuboCop return unless versioned_formula? - problem MSG if !ALLOWLIST.include?(@formula_name) && + problem MSG if !tap_style_exception?(:versioned_formulae_conflicts_allowlist) && method_called_ever?(body_node, :conflicts_with) end diff --git a/Library/Homebrew/test/rubocops/conflicts_spec.rb b/Library/Homebrew/test/rubocops/conflicts_spec.rb index 3d2fe41462..b853af3329 100644 --- a/Library/Homebrew/test/rubocops/conflicts_spec.rb +++ b/Library/Homebrew/test/rubocops/conflicts_spec.rb @@ -85,6 +85,4 @@ describe RuboCop::Cop::FormulaAudit::Conflicts do expect(new_source).to eq(corrected_source) end end - - include_examples "formulae exist", described_class::ALLOWLIST end