admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

dev-cmd/typecheck: improve exit code handling.

Browse Source
This commit is contained in:
Mike McQuaid 2024-07-04 08:27:21 +01:00 committed by GitHub
parent e52a582290
commit e7b9a732b4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.github/workflows/sorbet.yml vendored
View File

@ -46,7 +46,6 @@ jobs:
- name: Update RBI files - name: Update RBI files
id: update id: update
working-directory: ${{ steps.set-up-homebrew.outputs.repository-path }} working-directory: ${{ steps.set-up-homebrew.outputs.repository-path }}
continue-on-error: true
run: | run: |
if [[ "${GITHUB_EVENT_NAME}" != "pull_request" ]] if [[ "${GITHUB_EVENT_NAME}" != "pull_request" ]]
then then

4
Library/Homebrew/dev-cmd/typecheck.rb
View File

@ -60,9 +60,9 @@ module Homebrew
if args.suggest_typed? if args.suggest_typed?
ohai "Checking if we can bump Sorbet `typed` sigils..." ohai "Checking if we can bump Sorbet `typed` sigils..."
# --sorbet needed because of https://github.com/Shopify/spoom/issues/488 # --sorbet needed because of https://github.com/Shopify/spoom/issues/488
safe_system "bundle", "exec", "spoom", "srb", "bump", "--from", "false", "--to", "true", system "bundle", "exec", "spoom", "srb", "bump", "--from", "false", "--to", "true",
"--sorbet", "#{Gem.bin_path("sorbet", "srb")} tc" "--sorbet", "#{Gem.bin_path("sorbet", "srb")} tc"
safe_system "bundle", "exec", "spoom", "srb", "bump", "--from", "true", "--to", "strict", system "bundle", "exec", "spoom", "srb", "bump", "--from", "true", "--to", "strict",
"--sorbet", "#{Gem.bin_path("sorbet", "srb")} tc" "--sorbet", "#{Gem.bin_path("sorbet", "srb")} tc"
end end