From e7b9a732b4ba879e31898f8ae6f977019a8f2396 Mon Sep 17 00:00:00 2001
From: Mike McQuaid <mike@mikemcquaid.com>
Date: Thu, 4 Jul 2024 08:27:21 +0100
Subject: [PATCH] dev-cmd/typecheck: improve exit code handling.

---
 .github/workflows/sorbet.yml          | 1 -
 Library/Homebrew/dev-cmd/typecheck.rb | 4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/sorbet.yml b/.github/workflows/sorbet.yml
index b928ebe679..34873decea 100644
--- a/.github/workflows/sorbet.yml
+++ b/.github/workflows/sorbet.yml
@@ -46,7 +46,6 @@ jobs:
       - name: Update RBI files
         id: update
         working-directory: ${{ steps.set-up-homebrew.outputs.repository-path }}
-        continue-on-error: true
         run: |
           if [[ "${GITHUB_EVENT_NAME}" != "pull_request" ]]
           then
diff --git a/Library/Homebrew/dev-cmd/typecheck.rb b/Library/Homebrew/dev-cmd/typecheck.rb
index 272a9ed285..def2b9652e 100644
--- a/Library/Homebrew/dev-cmd/typecheck.rb
+++ b/Library/Homebrew/dev-cmd/typecheck.rb
@@ -60,9 +60,9 @@ module Homebrew
             if args.suggest_typed?
               ohai "Checking if we can bump Sorbet `typed` sigils..."
               # --sorbet needed because of https://github.com/Shopify/spoom/issues/488
-              safe_system "bundle", "exec", "spoom", "srb", "bump", "--from", "false", "--to", "true",
+              system "bundle", "exec", "spoom", "srb", "bump", "--from", "false", "--to", "true",
                           "--sorbet", "#{Gem.bin_path("sorbet", "srb")} tc"
-              safe_system "bundle", "exec", "spoom", "srb", "bump", "--from", "true", "--to", "strict",
+              system "bundle", "exec", "spoom", "srb", "bump", "--from", "true", "--to", "strict",
                           "--sorbet", "#{Gem.bin_path("sorbet", "srb")} tc"
             end