admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #10567 from MikeMcQuaid/env-ci-rubocop

Browse Source 
rubocops/lines: check for `if ENV["CI"]` usage.
This commit is contained in:
Mike McQuaid 2021-02-12 14:49:48 +00:00 committed by GitHub
commit e2cbc91689
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Library/Homebrew/rubocops/lines.rb
View File

@ -546,6 +546,15 @@ module RuboCop
problem "`depends_on` can take requirement classes instead of instances" problem "`depends_on` can take requirement classes instead of instances"
end end
find_instance_method_call(body_node, "ENV", :[]) do |method|
next unless modifier?(method.parent)
param = parameters(method).first
next unless node_equals?(param, "CI")
problem 'Don\'t use ENV["CI"] for Homebrew CI checks.'
end
find_instance_method_call(body_node, "Dir", :[]) do |method| find_instance_method_call(body_node, "Dir", :[]) do |method|
next unless parameters(method).size == 1 next unless parameters(method).size == 1