Deletion of files added in PR. -o addition is only one needed argument in unpack_strategy/tar.rb.

update gnu_tar.rb

removed tab

update unpacking_strategy/tar.rb

to resolve conversations
But OFFENCE found, W: 31: 36: Unused method argument - basename (brew style)
Now I start to using rubocop inside Sublime_text3 where I see all right linting messages.

Rollback install.rb changes.

Conversation resolved, extra_args: "--owner=0", "--group=0" and "--no-same-owner" in extend/os/linux/gnu_tar.rb.

Conversation: file extend/os/linux/gnu_tar.rb moved to extend/os/linux/unpack_strategy/tar.rb. Module UnpackStrategy is parent for the GnuTar module.

Conversation: new file extent/unpack_strategy/tar.rb to require logic, unpack_strategy/tar.rb newline bef. require-line, require-line changed.

Deletion of files added in PR. -o addition is only one needed argument in unpack_strategy/tar.rb.
This commit is contained in:
JuPlutonic 2019-02-26 10:12:47 +00:00
parent d1f755959a
commit e0bf31764e

View File

@ -38,7 +38,7 @@ module UnpackStrategy
end end
system_command! "tar", system_command! "tar",
args: ["xf", tar_path, "-C", unpack_dir], args: ["xof", tar_path, "-C", unpack_dir],
verbose: verbose verbose: verbose
end end
end end