From e0bf31764e803d58c979633467b906e7ea21f069 Mon Sep 17 00:00:00 2001 From: JuPlutonic <8gzi0c+11ezb3n4oio0zf24zw@sharklasers.com> Date: Tue, 26 Feb 2019 10:12:47 +0000 Subject: [PATCH] Deletion of files added in PR. -o addition is only one needed argument in unpack_strategy/tar.rb. update gnu_tar.rb removed tab update unpacking_strategy/tar.rb to resolve conversations But OFFENCE found, W: 31: 36: Unused method argument - basename (brew style) Now I start to using rubocop inside Sublime_text3 where I see all right linting messages. Rollback install.rb changes. Conversation resolved, extra_args: "--owner=0", "--group=0" and "--no-same-owner" in extend/os/linux/gnu_tar.rb. Conversation: file extend/os/linux/gnu_tar.rb moved to extend/os/linux/unpack_strategy/tar.rb. Module UnpackStrategy is parent for the GnuTar module. Conversation: new file extent/unpack_strategy/tar.rb to require logic, unpack_strategy/tar.rb newline bef. require-line, require-line changed. Deletion of files added in PR. -o addition is only one needed argument in unpack_strategy/tar.rb. --- Library/Homebrew/unpack_strategy/tar.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/unpack_strategy/tar.rb b/Library/Homebrew/unpack_strategy/tar.rb index 1b229a2902..3ef8fe7b92 100644 --- a/Library/Homebrew/unpack_strategy/tar.rb +++ b/Library/Homebrew/unpack_strategy/tar.rb @@ -38,7 +38,7 @@ module UnpackStrategy end system_command! "tar", - args: ["xf", tar_path, "-C", unpack_dir], + args: ["xof", tar_path, "-C", unpack_dir], verbose: verbose end end