admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Fix installation error from ARGV --HEAD filter

Browse Source 
The ARGV filtering would strip `--HEAD` from dependency installations,
then proceed with trying to install the dependency from the latest
version in the formula. This causes an error if the latest version is
already installed, so check to see if formula is installed before
performing the installation.

Closes Homebrew/homebrew#8869.

Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
This commit is contained in:
Misty De Meo 2011-11-29 10:43:02 -06:00 committed by Charlie Sharpsteen
parent 9898956047
commit d9c3f19e6a
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Library/Homebrew/formula_installer.rb
View File

@ -33,9 +33,10 @@ class FormulaInstaller
else
ARGV.filter_for_dependencies do
# Re-create the formula object so that args like `--HEAD` won't
# affect properties like the installation prefix.
# affect properties like the installation prefix. Also need to
# re-check installed status as the Formula may have changed.
dep = Formula.factory dep.name
install_dependency dep
install_dependency dep unless dep.installed?
end
end
end