From d9c3f19e6a7e13081982c93ba335e23a136c688f Mon Sep 17 00:00:00 2001 From: Misty De Meo Date: Tue, 29 Nov 2011 10:43:02 -0600 Subject: [PATCH] Fix installation error from ARGV `--HEAD` filter The ARGV filtering would strip `--HEAD` from dependency installations, then proceed with trying to install the dependency from the latest version in the formula. This causes an error if the latest version is already installed, so check to see if formula is installed before performing the installation. Closes Homebrew/homebrew#8869. Signed-off-by: Charlie Sharpsteen --- Library/Homebrew/formula_installer.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb index bd7c672c32..7a2ee653c8 100644 --- a/Library/Homebrew/formula_installer.rb +++ b/Library/Homebrew/formula_installer.rb @@ -33,9 +33,10 @@ class FormulaInstaller else ARGV.filter_for_dependencies do # Re-create the formula object so that args like `--HEAD` won't - # affect properties like the installation prefix. + # affect properties like the installation prefix. Also need to + # re-check installed status as the Formula may have changed. dep = Formula.factory dep.name - install_dependency dep + install_dependency dep unless dep.installed? end end end