admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

test-bot: stop using --recursive for brew uses

Browse Source 
We're not sure this is working as it was intended to, and the primary
end product so far has been making every Ruby 1.8.7 build, which is the Ruby
we use on Mavericks for compatibility, take 5-15 minutes longer per build
than 2.x Rubies.

Cumulatively this is responsible for the vast majority of CI slowness over the
last couple months as Mavericks plays catch-up and everything else waits for it
to do so.

We may revisit this in future, but for now the harm is greater than the "risk".

This technically reverts 7b26c585c2.
This commit is contained in:
Dominyk Tiller 2016-04-06 17:57:05 +01:00
parent 7771f3af81
commit bbb1fcd17c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/cmd/test-bot.rb
View File

@ -410,7 +410,7 @@ module Homebrew
def formula(formula_name)
@category = "#{__method__}.#{formula_name}"
test "brew", "uses", "--recursive", formula_name
test "brew", "uses", formula_name
formula = Formulary.factory(formula_name)
@ -508,7 +508,7 @@ module Homebrew
build_dependencies = dependencies - runtime_dependencies
unchanged_build_dependencies = build_dependencies - @formulae
dependents = Utils.popen_read("brew", "uses", "--recursive", "--skip-build", "--skip-optional", formula_name).split("\n")
dependents = Utils.popen_read("brew", "uses", "--skip-build", "--skip-optional", formula_name).split("\n")
dependents -= @formulae
dependents = dependents.map { |d| Formulary.factory(d) }