From bbb1fcd17c0979c5d7d90097108b39526fa94acb Mon Sep 17 00:00:00 2001 From: Dominyk Tiller Date: Wed, 6 Apr 2016 17:57:05 +0100 Subject: [PATCH] test-bot: stop using --recursive for `brew uses` We're not sure this is working as it was intended to, and the primary end product so far has been making every Ruby 1.8.7 build, which is the Ruby we use on Mavericks for compatibility, take 5-15 minutes longer per build than 2.x Rubies. Cumulatively this is responsible for the vast majority of CI slowness over the last couple months as Mavericks plays catch-up and everything else waits for it to do so. We may revisit this in future, but for now the harm is greater than the "risk". This technically reverts https://github.com/Homebrew/brew/commit/7b26c585c2a26ec0dad201852ca4934c77fcc493. --- Library/Homebrew/cmd/test-bot.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cmd/test-bot.rb b/Library/Homebrew/cmd/test-bot.rb index c14461c628..1cc61ce117 100644 --- a/Library/Homebrew/cmd/test-bot.rb +++ b/Library/Homebrew/cmd/test-bot.rb @@ -410,7 +410,7 @@ module Homebrew def formula(formula_name) @category = "#{__method__}.#{formula_name}" - test "brew", "uses", "--recursive", formula_name + test "brew", "uses", formula_name formula = Formulary.factory(formula_name) @@ -508,7 +508,7 @@ module Homebrew build_dependencies = dependencies - runtime_dependencies unchanged_build_dependencies = build_dependencies - @formulae - dependents = Utils.popen_read("brew", "uses", "--recursive", "--skip-build", "--skip-optional", formula_name).split("\n") + dependents = Utils.popen_read("brew", "uses", "--skip-build", "--skip-optional", formula_name).split("\n") dependents -= @formulae dependents = dependents.map { |d| Formulary.factory(d) }