admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

do not use parantheses if no args given to method

Browse Source
This commit is contained in:
Max Eisner 2022-07-24 23:09:58 +02:00
parent 0509eebda4
commit b901e5873d
No known key found for this signature in database
GPG Key ID: 4BF122C22879F0C8
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Library/Homebrew/rubocops/lines.rb
View File

@ -449,7 +449,11 @@ module RuboCop
replacement_args << "shell_prefix: #{shell_prefix}" unless shell_prefix.nil? replacement_args << "shell_prefix: #{shell_prefix}" unless shell_prefix.nil?
offending_node(node) offending_node(node)
replacement = "generate_completions(#{replacement_args.join(", ")})" replacement = if replacement_args.blank?
"generate_completions"
else
"generate_completions(#{replacement_args.join(", ")})"
end
problem "Use `#{replacement}` instead of `#{@offensive_node.source}`." do |corrector| problem "Use `#{replacement}` instead of `#{@offensive_node.source}`." do |corrector|
corrector.replace(@offensive_node.source_range, replacement) corrector.replace(@offensive_node.source_range, replacement)
end end