From b901e5873dc5381fb1259efb29b1be00e96ce54b Mon Sep 17 00:00:00 2001 From: Max Eisner <4730112+max-ae@users.noreply.github.com> Date: Sun, 24 Jul 2022 23:09:58 +0200 Subject: [PATCH] do not use parantheses if no args given to method --- Library/Homebrew/rubocops/lines.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/rubocops/lines.rb b/Library/Homebrew/rubocops/lines.rb index 4faf9d8092..ffc52b8080 100644 --- a/Library/Homebrew/rubocops/lines.rb +++ b/Library/Homebrew/rubocops/lines.rb @@ -449,7 +449,11 @@ module RuboCop replacement_args << "shell_prefix: #{shell_prefix}" unless shell_prefix.nil? offending_node(node) - replacement = "generate_completions(#{replacement_args.join(", ")})" + replacement = if replacement_args.blank? + "generate_completions" + else + "generate_completions(#{replacement_args.join(", ")})" + end problem "Use `#{replacement}` instead of `#{@offensive_node.source}`." do |corrector| corrector.replace(@offensive_node.source_range, replacement) end