admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Always output when tapping core

Browse Source 
Hiding all output makes it look like Homebrew is hanging while the tap
operation (which can take a long time!) is running.

Closes #3053.
This commit is contained in:
Alyssa Ross 2017-09-07 12:09:52 +01:00
parent 5b041528af
commit b6d36003b3
No known key found for this signature in database
GPG Key ID: E7DCC566F9A36D30
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/cmd/update-report.rb
View File

@ -124,7 +124,7 @@ module Homebrew
return if ENV["HOMEBREW_UPDATE_TEST"] return if ENV["HOMEBREW_UPDATE_TEST"]
core_tap = CoreTap.instance core_tap = CoreTap.instance
return if core_tap.installed? return if core_tap.installed?
CoreTap.ensure_installed! quiet: false CoreTap.ensure_installed!
revision = core_tap.git_head revision = core_tap.git_head
ENV["HOMEBREW_UPDATE_BEFORE_HOMEBREW_HOMEBREW_CORE"] = revision ENV["HOMEBREW_UPDATE_BEFORE_HOMEBREW_HOMEBREW_CORE"] = revision
ENV["HOMEBREW_UPDATE_AFTER_HOMEBREW_HOMEBREW_CORE"] = revision ENV["HOMEBREW_UPDATE_AFTER_HOMEBREW_HOMEBREW_CORE"] = revision

6
Library/Homebrew/tap.rb
View File

@ -551,11 +551,9 @@ class CoreTap < Tap
@instance ||= new @instance ||= new
end end
def self.ensure_installed!(options = {}) def self.ensure_installed!
return if instance.installed? return if instance.installed?
args = ["tap", instance.name] safe_system HOMEBREW_BREW_FILE, "tap", instance.name
args << "-q" if options.fetch(:quiet, true)
safe_system HOMEBREW_BREW_FILE, *args
end end
# @private # @private