From b6d36003b336dee36d4c11a621b4061bc0615284 Mon Sep 17 00:00:00 2001 From: Alyssa Ross Date: Thu, 7 Sep 2017 12:09:52 +0100 Subject: [PATCH] Always output when tapping core Hiding all output makes it look like Homebrew is hanging while the tap operation (which can take a long time!) is running. Closes #3053. --- Library/Homebrew/cmd/update-report.rb | 2 +- Library/Homebrew/tap.rb | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/Library/Homebrew/cmd/update-report.rb b/Library/Homebrew/cmd/update-report.rb index 164413cd12..781ee88081 100644 --- a/Library/Homebrew/cmd/update-report.rb +++ b/Library/Homebrew/cmd/update-report.rb @@ -124,7 +124,7 @@ module Homebrew return if ENV["HOMEBREW_UPDATE_TEST"] core_tap = CoreTap.instance return if core_tap.installed? - CoreTap.ensure_installed! quiet: false + CoreTap.ensure_installed! revision = core_tap.git_head ENV["HOMEBREW_UPDATE_BEFORE_HOMEBREW_HOMEBREW_CORE"] = revision ENV["HOMEBREW_UPDATE_AFTER_HOMEBREW_HOMEBREW_CORE"] = revision diff --git a/Library/Homebrew/tap.rb b/Library/Homebrew/tap.rb index f232be4281..f6246aad90 100644 --- a/Library/Homebrew/tap.rb +++ b/Library/Homebrew/tap.rb @@ -551,11 +551,9 @@ class CoreTap < Tap @instance ||= new end - def self.ensure_installed!(options = {}) + def self.ensure_installed! return if instance.installed? - args = ["tap", instance.name] - args << "-q" if options.fetch(:quiet, true) - safe_system HOMEBREW_BREW_FILE, *args + safe_system HOMEBREW_BREW_FILE, "tap", instance.name end # @private